Re: [PATCH V17 12/13] iothread: make legacy AioContext getter explicitly unsafe

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 934 bytes --]

On Tue, Sep 15, 2026 at 06:16:54PM +0800, Zhang Chen wrote:
> Now that holder-aware callers have been converted, rename
> iothread_get_aio_context() to iothread_unsafe_get_aio_context() and
> update qmp_x_blockdev_set_iothread().
> 
> The block graph retains only the AioContext, while detachment happens
> outside qmp_x_blockdev_set_iothread(), so this call site cannot provide
> a matching holder lifecycle. The new name makes its existing lifetime
> assumption explicit.
> 
> New code should use iothread_ref_and_get_aio_context().
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Zhang Chen <zhangckid@gmail.com>
> ---
>  blockdev.c                |  9 ++++++++-
>  include/system/iothread.h | 11 ++++++++++-
>  iothread.c                |  2 +-
>  3 files changed, 19 insertions(+), 3 deletions(-)

With Markus' feedback addressed:
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]