All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Farman <farman@linux.ibm.com>
To: Christian Borntraeger <borntraeger@linux.ibm.com>,
	Matthew Rosato <mjrosato@linux.ibm.com>
Cc: Cornelia Huck <cohuck@redhat.com>,
	qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
	Eric Farman <farman@linux.ibm.com>,
	qemu-stable@nongnu.org
Subject: [PATCH 6/9] hw/intc/s390x: Fix payload to KVM_HAS_DEVICE_ATTR ioctl
Date: Wed, 16 Sep 2026 22:32:38 +0200	[thread overview]
Message-ID: <20260916203242.2509787-7-farman@linux.ibm.com> (raw)
In-Reply-To: <20260916203242.2509787-1-farman@linux.ibm.com>

The ioctl to determine whether KVM_DEV_FLIC_CLEAR_IO_IRQ is present
receives the contents of the attribute struct as its payload,
rather than a pointer to the payload itself as is convention.

This may result in erroneous errors from the ioctl, which would
result in clear_io_supported being false when it otherwise could
be used (which is helpful in device recovery).

Cc: qemu-stable@nongnu.org
Fixes: 9eccb8622c ("s390x/kvm: add interface for clearing IO irqs")
Signed-off-by: Eric Farman <farman@linux.ibm.com>
---
 hw/intc/s390_flic_kvm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/intc/s390_flic_kvm.c b/hw/intc/s390_flic_kvm.c
index f833a3996a..5e6d422fba 100644
--- a/hw/intc/s390_flic_kvm.c
+++ b/hw/intc/s390_flic_kvm.c
@@ -633,7 +633,7 @@ static void kvm_s390_flic_realize(DeviceState *dev, Error **errp)
     /* Check clear_io_irq support */
     test_attr.group = KVM_DEV_FLIC_CLEAR_IO_IRQ;
     flic_state->clear_io_supported = !ioctl(flic_state->fd,
-                                            KVM_HAS_DEVICE_ATTR, test_attr);
+                                            KVM_HAS_DEVICE_ATTR, &test_attr);
 }
 
 static void kvm_s390_flic_reset(DeviceState *dev)
-- 
2.53.0



  parent reply	other threads:[~2026-09-16 20:34 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16 20:32 [PATCH 0/9] s390x: even more hardening fixes Eric Farman
2026-09-16 20:32 ` [PATCH 1/9] virtio-ccw: Limit ISC to MAX_ISC Eric Farman
2026-09-16 23:15   ` Matthew Rosato
2026-09-17  7:36     ` Christian Borntraeger
2026-09-17 12:09     ` Eric Farman
2026-09-21 15:02       ` Eric Farman
2026-09-16 20:32 ` [PATCH 2/9] virtio-ccw: Do not overwrite existing indicators Eric Farman
2026-09-16 23:15   ` Matthew Rosato
2026-09-17  7:35   ` Christian Borntraeger
2026-09-17 16:17     ` Eric Farman
2026-09-16 20:32 ` [PATCH 3/9] virtio-ccw: Fix rc check in read configuration path Eric Farman
2026-09-16 23:15   ` Matthew Rosato
2026-09-16 20:32 ` [PATCH 4/9] vfio/ap: Clear error object pointer after non-fatal errors Eric Farman
2026-09-16 23:15   ` Matthew Rosato
2026-09-17 12:50   ` Anthony Krowiak
2026-09-16 20:32 ` [PATCH 5/9] vfio/ccw: " Eric Farman
2026-09-16 23:15   ` Matthew Rosato
2026-09-17 12:23     ` Eric Farman
2026-09-16 20:32 ` Eric Farman [this message]
2026-09-16 23:15   ` [PATCH 6/9] hw/intc/s390x: Fix payload to KVM_HAS_DEVICE_ATTR ioctl Matthew Rosato
2026-09-17  7:45   ` Christian Borntraeger
2026-09-17 12:15     ` Eric Farman
2026-09-17 12:25       ` Christian Borntraeger
2026-09-16 20:32 ` [PATCH 7/9] hw/intc/s390x: Fix check after g_try_realloc Eric Farman
2026-09-16 23:16   ` Matthew Rosato
2026-09-17 12:57     ` Eric Farman
2026-09-16 20:32 ` [PATCH 8/9] s390x/css: Expand check against no-data-count CCWs Eric Farman
2026-09-16 23:16   ` Matthew Rosato
2026-09-17 15:55     ` Eric Farman
2026-09-16 20:32 ` [PATCH 9/9] s390x/sclp: Reject short headers in PV case Eric Farman
2026-09-16 23:16   ` Matthew Rosato
2026-09-17  7:53   ` Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260916203242.2509787-7-farman@linux.ibm.com \
    --to=farman@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=mjrosato@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.