From: Eric Farman <farman@linux.ibm.com>
To: Christian Borntraeger <borntraeger@linux.ibm.com>,
Matthew Rosato <mjrosato@linux.ibm.com>
Cc: Cornelia Huck <cohuck@redhat.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
Eric Farman <farman@linux.ibm.com>
Subject: [PATCH 8/9] s390x/css: Expand check against no-data-count CCWs
Date: Wed, 16 Sep 2026 22:32:40 +0200 [thread overview]
Message-ID: <20260916203242.2509787-9-farman@linux.ibm.com> (raw)
In-Reply-To: <20260916203242.2509787-1-farman@linux.ibm.com>
The channel subsystem will reject channel programs that incorporate
256 CCWs without a data transfer, but the existing check for this
does so against a data address of zero. Expand the check to include
other CCWs that are valid but would transfer no data.
Fixes: e8601dd5d0 ("s390x/css: catch ccw sequence errors")
Signed-off-by: Eric Farman <farman@linux.ibm.com>
---
hw/s390x/css.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/s390x/css.c b/hw/s390x/css.c
index 9da9128d88..c38549c7be 100644
--- a/hw/s390x/css.c
+++ b/hw/s390x/css.c
@@ -1016,7 +1016,9 @@ static int css_interpret_ccw(SubchDev *sch, hwaddr ccw_addr,
check_len = !((ccw.flags & CCW_FLAG_SLI) && !(ccw.flags & CCW_FLAG_DC));
- if (!ccw.cda) {
+ if (!ccw.cda ||
+ (ccw.flags & CCW_FLAG_SKIP) ||
+ (ccw.cmd_code == CCW_CMD_NOOP)) {
if (sch->ccw_no_data_cnt == 255) {
return -EINVAL;
}
--
2.53.0
next prev parent reply other threads:[~2026-09-16 20:35 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 20:32 [PATCH 0/9] s390x: even more hardening fixes Eric Farman
2026-09-16 20:32 ` [PATCH 1/9] virtio-ccw: Limit ISC to MAX_ISC Eric Farman
2026-09-16 23:15 ` Matthew Rosato
2026-09-17 7:36 ` Christian Borntraeger
2026-09-17 12:09 ` Eric Farman
2026-09-21 15:02 ` Eric Farman
2026-09-16 20:32 ` [PATCH 2/9] virtio-ccw: Do not overwrite existing indicators Eric Farman
2026-09-16 23:15 ` Matthew Rosato
2026-09-17 7:35 ` Christian Borntraeger
2026-09-17 16:17 ` Eric Farman
2026-09-16 20:32 ` [PATCH 3/9] virtio-ccw: Fix rc check in read configuration path Eric Farman
2026-09-16 23:15 ` Matthew Rosato
2026-09-16 20:32 ` [PATCH 4/9] vfio/ap: Clear error object pointer after non-fatal errors Eric Farman
2026-09-16 23:15 ` Matthew Rosato
2026-09-17 12:50 ` Anthony Krowiak
2026-09-16 20:32 ` [PATCH 5/9] vfio/ccw: " Eric Farman
2026-09-16 23:15 ` Matthew Rosato
2026-09-17 12:23 ` Eric Farman
2026-09-16 20:32 ` [PATCH 6/9] hw/intc/s390x: Fix payload to KVM_HAS_DEVICE_ATTR ioctl Eric Farman
2026-09-16 23:15 ` Matthew Rosato
2026-09-17 7:45 ` Christian Borntraeger
2026-09-17 12:15 ` Eric Farman
2026-09-17 12:25 ` Christian Borntraeger
2026-09-16 20:32 ` [PATCH 7/9] hw/intc/s390x: Fix check after g_try_realloc Eric Farman
2026-09-16 23:16 ` Matthew Rosato
2026-09-17 12:57 ` Eric Farman
2026-09-16 20:32 ` Eric Farman [this message]
2026-09-16 23:16 ` [PATCH 8/9] s390x/css: Expand check against no-data-count CCWs Matthew Rosato
2026-09-17 15:55 ` Eric Farman
2026-09-16 20:32 ` [PATCH 9/9] s390x/sclp: Reject short headers in PV case Eric Farman
2026-09-16 23:16 ` Matthew Rosato
2026-09-17 7:53 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260916203242.2509787-9-farman@linux.ibm.com \
--to=farman@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.