Re: [PATCH net-next v19 2/3] net: phy: Add support for Template Control register for PMA

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] uapi: use of kernel-internal GENMASK in UAPI header
--

commit ccf2fd652b5c489e327ab08ec390f834e2c1b18b
Author: Kyle Switch <kyle.switch@motor-comm.com>

net: phy: Add support for Template Control register for PMA

This patch adds support for the 10GBASE-T PMA Template Test Mode register
field. It introduces standard MDIO macros and helper functions to select
one of eight test modes used for PHY validation.

> diff --git a/include/uapi/linux/mdio.h b/include/uapi/linux/mdio.h
> index 06f4bc3c20c71..353ca13c64fca 100644
> --- a/include/uapi/linux/mdio.h
> +++ b/include/uapi/linux/mdio.h

[ ... ]

> @@ -320,6 +321,17 @@
>  /* PMA 10GBASE-R Fast Retrain status and control register. */
>  #define MDIO_PMA_10GBR_FSRT_ENABLE	0x0001	/* Fast retrain enable */
>  
> +/* PMA 10GBASE-T Template Test Mode Register*/
> +#define MDIO_PMA_10GBT_TESTMODE_MASK GENMASK(15, 13) /* Template test mode */

[Severity: Medium]
Will this macro break compilation for userspace applications?

GENMASK is a kernel-internal macro defined in <linux/bits.h> and is not
exported to userspace. Any userspace program attempting to include this UAPI
header and use MDIO_PMA_10GBT_TESTMODE_MASK will fail to compile due to an
undefined macro.

Could this be changed to use __GENMASK() or a hardcoded hexadecimal value
instead to ensure it is safe for userspace consumption?

> +#define MDIO_PMA_10GBT_TESTMODE_NORMAL 0x0 /* Template Normal */
> +#define MDIO_PMA_10GBT_TESTMODE_1 0x1 /* Template TestMode1 */
> +#define MDIO_PMA_10GBT_TESTMODE_2 0x2 /* Template TestMode2 */

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916105504.3262767-1-kyle.switch@motor-comm.com?part=2