Re: [PATCH net-next v19 1/3] dt-bindings: net: Document Motorcomm YT8824 PHY package

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] dt-bindings: net: motorcomm,yt8824: missing phy-mode property definition
- [Low] dt-bindings: net: motorcomm,yt8824: unit address vs reg mismatch in example
--

commit 27c278ec90007d3b5c93bdcce12996609edd6cb2
Author: Kyle Switch <kyle.switch@motor-comm.com>

dt-bindings: net: Document Motorcomm YT8824 PHY package

Motorcomm YT8824 Ethernet PHY is a PHY package of 4 PHYs.

> diff --git a/Documentation/devicetree/bindings/net/motorcomm,yt8824.yaml b/Documentation/devicetree/bindings/net/motorcomm,yt8824.yaml
> new file mode 100644
> index 0000000000000..93e9f765404a3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/motorcomm,yt8824.yaml
> @@ -0,0 +1,59 @@
[ ... ]
> +properties:
> +  compatible:
> +    enum:
> +      - motorcomm,yt8824-package
> +
> +required:
> +  - compatible
> +  - phy-mode

[Severity: Low]
Will this fail `make dt_binding_check`?

It looks like phy-mode is mandated as required here, but there is no
accompanying definition for it in the properties block. Because
`unevaluatedProperties: false` is set below, using this undeclared property
in the example will trigger a schema evaluation error.

> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    mdio {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        ethernet-phy-package@0 {
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +            compatible = "motorcomm,yt8824-package";
> +            reg = <9>;

[Severity: Low]
Is this unit address intentional?

The example's node uses a unit address of @0, but the reg property is set to
9, which conflicts directly and will cause the Device Tree compiler to emit
a `unit_address_vs_reg` warning.

> +
> +            phy-mode = "internal";
> +
> +            ethernet-phy@4 {
> +                reg = <4>;
> +            };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916105504.3262767-1-kyle.switch@motor-comm.com?part=1