All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Valerio Setti" <vsetti@baylibre.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org,
	neil.armstrong@linaro.org, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v2 1/6] ASoC: dt-bindings: amlogic,gx-audin: add schema
Date: Thu, 17 Sep 2026 21:07:58 +0000	[thread overview]
Message-ID: <20260917210759.0AAFB1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260917-audin-v2-1-38de4bc1de34@baylibre.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: amlogic,gx-audin: missing const constraint for #sound-dai-cells
--

commit 1813eec5eb42b623e2aae169825ca6cb3dcd09e8
Author: Valerio Setti <vsetti@baylibre.com>

ASoC: dt-bindings: amlogic,gx-audin: add schema

AUDIN provides I2S audio input support to the Meson GX platforms
(GXBB/GXL).

> diff --git a/Documentation/devicetree/bindings/sound/amlogic,gx-audin.yaml b/Documentation/devicetree/bindings/sound/amlogic,gx-audin.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/amlogic,gx-audin.yaml
[ ... ]
> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +properties:
> +  compatible:

[Severity: Low]
Should #sound-dai-cells be explicitly defined here with a const constraint?

The binding requires #sound-dai-cells below, but fails to define it in the
properties block with a const constraint. Relying on dai-common.yaml, which
only defines it as true (unconstrained), allows invalid configurations with
incorrect cell counts (e.g., <0> or <2>) to silently pass validation.

> +    items:
> +      - enum:
> +          - amlogic,gxbb-audin
> +          - amlogic,gxl-audin
> +      - const: amlogic,gx-audin
[ ... ]
> +required:
> +  - compatible
> +  - reg
> +  - resets
> +  - interrupts
> +  - clocks
> +  - "#sound-dai-cells"
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917-audin-v2-0-38de4bc1de34@baylibre.com?part=1

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Valerio Setti" <vsetti@baylibre.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org,
	neil.armstrong@linaro.org, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v2 1/6] ASoC: dt-bindings: amlogic,gx-audin: add schema
Date: Thu, 17 Sep 2026 21:07:58 +0000	[thread overview]
Message-ID: <20260917210759.0AAFB1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260917-audin-v2-1-38de4bc1de34@baylibre.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: amlogic,gx-audin: missing const constraint for #sound-dai-cells
--

commit 1813eec5eb42b623e2aae169825ca6cb3dcd09e8
Author: Valerio Setti <vsetti@baylibre.com>

ASoC: dt-bindings: amlogic,gx-audin: add schema

AUDIN provides I2S audio input support to the Meson GX platforms
(GXBB/GXL).

> diff --git a/Documentation/devicetree/bindings/sound/amlogic,gx-audin.yaml b/Documentation/devicetree/bindings/sound/amlogic,gx-audin.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/amlogic,gx-audin.yaml
[ ... ]
> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +properties:
> +  compatible:

[Severity: Low]
Should #sound-dai-cells be explicitly defined here with a const constraint?

The binding requires #sound-dai-cells below, but fails to define it in the
properties block with a const constraint. Relying on dai-common.yaml, which
only defines it as true (unconstrained), allows invalid configurations with
incorrect cell counts (e.g., <0> or <2>) to silently pass validation.

> +    items:
> +      - enum:
> +          - amlogic,gxbb-audin
> +          - amlogic,gxl-audin
> +      - const: amlogic,gx-audin
[ ... ]
> +required:
> +  - compatible
> +  - reg
> +  - resets
> +  - interrupts
> +  - clocks
> +  - "#sound-dai-cells"
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917-audin-v2-0-38de4bc1de34@baylibre.com?part=1

  reply	other threads:[~2026-09-17 21:08 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17 21:02 [PATCH v2 0/6] ASoC: meson: gx: add base support for I2S audio input Valerio Setti
2026-09-17 21:02 ` Valerio Setti
2026-09-17 21:02 ` [PATCH v2 1/6] ASoC: dt-bindings: amlogic,gx-audin: add schema Valerio Setti
2026-09-17 21:02   ` Valerio Setti
2026-09-17 21:07   ` sashiko-bot [this message]
2026-09-17 21:07     ` sashiko-bot
2026-09-17 21:02 ` [PATCH v2 2/6] ASoC: meson: build gx-formatter as a separate module Valerio Setti
2026-09-17 21:02   ` Valerio Setti
2026-09-17 21:02 ` [PATCH v2 3/6] ASoC: meson: add AUDIN driver Valerio Setti
2026-09-17 21:02   ` Valerio Setti
2026-09-17 21:17   ` sashiko-bot
2026-09-17 21:17     ` sashiko-bot
2026-09-17 21:02 ` [PATCH v2 4/6] ASoC: meson: aiu: add I2S Capture DAI Valerio Setti
2026-09-17 21:02   ` Valerio Setti
2026-09-17 21:20   ` sashiko-bot
2026-09-17 21:20     ` sashiko-bot
2026-09-18  9:56     ` Valerio Setti
2026-09-18  9:56       ` Valerio Setti
2026-09-17 21:02 ` [PATCH v2 5/6] ASoC: meson: gx-card: add support for audin FIFO Valerio Setti
2026-09-17 21:02   ` Valerio Setti
2026-09-17 21:02 ` [PATCH v2 6/6] arm64: dts: amlogic: gx: add AUDIN node Valerio Setti
2026-09-17 21:02   ` Valerio Setti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260917210759.0AAFB1F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vsetti@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.