All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/dp: Disable DC5/6 before AUX programming
@ 2026-09-18  6:04 Suraj Kandpal
  2026-09-18  6:10 ` ✗ CI.checkpatch: warning for " Patchwork
                   ` (21 more replies)
  0 siblings, 22 replies; 33+ messages in thread
From: Suraj Kandpal @ 2026-09-18  6:04 UTC (permalink / raw)
  To: intel-xe, intel-gfx
  Cc: ankit.k.nautiyal, arun.r.murthy, uma.shankar, swati2.sharma,
	Suraj Kandpal, Ramanaidu Naladala

From Xe2Lpd we removed the step to disable DC5/6 because as per Bspec
for SNPS PHY Aux will be always up. But from Xe3p LT PHY was introduced
which powers down the PHY. Which means we need to make sure Step 4
of AUX Programming sequence is honored.
Disable Dc5/6 when programming AUX.

Bspec: 68851, 68967
Co-developed-by: Ramanaidu Naladala <ramanaidu.naladala@intel.com>
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp_aux.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
index 3cb07b0a901c..350dac72c996 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
@@ -260,6 +260,7 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
 	u32 aux_clock_divider;
 	enum intel_display_power_domain aux_domain;
 	struct ref_tracker *aux_wakeref;
+	struct ref_tracker *dc_off_wakeref = NULL;
 	struct ref_tracker *pps_wakeref = NULL;
 	int i, ret, recv_bytes;
 	int try, clock = 0;
@@ -286,6 +287,9 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
 
 	aux_wakeref = intel_display_power_get(display, aux_domain);
 
+	(HAS_LT_PHY(display))
+		dc_off_wakeref = intel_display_power_get(display, POWER_DOMAIN_DC_OFF);
+
 	/*
 	 * The PPS state needs to be locked for:
 	 * - eDP on all platforms, since AUX transfers on eDP need VDD power
@@ -459,6 +463,9 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
 	if (pps_wakeref)
 		intel_pps_unlock(intel_dp, pps_wakeref);
 
+	if (dc_off_wakeref)
+		intel_display_power_put(display, POWER_DOMAIN_DC_OFF, dc_off_wakeref);
+
 	intel_display_power_put_async(display, aux_domain, aux_wakeref);
 out_unlock:
 	intel_digital_port_unlock(encoder);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 33+ messages in thread
end of thread, other threads:[~2026-09-22  3:39 UTC | newest]

Thread overview: 33+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-18  6:04 [PATCH] drm/i915/dp: Disable DC5/6 before AUX programming Suraj Kandpal
2026-09-18  6:10 ` ✗ CI.checkpatch: warning for " Patchwork
2026-09-18  6:10 ` [PATCH] " sashiko-bot
2026-09-18  6:12 ` ✓ CI.KUnit: success for " Patchwork
2026-09-18  6:22 ` [PATCH] " Murthy, Arun R
2026-09-18  6:35   ` Murthy, Arun R
2026-09-18  6:38 ` [PATCH v2] " Suraj Kandpal
2026-09-18  6:46   ` sashiko-bot
2026-09-18  7:59   ` Murthy, Arun R
2026-09-18 10:08   ` Jani Nikula
2026-09-18 16:40     ` Kandpal, Suraj
2026-09-18 15:09   ` Imre Deak
2026-09-18 16:40     ` Kandpal, Suraj
2026-09-18  6:44 ` ✗ CI.checkpatch: warning for drm/i915/dp: Disable DC5/6 before AUX programming (rev2) Patchwork
2026-09-18  6:46 ` ✓ CI.KUnit: success " Patchwork
2026-09-18  7:34 ` ✓ i915.CI.BAT: " Patchwork
2026-09-18  8:01 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-18 14:16 ` ✗ i915.CI.Full: failure " Patchwork
2026-09-18 16:17 ` ✓ Xe.CI.FULL: success " Patchwork
2026-09-21  2:20 ` [PATCH] drm/i915/xe3plpd: Map AUX power domains to DC_off Suraj Kandpal
2026-09-21  7:25   ` Kandpal, Suraj
2026-09-21  8:14     ` Jani Nikula
2026-09-22  3:39   ` Murthy, Arun R
2026-09-21  2:26 ` ✗ CI.checkpatch: warning for drm/i915/dp: Disable DC5/6 before AUX programming (rev3) Patchwork
2026-09-21  2:28 ` ✓ CI.KUnit: success " Patchwork
2026-09-21  3:06 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-09-21  3:18 ` ✓ i915.CI.BAT: success " Patchwork
2026-09-21  4:39 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-09-21  5:15 ` ✗ i915.CI.Full: " Patchwork
2026-09-21  5:49 ` ✗ CI.checkpatch: warning for drm/i915/dp: Disable DC5/6 before AUX programming (rev4) Patchwork
2026-09-21  5:51 ` ✓ CI.KUnit: success " Patchwork
2026-09-21  7:02 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-09-21  8:36 ` ✗ Xe.CI.FULL: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.