Re: [PATCH v2 12/12] s390/percpu: Rework to simplify percpu_entry() and percpu_exit()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] s390: missing semicolon in struct pt_regs definition
--

commit bee75225b6c8e3d1889d09e2fdf377d073ca5fc4
Author: Heiko Carstens <hca@linux.ibm.com>

s390/percpu: Rework to simplify percpu_entry() and percpu_exit()

This commit simplifies the percpu code section functionality on s390 by
encoding three register numbers into the percpu_register field. It allows
removing a complex instruction checking method.

> diff --git a/arch/s390/include/asm/ptrace.h b/arch/s390/include/asm/ptrace.h
> --- a/arch/s390/include/asm/ptrace.h
> +++ b/arch/s390/include/asm/ptrace.h
> @@ -132,7 +132,7 @@ struct pt_regs {
>  	};
>  	unsigned long flags;
>  	unsigned long last_break;
> -	unsigned int cpu;
> +	unsigned int cpu

[Severity: Low]
Does this struct pt_regs definition lack a semicolon after the cpu field?

This looks like a regression that invalidates the C syntax for the struct
definition, meaning any source file including <asm/ptrace.h> will fail to
compile.

>  	unsigned char percpu_register;
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918084842.2333237-1-hca@linux.ibm.com?part=12