From: sashiko-bot@kernel.org
To: npiggin@gmail.com, vishal.l.verma@intel.com, kernel@xen0n.name,
rafael@kernel.org, james.morse@arm.com, tangyouling@kylinos.cn,
sourabhjain@linux.ibm.com, leitao@debian.org, coxu@redhat.com,
palmer@rivosinc.com, linux-arm-kernel@lists.infradead.org,
blum@kernel.org, baoquan.he@linux.dev, x86@kernel.org,
jbouron@amazon.com, lizhengyu3@huawei.com,
hbathini@linux.ibm.com, seanjc@google.com, dakr@kernel.org,
sshegde@linux.ibm.com, pasha.tatashin@soleen.com,
gshan@redhat.com, ritesh.list@gmail.com, piliu@redhat.com,
chao.gao@intel.com, driver-core@lists.linux.dev, kees@kernel.org,
kas@kernel.org, bp@alien8.de, mingo@redhat.com, bgwin@google.com,
linux-kernel@vger.kernel.org, chenhuacai@kernel.org,
linux-fsdevel@vger.kernel.org, maqianga@uniontech.com,
zhangtianyang@loongson.cn, catalin.marinas@arm.com,
maddy@linux.ibm.com, akpm@linux-foundation.org,
yeoreum.yun@arm.com, loongarch@lists.linux.dev,
ruirui.yang@linux.dev, graf@amazon.com,
takahiro.akashi@linaro.org, mpe@ellerman.id.au, g@kvack.org,
uodongtai@kylinos.cn, linux-mm@kvack.org,
gregkh@linuxfoundation.org, pratyush@kernel.org,
liukexin@kylinos.cn, robh@kernel.org,
dave.hansen@linux.intel.com,
"Jinjie Ruan" <ruanjinjie@huawei.com>,
rppt@kernel.org, ruanjinjie@huawei.com, mclapinski@google.com,
thuth@redhat.com, adityag@linux.ibm.com, chleroy@kernel.org,
linuxppc-dev@lists.ozlabs.org, mark.rutland@arm.com,
will@kernel.org, hpa@zytor.com, me@linux.beauty, ardb@kernel.org,
eric.devolder@oracle.com, tglx@kernel.org
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH v5 16/17] arm64: kexec_file: Simplify load_other_segments()
Date: Fri, 18 Sep 2026 10:27:18 +0000 [thread overview]
Message-ID: <20260918102718.789961F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260918100442.3841135-17-ruanjinjie@huawei.com>
> Use `kbuf` fields directly in crash_prepare_headers() to eliminate
> the local variables "headers" and "headers_sz"..
>
> Advance the assignment to image->elf_headers before
> calling kexec_add_buffer(). If kexec_add_buffer() fails, the explicit
> vfree() in the error path can be removed, as the global infrastructure
> in arch_kimage_file_post_load_cleanup() will handle the cleanup.
>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Baoquan He <bhe@redhat.com>
> Cc: Breno Leitao <leitao@debian.org>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260918100442.3841135-1-ruanjinjie@huawei.com?part=16
WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: npiggin@gmail.com, vishal.l.verma@intel.com, kernel@xen0n.name,
rafael@kernel.org, james.morse@arm.com, tangyouling@kylinos.cn,
sourabhjain@linux.ibm.com, leitao@debian.org, coxu@redhat.com,
palmer@rivosinc.com, linux-arm-kernel@lists.infradead.org,
blum@kernel.org, baoquan.he@linux.dev, x86@kernel.org,
jbouron@amazon.com, lizhengyu3@huawei.com,
hbathini@linux.ibm.com, seanjc@google.com, dakr@kernel.org,
sshegde@linux.ibm.com, pasha.tatashin@soleen.com,
gshan@redhat.com, ritesh.list@gmail.com, piliu@redhat.com,
chao.gao@intel.com, driver-core@lists.linux.dev, kees@kernel.org,
kas@kernel.org, bp@alien8.de, mingo@redhat.com, bgwin@google.com,
linux-kernel@vger.kernel.org, chenhuacai@kernel.org,
linux-fsdevel@vger.kernel.org, maqianga@uniontech.com,
zhangtianyang@loongson.cn, catalin.marinas@arm.com,
maddy@linux.ibm.com, akpm@linux-foundation.org,
yeoreum.yun@arm.com, loongarch@lists.linux.dev,
ruirui.yang@linux.dev, graf@amazon.com,
takahiro.akashi@linaro.org, mpe@ellerman.id.au,
g@lists.ozlabs.org, uodongtai@kylinos.cn, linux-mm@kvack.org,
gregkh@linuxfoundation.org, pratyush@kernel.org,
liukexin@kylinos.cn, robh@kernel.org,
dave.hansen@linux.intel.com,
"Jinjie Ruan" <ruanjinjie@huawei.com>,
rppt@kernel.org, ruanjinjie@huawei.com, mclapinski@google.com,
thuth@redhat.com, adityag@linux.ibm.com, chleroy@kernel.org,
linuxppc-dev@lists.ozlabs.org, mark.rutland@arm.com,
will@kernel.org, hpa@zytor.com, me@linux.beauty, ardb@kernel.org,
eric.devolder@oracle.com, tglx@kernel.org
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH v5 16/17] arm64: kexec_file: Simplify load_other_segments()
Date: Fri, 18 Sep 2026 10:27:18 +0000 [thread overview]
Message-ID: <20260918102718.789961F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260918100442.3841135-17-ruanjinjie@huawei.com>
> Use `kbuf` fields directly in crash_prepare_headers() to eliminate
> the local variables "headers" and "headers_sz"..
>
> Advance the assignment to image->elf_headers before
> calling kexec_add_buffer(). If kexec_add_buffer() fails, the explicit
> vfree() in the error path can be removed, as the global infrastructure
> in arch_kimage_file_post_load_cleanup() will handle the cleanup.
>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Baoquan He <bhe@redhat.com>
> Cc: Breno Leitao <leitao@debian.org>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260918100442.3841135-1-ruanjinjie@huawei.com?part=16
WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: npiggin@gmail.com, vishal.l.verma@intel.com, kernel@xen0n.name,
rafael@kernel.org, james.morse@arm.com, tangyouling@kylinos.cn,
sourabhjain@linux.ibm.com, leitao@debian.org, coxu@redhat.com,
palmer@rivosinc.com, linux-arm-kernel@lists.infradead.org,
blum@kernel.org, baoquan.he@linux.dev, x86@kernel.org,
jbouron@amazon.com, lizhengyu3@huawei.com,
hbathini@linux.ibm.com, seanjc@google.com, dakr@kernel.org,
sshegde@linux.ibm.com, pasha.tatashin@soleen.com,
gshan@redhat.com, ritesh.list@gmail.com, piliu@redhat.com,
chao.gao@intel.com, driver-core@lists.linux.dev, kees@kernel.org,
kas@kernel.org, bp@alien8.de, mingo@redhat.com, bgwin@google.com,
linux-kernel@vger.kernel.org, chenhuacai@kernel.org,
linux-fsdevel@vger.kernel.org, maqianga@uniontech.com,
zhangtianyang@loongson.cn, catalin.marinas@arm.com,
maddy@linux.ibm.com, akpm@linux-foundation.org,
yeoreum.yun@arm.com, loongarch@lists.linux.dev,
ruirui.yang@linux.dev, graf@amazon.com,
takahiro.akashi@linaro.org, mpe@ellerman.id.au,
g uodongtai@kylinos.cn, linux-mm@kvack.org,
gregkh@linuxfoundation.org, pratyush@kernel.org,
liukexin@kylinos.cn, robh@kernel.org,
dave.hansen@linux.intel.com,
"Jinjie Ruan" <ruanjinjie@huawei.com>,
rppt@kernel.org, ruanjinjie@huawei.com, mclapinski@google.com,
thuth@redhat.com, adityag@linux.ibm.com, chleroy@kernel.org,
linuxppc-dev@lists.ozlabs.org, mark.rutland@arm.com,
will@kernel.org, hpa@zytor.com, me@linux.beauty, ardb@kernel.org,
eric.devolder@oracle.com, tglx@kernel.org
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH v5 16/17] arm64: kexec_file: Simplify load_other_segments()
Date: Fri, 18 Sep 2026 10:27:18 +0000 [thread overview]
Message-ID: <20260918102718.789961F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260918100442.3841135-17-ruanjinjie@huawei.com>
> Use `kbuf` fields directly in crash_prepare_headers() to eliminate
> the local variables "headers" and "headers_sz"..
>
> Advance the assignment to image->elf_headers before
> calling kexec_add_buffer(). If kexec_add_buffer() fails, the explicit
> vfree() in the error path can be removed, as the global infrastructure
> in arch_kimage_file_post_load_cleanup() will handle the cleanup.
>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Baoquan He <bhe@redhat.com>
> Cc: Breno Leitao <leitao@debian.org>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260918100442.3841135-1-ruanjinjie@huawei.com?part=16
next prev parent reply other threads:[~2026-09-18 10:27 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 10:04 [PATCH v5 00/17] crash: Rework and add arm64 crash hotplug support Jinjie Ruan
2026-09-18 10:04 ` [PATCH v5 01/17] kexec: Fix CMA segment address translation with non-zero text_offset Jinjie Ruan
2026-09-18 10:22 ` sashiko-bot
2026-09-18 10:22 ` sashiko-bot
2026-09-18 10:22 ` sashiko-bot
2026-09-18 10:04 ` [PATCH v5 02/17] kexec: Record allocated CMA pages to fix release size mismatch Jinjie Ruan
2026-09-18 10:16 ` sashiko-bot
2026-09-18 10:16 ` sashiko-bot
2026-09-18 10:16 ` sashiko-bot
2026-09-18 10:04 ` [PATCH v5 03/17] kexec: Extract kexec_free_segment_cma() from kimage_free_cma() Jinjie Ruan
2026-09-18 10:18 ` sashiko-bot
2026-09-18 10:18 ` sashiko-bot
2026-09-18 10:18 ` sashiko-bot
2026-09-18 10:04 ` [PATCH v5 04/17] arm64: kexec_file: Fix CMA page leaks in segment placement retry loops Jinjie Ruan
2026-09-18 10:15 ` sashiko-bot
2026-09-18 10:04 ` [PATCH v5 05/17] arm64: kexec_file: Fix elf_headers memory leak in retry loop Jinjie Ruan
2026-09-18 10:16 ` sashiko-bot
2026-09-18 10:16 ` sashiko-bot
2026-09-18 10:16 ` sashiko-bot
2026-09-18 10:04 ` [PATCH v5 06/17] LoongArch: kexec_file: Fix CMA page leaks in segment placement retry loops Jinjie Ruan
2026-09-18 10:16 ` sashiko-bot
2026-09-18 10:16 ` sashiko-bot
2026-09-18 10:04 ` [PATCH v5 07/17] LoongArch: kexec_file: Fix elf_headers memory leak in retry loop Jinjie Ruan
2026-09-18 10:21 ` sashiko-bot
2026-09-18 10:21 ` sashiko-bot
2026-09-18 10:21 ` sashiko-bot
2026-09-18 10:04 ` [PATCH v5 08/17] LoongArch: kexec_file: Fix a modified_cmdline leak Jinjie Ruan
2026-09-18 10:18 ` sashiko-bot
2026-09-18 10:04 ` [PATCH v5 09/17] x86/crash: Fix massive out-of-bounds write on 32-bit Highmem Jinjie Ruan
2026-09-18 10:16 ` sashiko-bot
2026-09-18 10:04 ` [PATCH v5 10/17] crash: Extract crash_get_memory_ranges() helper Jinjie Ruan
2026-09-18 10:11 ` sashiko-bot
2026-09-18 10:11 ` sashiko-bot
2026-09-18 10:11 ` sashiko-bot
2026-09-18 10:04 ` [PATCH v5 11/17] crash: Normalize the kexec_load elfcorehdr at load time Jinjie Ruan
2026-09-18 10:27 ` sashiko-bot
2026-09-18 10:27 ` sashiko-bot
2026-09-18 10:27 ` sashiko-bot
2026-09-20 3:52 ` Jinjie Ruan
2026-09-18 10:04 ` [PATCH v5 12/17] crash: Fix TOCTOU race in crash memory range collection Jinjie Ruan
2026-09-18 10:34 ` sashiko-bot
2026-09-18 10:34 ` sashiko-bot
2026-09-18 10:04 ` [PATCH v5 13/17] crash: Assert device_hotplug_lock in crash_get_memory_ranges_nolock() Jinjie Ruan
2026-09-18 10:26 ` sashiko-bot
2026-09-18 10:04 ` [PATCH v5 14/17] elf: Introduce elf64_phdr_size() helper Jinjie Ruan
2026-09-18 10:25 ` sashiko-bot
2026-09-18 10:25 ` sashiko-bot
2026-09-18 10:04 ` [PATCH v5 15/17] crash: Introduce crash_extra_elfcorehdr_size() helper Jinjie Ruan
2026-09-18 10:31 ` sashiko-bot
2026-09-18 10:04 ` [PATCH v5 16/17] arm64: kexec_file: Simplify load_other_segments() Jinjie Ruan
2026-09-18 10:27 ` sashiko-bot [this message]
2026-09-18 10:27 ` sashiko-bot
2026-09-18 10:27 ` sashiko-bot
2026-09-18 10:04 ` [PATCH v5 17/17] arm64: crash: Add crash hotplug support Jinjie Ruan
2026-09-18 10:36 ` sashiko-bot
2026-09-20 3:53 ` Jinjie Ruan
2026-09-18 10:41 ` [PATCH v5 00/17] crash: Rework and add arm64 " Breno Leitao
2026-09-20 3:13 ` Jinjie Ruan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918102718.789961F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=adityag@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=baoquan.he@linux.dev \
--cc=bgwin@google.com \
--cc=blum@kernel.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chao.gao@intel.com \
--cc=chenhuacai@kernel.org \
--cc=chleroy@kernel.org \
--cc=coxu@redhat.com \
--cc=dakr@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=driver-core@lists.linux.dev \
--cc=eric.devolder@oracle.com \
--cc=g@kvack.org \
--cc=graf@amazon.com \
--cc=gregkh@linuxfoundation.org \
--cc=gshan@redhat.com \
--cc=hbathini@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=jbouron@amazon.com \
--cc=kas@kernel.org \
--cc=kees@kernel.org \
--cc=kernel@xen0n.name \
--cc=kexec@lists.infradead.org \
--cc=leitao@debian.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=liukexin@kylinos.cn \
--cc=lizhengyu3@huawei.com \
--cc=loongarch@lists.linux.dev \
--cc=maddy@linux.ibm.com \
--cc=maqianga@uniontech.com \
--cc=mark.rutland@arm.com \
--cc=mclapinski@google.com \
--cc=me@linux.beauty \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=palmer@rivosinc.com \
--cc=pasha.tatashin@soleen.com \
--cc=piliu@redhat.com \
--cc=pratyush@kernel.org \
--cc=rafael@kernel.org \
--cc=ritesh.list@gmail.com \
--cc=robh@kernel.org \
--cc=rppt@kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=ruirui.yang@linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
--cc=seanjc@google.com \
--cc=sourabhjain@linux.ibm.com \
--cc=sshegde@linux.ibm.com \
--cc=takahiro.akashi@linaro.org \
--cc=tangyouling@kylinos.cn \
--cc=tglx@kernel.org \
--cc=thuth@redhat.com \
--cc=uodongtai@kylinos.cn \
--cc=vishal.l.verma@intel.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=yeoreum.yun@arm.com \
--cc=zhangtianyang@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.