[linux-next:master 6680/8072] drivers/gpu/drm/i915/display/intel_link_bw.c:69 intel_link_bw_init_limits() error: we previously assumed 'crtc_state' could be null (see line 67)

[linux-next:master 6680/8072] drivers/gpu/drm/i915/display/intel_link_bw.c:69 intel_link_bw_init_limits() error: we previously assumed 'crtc_state' could be null (see line 67)

[kernel test robot]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Imre Deak <imre.deak@intel.com>
CC: Luca Coelho <luciano.coelho@intel.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   e657a464aba873f5eaf3ca821b6e4016674492d6
commit: ee00f8fbb2b202002ab90834e02e9ba372773a36 [6680/8072] drm/i915/dp_mst: Fix configuring TUs for a disconnected stream
:::::: branch date: 11 hours ago
:::::: commit date: 2 days ago
config: i386-randconfig-2200-20260918 (https://download.01.org/0day-ci/archive/20260918/202609181136.jVZMWtb9-lkp@intel.com/config)
compiler: clang version 22.1.8 (https://github.com/llvm/llvm-project ca7933e47d3a3451d81e72ac174dcb5aa28b59d1)
smatch: v0.5.0-9187-g5189e3fb

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202609181136.jVZMWtb9-lkp@intel.com/

smatch warnings:
drivers/gpu/drm/i915/display/intel_link_bw.c:69 intel_link_bw_init_limits() error: we previously assumed 'crtc_state' could be null (see line 67)

vim +/crtc_state +69 drivers/gpu/drm/i915/display/intel_link_bw.c

f7f46a80fa68c1 Imre Deak   2025-05-09  45  
8ca0b875c08258 Imre Deak   2023-09-21  46  /**
8ca0b875c08258 Imre Deak   2023-09-21  47   * intel_link_bw_init_limits - initialize BW limits
1dd9d86ab60b98 Imre Deak   2024-02-20  48   * @state: Atomic state
8ca0b875c08258 Imre Deak   2023-09-21  49   * @limits: link BW limits
8ca0b875c08258 Imre Deak   2023-09-21  50   *
8ca0b875c08258 Imre Deak   2023-09-21  51   * Initialize @limits.
8ca0b875c08258 Imre Deak   2023-09-21  52   */
1dd9d86ab60b98 Imre Deak   2024-02-20  53  void intel_link_bw_init_limits(struct intel_atomic_state *state,
1dd9d86ab60b98 Imre Deak   2024-02-20  54  			       struct intel_link_bw_limits *limits)
8ca0b875c08258 Imre Deak   2023-09-21  55  {
9aec90f9e545fb Jani Nikula 2024-08-13  56  	struct intel_display *display = to_intel_display(state);
8ca0b875c08258 Imre Deak   2023-09-21  57  	enum pipe pipe;
8ca0b875c08258 Imre Deak   2023-09-21  58  
470b84af457e34 Imre Deak   2025-10-15  59  	limits->link_dsc_pipes = 0;
8ca0b875c08258 Imre Deak   2023-09-21  60  	limits->bpp_limit_reached_pipes = 0;
9aec90f9e545fb Jani Nikula 2024-08-13  61  	for_each_pipe(display, pipe) {
f7f46a80fa68c1 Imre Deak   2025-05-09  62  		struct intel_crtc *crtc = intel_crtc_for_pipe(display, pipe);
1dd9d86ab60b98 Imre Deak   2024-02-20  63  		const struct intel_crtc_state *crtc_state =
f7f46a80fa68c1 Imre Deak   2025-05-09  64  			intel_atomic_get_new_crtc_state(state, crtc);
f7f46a80fa68c1 Imre Deak   2025-05-09  65  		int forced_bpp_x16 = get_forced_link_bpp_x16(state, crtc);
1dd9d86ab60b98 Imre Deak   2024-02-20  66  
ee00f8fbb2b202 Imre Deak   2026-09-07 @67  		if ((state->base.duplicated && crtc_state) ||
ee00f8fbb2b202 Imre Deak   2026-09-07  68  		    intel_dp_mst_stream_disconnected(state, crtc)) {
1dd9d86ab60b98 Imre Deak   2024-02-20 @69  			limits->max_bpp_x16[pipe] = crtc_state->max_link_bpp_x16;
470b84af457e34 Imre Deak   2025-10-15  70  			if (intel_dsc_enabled_on_link(crtc_state))
470b84af457e34 Imre Deak   2025-10-15  71  				limits->link_dsc_pipes |= BIT(pipe);
1dd9d86ab60b98 Imre Deak   2024-02-20  72  		} else {
8ca0b875c08258 Imre Deak   2023-09-21  73  			limits->max_bpp_x16[pipe] = INT_MAX;
8ca0b875c08258 Imre Deak   2023-09-21  74  		}
f7f46a80fa68c1 Imre Deak   2025-05-09  75  
f7f46a80fa68c1 Imre Deak   2025-05-09  76  		if (forced_bpp_x16)
f7f46a80fa68c1 Imre Deak   2025-05-09  77  			limits->max_bpp_x16[pipe] = min(limits->max_bpp_x16[pipe], forced_bpp_x16);
1dd9d86ab60b98 Imre Deak   2024-02-20  78  	}
1dd9d86ab60b98 Imre Deak   2024-02-20  79  }
8ca0b875c08258 Imre Deak   2023-09-21  80  

:::::: The code at line 69 was first introduced by commit
:::::: 1dd9d86ab60b9810cc99640fa7ebe42e1b9c8b4f drm/i915: Fix display bpp limit computation during system resume

:::::: TO: Imre Deak <imre.deak@intel.com>
:::::: CC: Imre Deak <imre.deak@intel.com>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki