Re: [PATCH v8 01/29] KVM: Introduce file_to_kvm_<arch>() infrastructure

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] kvm: comment incorrectly documents file_to_kvm_<arch> as static inline
--

commit 75f01ce5173332e48e8ba4fd2b83b6d3584388c4
Author: Steffen Eiden <seiden@linux.ibm.com>

KVM: Introduce file_to_kvm_<arch>() infrastructure

Add a macro mechanism that generates an opt-in and arch-namespaced
file_to_kvm_<arch>() to convert a file reference to a kvm object if the
file handle represents a kvm handle.

[ ... ]

> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> index 03bfc92864b6e..a1bf6d4a8f460 100644
> --- a/include/linux/kvm_host.h
> +++ b/include/linux/kvm_host.h
> @@ -1082,6 +1082,18 @@ void kvm_get_kvm(struct kvm *kvm);
>  bool kvm_get_kvm_safe(struct kvm *kvm);
>  void kvm_put_kvm(struct kvm *kvm);
>  bool file_is_kvm(struct file *file);
> +
> +/*
> + * Architectures define kvm_file_to_kvm_arch to <arch>
> + * to get a typed, arch-namespaced helper:
> + *
> + *   static inline struct kvm *file_to_kvm_<arch>(struct file *file)
         ^^^^^^^^^^^^^

[Severity: Low]
Is this comment accurate in describing the generated function as static
inline?

The code below actually declares an out-of-line exported function rather
than a static inline helper. Could this be misleading to someone reading
the header file who might assume the function is inlined and doesn't incur
function call overhead?

> + */
> +#ifdef kvm_file_to_kvm_arch
> +#define kvm_file_to_kvm_fn CONCATENATE(file_to_kvm_, kvm_file_to_kvm_arch)
> +struct kvm *kvm_file_to_kvm_fn(struct file *file);
> +#endif /* kvm_file_to_kvm_arch */
> +
>  void kvm_put_kvm_no_destroy(struct kvm *kvm);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918133107.1042730-1-seiden@linux.ibm.com?part=1