Re: [PATCH 20/31] KVM: Introduce kvm_check_gen()/kvm_memslots_check_gen()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] kvm: missing closing parenthesis for unlikely() macro in loongarch
--

commit 173c930f2b4596e5daa23aa65be9736878ddf068
Author: Paolo Bonzini <pbonzini@redhat.com>

KVM: Introduce kvm_check_gen()/kvm_memslots_check_gen()

This commit introduces helper functions to retrieve and check the generation
of kvm_memslots. It replaces direct accesses to the generation field with
kvm_check_gen() or kvm_memslots_check_gen() across multiple architectures.

> diff --git a/arch/loongarch/kvm/vcpu.c b/arch/loongarch/kvm/vcpu.c
> index d540004d74ff6..cf4f4d75374ad 100644
> --- a/arch/loongarch/kvm/vcpu.c
> +++ b/arch/loongarch/kvm/vcpu.c
[ ... ]
> @@ -164,9 +163,8 @@ static void kvm_update_stolen_time(struct kvm_vcpu *vcpu)
>  		return;
>  
>  	gpa &= KVM_STEAL_PHYS_MASK;
> -	slots = kvm_memslots(vcpu->kvm);
> -	if (unlikely(slots->generation != ghc->generation || gpa != ghc->gpa ||
> -		     kvm_is_error_hva(ghc->hva) || !ghc->memslot)) {
> +	if (unlikely(!kvm_check_gen(vcpu->kvm, ghc->generation) || gpa != ghc->gpa ||
> +		     kvm_is_error_hva(ghc->hva) || !ghc->memslot) {

[Severity: Low]
Does this missing closing parenthesis for the unlikely() macro cause a build
failure on LoongArch architectures? It looks like we have !ghc->memslot) {
instead of !ghc->memslot)) { here in kvm_update_stolen_time().

>  		if (kvm_gfn_to_hva_cache_init(vcpu->kvm, ghc, gpa, sizeof(*st))) {
>  			ghc->gpa = INVALID_GPA;
>  			return;
[ ... ]
> @@ -1811,9 +1808,8 @@ static void kvm_vcpu_set_pv_preempted(struct kvm_vcpu *vcpu)
>  
>  	gpa &= KVM_STEAL_PHYS_MASK;
>  	ghc = &vcpu->arch.st.cache;
> -	slots = kvm_memslots(vcpu->kvm);
> -	if (unlikely(slots->generation != ghc->generation || gpa != ghc->gpa ||
> -		     kvm_is_error_hva(ghc->hva) || !ghc->memslot)) {
> +	if (unlikely(!kvm_check_gen(vcpu->kvm, ghc->generation) || gpa != ghc->gpa ||
> +		     kvm_is_error_hva(ghc->hva) || !ghc->memslot) {

[Severity: Low]
Is this the same syntax issue as above? It seems we are also missing the
closing parenthesis for unlikely() in kvm_vcpu_set_pv_preempted().

>  		if (kvm_gfn_to_hva_cache_init(vcpu->kvm, ghc, gpa, sizeof(*st))) {
>  			ghc->gpa = INVALID_GPA;
>  			return;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918135030.171564-2-pbonzini@redhat.com?part=20