Re: [PATCH v2 06/10] PCI/portdrv: Group PCI Exp Cap services into a single mask

[sashiko-bot@kernel.org]

> PME, hotplug, and bandwidth notification are all services of the PCI
> Express Capability and share a single MSI/MSI-X interrupt vector. The
> set of these services is open-coded as a bitmask in more than one place.
> That is repetitive and easy to get out of sync as services are added.
> 
> Define a single PCIE_PORT_SERVICES_EXPCAP mask beside the service bits
> it groups, and use it in place of the open-coded expressions. Assign the
> shared vector by iterating the mask rather than naming each service
> again, so adding one is a single edit.
> 
> Iterating narrows which irqs[] entries get written. The open-coded
> version filled the slot of every service in the group as soon as one of
> them was in the mask. Those extra entries were never read, since
> pcie_init_service_irqs() presets the array to -1 and
> pcie_port_device_register() only reads the slot of a service it found.
> 
> No functional change intended.
> 
> Assisted-by: LLM
> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918145619.3016889-1-yazen.ghannam@amd.com?part=6