Re: [PATCH v2 04/10] PCI/AER: Hide the "aer" sysfs directory when AER is unavailable

[sashiko-bot@kernel.org]

> aer_attr_group is a named group, so sysfs creates an "aer" directory for
> every PCI device. aer_attrs_are_visible() hides the attributes when the
> device has no aer_info, but internal_create_group() only skips the
> directory when is_visible() returns SYSFS_GROUP_INVISIBLE for the first
> attribute. The result is an empty /sys/bus/pci/devices/*/aer/ on every
> device without AER.
> 
> Switch to DEFINE_SIMPLE_SYSFS_GROUP_VISIBLE(), which returns
> SYSFS_GROUP_INVISIBLE when the group predicate is false. Drop the
> per-attribute callback, since all four attributes share one condition.
> 
> aer_stats_attr_group is unnamed and creates no directory, so it is left
> alone.
> 
> Fixes: b4fe7398def6 ("PCI/AER: Add sysfs attributes for log ratelimits")
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Closes: https://lore.kernel.org/linux-pci/20260714191826.BA81E1F000E9@smtp.kernel.org/
> Assisted-by: LLM
> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918145619.3016889-1-yazen.ghannam@amd.com?part=4