Re: [PATCH v2 03/11] pmdomain: renesas: r8a78000: Add maps for VIO for SCP FW SDKv4.36

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] pmdomain: r8a78000: probe regression on older SCMI firmware versions
--

commit 15cae81644d1a9205daae4b85676910b2400fe02
Author: Paul Elder <paul.elder+renesas@ideasonboard.com>

pmdomain: renesas: r8a78000: Add maps for VIO for SCP FW SDKv4.36

Add maps for VIO for the VSP and FCP power domains and reset domains.

> diff --git a/drivers/pmdomain/renesas/r8a78000-mdlc.c b/drivers/pmdomain/renesas/r8a78000-mdlc.c
> index a0d83f27735e7..cabe6435ecd79 100644
> --- a/drivers/pmdomain/renesas/r8a78000-mdlc.c
> +++ b/drivers/pmdomain/renesas/r8a78000-mdlc.c
[ ... ]
> @@ -997,8 +1047,8 @@ static const struct mdlc_info r8a78000_mdlc_fw_4_31_0[] = {
>  		/* FIXME .mod_map = r8a78000_mdlc_vips_mod_fw_4_31_0, */
>  	}, {
>  		.base = 0xc5000000 /* mdlc_vio */,
> -		/* FIXME .power_map = r8a78000_mdlc_vio_power_fw_4_28_0, */
> -		/* FIXME .mod_map = r8a78000_mdlc_vio_mod_fw_4_31_0, */
> +		.power_map = r8a78000_mdlc_vio_power_fw_4_31_0,
> +		.mod_map = r8a78000_mdlc_vio_mod_fw_4_31_0,

[Severity: Medium]
The commit message indicates these are maps for SCP FW SDKv4.36, but they are
being unconditionally assigned to the r8a78000_mdlc_fw_4_31_0 struct.

If older firmware lacks the newly added VIO IDs, will this cause an immediate
probe abort?

In fill_power_map():

	genpd = of_genpd_get_from_provider(&scmi_spec);
	if (IS_ERR(genpd))
		return dev_err_cast_probe(dev, genpd,
				"Failed to get SCMI power domain %u\n",
				map[i].fw_id);

If an older firmware (e.g. SDK v4.31) reports fewer SCMI domains than the newly
added VIO IDs, of_genpd_get_from_provider() will return -ENOENT, aborting the
probe and rendering dependent devices unusable.

Should these maps only be applied when the correct firmware version is
detected?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260919-epaul-v7-3-rc1-x5h-vsp-fcp-v2-0-dbe9236bfd22@ideasonboard.com?part=3