Re: [PATCH v2 08/11] media: vsp1: Document X5H SoC ID

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

On Thu, Sep 24, 2026 at 06:16:10PM +0900, Paul Elder wrote:
> Quoting Laurent Pinchart (2026-09-20 02:58:51)
> > On Sat, Sep 19, 2026 at 02:07:05AM +0900, Paul Elder wrote:
> > > From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > > 
> > > The R-Car X5H uses 0x09 as the SoC ID in the version register. Document
> > > is with a macro, as done for other R-Car SoCs.
> > > 
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > > Signed-off-by: Paul Elder <paul.elder+renesas@ideasonboard.com>
> > > ---
> > > Changes in v2:
> > > - Fix the version register number: s/0x04/0x09/
> > 
> > Thanks for the fix.
> > 
> > Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > 
> > But I think we can squash this with patch 09/11.
> > 
> > > ---
> > >  drivers/media/platform/renesas/vsp1/vsp1_regs.h | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/media/platform/renesas/vsp1/vsp1_regs.h b/drivers/media/platform/renesas/vsp1/vsp1_regs.h
> > > index 4c0315656e9f81a9656b58fb6f0233f8a22ac0e1..8abf39bac6c2f333696ebf55de87586d2df3bed0 100644
> > > --- a/drivers/media/platform/renesas/vsp1/vsp1_regs.h
> > > +++ b/drivers/media/platform/renesas/vsp1/vsp1_regs.h
> > > @@ -816,6 +816,7 @@
> > >  #define VI6_IP_VERSION_SOC_E3                (0x04 << 0)
> > >  #define VI6_IP_VERSION_SOC_V3U               (0x05 << 0)
> > >  #define VI6_IP_VERSION_SOC_V4H               (0x06 << 0)
> > > +#define VI6_IP_VERSION_SOC_X5H               (0x09 << 0)
> 
> Do we need to add an X5H1 (0x09) and X5H2 (0x07)? Or whatever 0x07 is because
> that's what the bsp is referencing for X5H. I've personally observed 0x09 for X5H1.

I'd add 0x09 for now, and 0x07 later when we'll be able to test X5H2.

> > >  /* RZ/G2L SoCs have no version register, So use 0x80 for SoC Identification */
> > >  #define VI6_IP_VERSION_SOC_RZG2L     (0x80 << 0)
> > >  

-- 
Regards,

Laurent Pinchart