Re: [PATCH net-next v7 05/11] arm64: dts: rockchip: rk3568: add XPCS and fixed-clock nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] arm64: dts: missing required properties in disabled xpcs node
--

commit 645b03337d217aa5103d2a837ab8fed754652108
Author: Coia Prant <coiaprant@gmail.com>

arm64: dts: rockchip: rk3568: add XPCS and fixed-clock nodes

This commit adds the XPCS device node, its pcs-mii sub-nodes, and two
fixed-clock reference nodes to the RK3568 SoC device tree. The XPCS node is
disabled by default and intentionally omits the phys and phy-names
properties in the dtsi.

> The XPCS node requires a reference to the appropriate Naneng Combo PHY
> via the phys property.  dtbs_check only validates required properties
> for enabled nodes, so the SoC dtsi does not provide phys/phy-names:

[Severity: Low]
Is this assumption about dtbs_check accurate? dt-validate enforces
unconditional required property lists against all nodes matching the
compatible string, regardless of their status.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3568.dtsi b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> index 3bc653f027f1f..227d03e336043 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> @@ -110,6 +110,51 @@ sata0: sata@fc000000 {

[ ... ]

> +	xpcs: ethernet-pcs@fda00000 {
> +		compatible = "rockchip,rk3568-xpcs";
> +		#address-cells = <1>;

[Severity: Low]
Will this omission result in missing-property validation warnings during
make dtbs_check for any board including rk3568.dtsi? 

Because the rockchip,rk3568-xpcs schema unconditionally requires phys and
phy-names, dtbs_check will likely flag this disabled node for lacking them
when validating the compiled dtb.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917204624.2427486-1-coiaprant@gmail.com?part=5

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy