From: Warner Losh <imp@bsdimp.com>
To: qemu-devel@nongnu.org
Cc: Kyle Evans <kevans@freebsd.org>, Warner Losh <imp@bsdimp.com>
Subject: [PATCH 03/14] bsd-user: Flag shared memory as needing atomics
Date: Sat, 19 Sep 2026 23:20:39 -0600 [thread overview]
Message-ID: <20260919-misc-2025q4-v1-3-ebfa61049bd7@bsdimp.com> (raw)
In-Reply-To: <20260919-misc-2025q4-v1-0-ebfa61049bd7@bsdimp.com>
Catch up with linux-user 228168cbb7c:
Signal the translator to use host atomic instructions for
guest operations, insofar as it is possible. This is the
best we can do to allow the guest to interact atomically
with other processes.
as well as subsequent tweaks and adjustmentst for bsd-user's code
structure (we don't have one exit path linux-user does and could frankly
stand to resturcture a bit to match the evolved code in linux-user). On
non-private mmap(2) sharing and all successful shmat(2) calls we tell
tcg that we're in a parallel context, which changes how it does atomics.
Signed-off-by: Warner Losh <imp@bsdimp.com>
---
bsd-user/bsd-mem.h | 8 ++++++++
bsd-user/mmap.c | 9 +++++++++
2 files changed, 17 insertions(+)
diff --git a/bsd-user/bsd-mem.h b/bsd-user/bsd-mem.h
index 3086143d40..65270e2cdf 100644
--- a/bsd-user/bsd-mem.h
+++ b/bsd-user/bsd-mem.h
@@ -389,6 +389,14 @@ static inline abi_long do_bsd_shmat(int shmid, abi_ulong shmaddr, int shmflg)
}
}
+ /*
+ * We're mapping shared memory, so ensure we generate code for parallel
+ * execution and flush old translations. This will work up to the level
+ * supported by the host -- anything that requires EXCP_ATOMIC will not
+ * be atomic with respect to an external process.
+ */
+ begin_parallel_context(thread_cpu);
+
return raddr;
}
diff --git a/bsd-user/mmap.c b/bsd-user/mmap.c
index fe77eceb48..548b4824df 100644
--- a/bsd-user/mmap.c
+++ b/bsd-user/mmap.c
@@ -662,6 +662,15 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, int prot,
printf("\n");
#endif
mmap_unlock();
+ /*
+ * If we're mapping shared memory, ensure we generate code for parallel
+ * execution and flush old translations. This will work up to the level
+ * supported by the host -- anything that requires EXCP_ATOMIC will not
+ * be atomic with respect to an external process.
+ */
+ if ((flags & MAP_TYPE) != MAP_PRIVATE) {
+ begin_parallel_context(thread_cpu);
+ }
return start;
fail:
mmap_unlock();
--
2.55.0
next prev parent reply other threads:[~2026-09-20 5:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-20 5:20 [PATCH 00/14] bsd-user: Upstream a few fixes Warner Losh
2026-09-20 5:20 ` [PATCH 01/14] bsd-user: HOST_BIG_ENDIAN and TARGET_BIG_ENDIAN are always Warner Losh
2026-09-20 21:57 ` Richard Henderson
2026-09-20 5:20 ` [PATCH 02/14] bsd-user: Drop support for FreeBSD 12 Warner Losh
2026-09-21 18:35 ` Pierrick Bouvier
2026-09-20 5:20 ` Warner Losh [this message]
2026-09-20 21:59 ` [PATCH 03/14] bsd-user: Flag shared memory as needing atomics Richard Henderson
2026-09-20 5:20 ` [PATCH 04/14] bsd-user: Add gdb for system calls Warner Losh
2026-09-20 22:02 ` Richard Henderson
2026-09-21 10:06 ` Warner Losh
2026-09-20 5:20 ` [PATCH 05/14] bsd-user: Initialize per-arch child registers Warner Losh
2026-09-20 22:07 ` Richard Henderson
2026-09-20 5:20 ` [PATCH 06/14] bsd-user: Fix crazy bug with mmap Warner Losh
2026-09-20 22:09 ` Richard Henderson
2026-09-21 2:38 ` Warner Losh
2026-09-20 5:20 ` [PATCH 07/14] bsd-user: Move tb_flush stuff to begin_parallel_context Warner Losh
2026-09-20 22:11 ` Richard Henderson
2026-09-20 5:20 ` [PATCH 08/14] bsd-user: Fix MAP_TYPE definition Warner Losh
2026-09-20 22:12 ` Richard Henderson
2026-09-20 5:20 ` [PATCH 09/14] bsd-user: Implement exterrctl(2) Warner Losh
2026-09-21 18:34 ` Pierrick Bouvier
2026-09-20 5:20 ` [PATCH 10/14] bsd-user: Implement sigfastblock Warner Losh
2026-09-21 18:34 ` Pierrick Bouvier
2026-09-20 5:20 ` [PATCH 11/14] bsd-user: Eliminate unused regs arg in load_elf_binary Warner Losh
2026-09-20 22:14 ` Richard Henderson
2026-09-20 5:20 ` [PATCH 12/14] bsd-user: #ifdef sockopt that aren't in 14 Warner Losh
2026-09-21 18:32 ` Pierrick Bouvier
2026-09-20 5:20 ` [PATCH 13/14] bsd-user: Fix non-PIE binaries Warner Losh
2026-09-20 22:33 ` Richard Henderson
2026-09-21 1:06 ` Warner Losh
2026-09-20 5:20 ` [PATCH 14/14] bsd-user: Remove host-os.h Warner Losh
2026-09-20 22:34 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260919-misc-2025q4-v1-3-ebfa61049bd7@bsdimp.com \
--to=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.