From: Warner Losh <imp@bsdimp.com>
To: qemu-devel@nongnu.org
Cc: Kyle Evans <kevans@freebsd.org>, Warner Losh <imp@bsdimp.com>
Subject: [PATCH 07/14] bsd-user: Move tb_flush stuff to begin_parallel_context
Date: Sat, 19 Sep 2026 23:20:43 -0600 [thread overview]
Message-ID: <20260919-misc-2025q4-v1-7-ebfa61049bd7@bsdimp.com> (raw)
In-Reply-To: <20260919-misc-2025q4-v1-0-ebfa61049bd7@bsdimp.com>
Catch up with linux-user 430014bee7a6c26a70e9f3854428843d5918cdf5 and
impelment begin_parallel_context. We'd already moved to using
tb_flush__exclusive_or_serial, but need this in several places, like
linux-user has.
Signed-off-by: Warner Losh <imp@bsdimp.com>
---
bsd-user/freebsd/os-thread.c | 6 +-----
bsd-user/qemu.h | 18 ++++++++++++++++++
2 files changed, 19 insertions(+), 5 deletions(-)
diff --git a/bsd-user/freebsd/os-thread.c b/bsd-user/freebsd/os-thread.c
index eaab062d3d..4ffa76a798 100644
--- a/bsd-user/freebsd/os-thread.c
+++ b/bsd-user/freebsd/os-thread.c
@@ -16,7 +16,6 @@
#include "target_arch_thread.h"
#include "qemu/guest-random.h"
#include "tcg/startup.h"
-#include "exec/tb-flush.h"
#include "os-thread.h"
@@ -1622,10 +1621,7 @@ abi_long do_freebsd_thr_new(CPUArchState *env,
* generate code for parallel execution and flush old translations.
* Do this now so that the copy gets CF_PARALLEL too.
*/
- if (!(cpu->tcg_cflags & CF_PARALLEL)) {
- cpu->tcg_cflags |= CF_PARALLEL;
- tb_flush__exclusive_or_serial();
- }
+ begin_parallel_context(cpu);
new_env = cpu_copy(env);
diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h
index d2dd8c2ee8..851b0c2c5f 100644
--- a/bsd-user/qemu.h
+++ b/bsd-user/qemu.h
@@ -41,6 +41,7 @@ extern char **environ;
#include "target.h"
#include "exec/gdbstub.h"
#include "exec/page-protection.h"
+#include "exec/tb-flush.h"
#include "accel/tcg/vcpu-state.h"
#include "qemu-os.h"
@@ -529,4 +530,21 @@ static inline uint64_t target_arg64(uint32_t word0, uint32_t word1)
#include "user/safe-syscall.h"
+/* In user-internal.h in linux-user XXX consider similar cleanup */
+
+/**
+ * begin_parallel_context
+ * @cs: the CPU context
+ *
+ * Called when starting the second vcpu, or joining shared memory.
+ */
+static inline void begin_parallel_context(CPUState *cs)
+{
+ if (!tcg_cflags_has(cs, CF_PARALLEL)) {
+ tb_flush__exclusive_or_serial();
+ tcg_cflags_set(cs, CF_PARALLEL);
+ }
+}
+
+
#endif /* QEMU_H */
--
2.55.0
next prev parent reply other threads:[~2026-09-20 5:22 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-20 5:20 [PATCH 00/14] bsd-user: Upstream a few fixes Warner Losh
2026-09-20 5:20 ` [PATCH 01/14] bsd-user: HOST_BIG_ENDIAN and TARGET_BIG_ENDIAN are always Warner Losh
2026-09-20 21:57 ` Richard Henderson
2026-09-20 5:20 ` [PATCH 02/14] bsd-user: Drop support for FreeBSD 12 Warner Losh
2026-09-21 18:35 ` Pierrick Bouvier
2026-09-20 5:20 ` [PATCH 03/14] bsd-user: Flag shared memory as needing atomics Warner Losh
2026-09-20 21:59 ` Richard Henderson
2026-09-20 5:20 ` [PATCH 04/14] bsd-user: Add gdb for system calls Warner Losh
2026-09-20 22:02 ` Richard Henderson
2026-09-21 10:06 ` Warner Losh
2026-09-20 5:20 ` [PATCH 05/14] bsd-user: Initialize per-arch child registers Warner Losh
2026-09-20 22:07 ` Richard Henderson
2026-09-20 5:20 ` [PATCH 06/14] bsd-user: Fix crazy bug with mmap Warner Losh
2026-09-20 22:09 ` Richard Henderson
2026-09-21 2:38 ` Warner Losh
2026-09-20 5:20 ` Warner Losh [this message]
2026-09-20 22:11 ` [PATCH 07/14] bsd-user: Move tb_flush stuff to begin_parallel_context Richard Henderson
2026-09-20 5:20 ` [PATCH 08/14] bsd-user: Fix MAP_TYPE definition Warner Losh
2026-09-20 22:12 ` Richard Henderson
2026-09-20 5:20 ` [PATCH 09/14] bsd-user: Implement exterrctl(2) Warner Losh
2026-09-21 18:34 ` Pierrick Bouvier
2026-09-20 5:20 ` [PATCH 10/14] bsd-user: Implement sigfastblock Warner Losh
2026-09-21 18:34 ` Pierrick Bouvier
2026-09-20 5:20 ` [PATCH 11/14] bsd-user: Eliminate unused regs arg in load_elf_binary Warner Losh
2026-09-20 22:14 ` Richard Henderson
2026-09-20 5:20 ` [PATCH 12/14] bsd-user: #ifdef sockopt that aren't in 14 Warner Losh
2026-09-21 18:32 ` Pierrick Bouvier
2026-09-20 5:20 ` [PATCH 13/14] bsd-user: Fix non-PIE binaries Warner Losh
2026-09-20 22:33 ` Richard Henderson
2026-09-21 1:06 ` Warner Losh
2026-09-20 5:20 ` [PATCH 14/14] bsd-user: Remove host-os.h Warner Losh
2026-09-20 22:34 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260919-misc-2025q4-v1-7-ebfa61049bd7@bsdimp.com \
--to=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.