From: Yaozhong Li <yaozhonguwl@gmail.com>
To: heiko@sntech.de
Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] arm64: dts: rockchip: drop unused i2s0 from rk3399-firefly
Date: Mon, 21 Sep 2026 14:34:00 +0800 [thread overview]
Message-ID: <20260921063400.2020-1-yaozhonguwl@gmail.com> (raw)
In-Reply-To: <20260903082713.192-1-yaozhonguwl@gmail.com>
Please drop this series.
The commit message claims that nothing on this board uses i2s0. That is
true for the DAI, but I missed that its pin groups also list GPIO4_A0:
i2s0-8ch-bus ... <4 RK_PA0 1 &pcfg_pull_none>
i2s0-8ch-bus-bclk-off ... <4 RK_PA0 1 &pcfg_pull_none>
That pin carries SCLK_I2S_8CH_OUT, the MCLK the RT5640 runs on:
rt5640: rt5640@1c {
clocks = <&cru SCLK_I2S_8CH_OUT>;
clock-names = "mclk";
};
Dropping the whole &i2s0 override therefore leaves the codec clock pin
without its mux configuration and analog audio stops working. I have
reproduced that on the board. Sorry for not catching it before sending.
The correct change must split the MCLK pin into its own group, attach
that group to i2s1, and disable the otherwise unused i2s0 controller in
the same patch.
Patch 2/2 depends on this one - with i2s0 still enabled there is no
pl330 channel left for i2s2 - so it cannot stand on its own either. It
is resent unchanged as part of the v2 series rather than separately.
Could you please mark both patches as superseded in patchwork.
Sorry for the noise.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Yaozhong Li <yaozhonguwl@gmail.com>
To: heiko@sntech.de
Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] arm64: dts: rockchip: drop unused i2s0 from rk3399-firefly
Date: Mon, 21 Sep 2026 14:34:00 +0800 [thread overview]
Message-ID: <20260921063400.2020-1-yaozhonguwl@gmail.com> (raw)
In-Reply-To: <20260903082713.192-1-yaozhonguwl@gmail.com>
Please drop this series.
The commit message claims that nothing on this board uses i2s0. That is
true for the DAI, but I missed that its pin groups also list GPIO4_A0:
i2s0-8ch-bus ... <4 RK_PA0 1 &pcfg_pull_none>
i2s0-8ch-bus-bclk-off ... <4 RK_PA0 1 &pcfg_pull_none>
That pin carries SCLK_I2S_8CH_OUT, the MCLK the RT5640 runs on:
rt5640: rt5640@1c {
clocks = <&cru SCLK_I2S_8CH_OUT>;
clock-names = "mclk";
};
Dropping the whole &i2s0 override therefore leaves the codec clock pin
without its mux configuration and analog audio stops working. I have
reproduced that on the board. Sorry for not catching it before sending.
The correct change must split the MCLK pin into its own group, attach
that group to i2s1, and disable the otherwise unused i2s0 controller in
the same patch.
Patch 2/2 depends on this one - with i2s0 still enabled there is no
pl330 channel left for i2s2 - so it cannot stand on its own either. It
is resent unchanged as part of the v2 series rather than separately.
Could you please mark both patches as superseded in patchwork.
Sorry for the noise.
next prev parent reply other threads:[~2026-09-21 6:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 8:27 [PATCH 1/2] arm64: dts: rockchip: drop unused i2s0 from rk3399-firefly Yaozhong Li
2026-09-03 8:27 ` Yaozhong Li
2026-09-03 8:27 ` [PATCH 2/2] arm64: dts: rockchip: enable HDMI audio on rk3399-firefly Yaozhong Li
2026-09-03 8:27 ` Yaozhong Li
2026-09-21 6:34 ` Yaozhong Li [this message]
2026-09-21 6:34 ` [PATCH 1/2] arm64: dts: rockchip: drop unused i2s0 from rk3399-firefly Yaozhong Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921063400.2020-1-yaozhonguwl@gmail.com \
--to=yaozhonguwl@gmail.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.