Re: [PATCH 2/6] dt-bindings: PCI: qcom-ep: Add QCS8300 compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: missing QCS8300 compatible string in conditional block
--

commit e543ce399a6b1c737f9d5a524c907cd7d96b4ffb
Author: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>

dt-bindings: PCI: qcom-ep: Add QCS8300 compatible

The QCS8300 PCIe Endpoint controller is compatible with the SA8775P PCIe
Endpoint controller. This commit documents the QCS8300 compatible string
and its fallback to the SA8775P compatible.

> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> index bed9a40b186bc..7f9a0bc958d1b 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> @@ -13,10 +13,15 @@ properties:
>    compatible:
>      oneOf:
>        - enum:
> +          - qcom,qcs8300-pcie-ep
>            - qcom,sa8775p-pcie-ep

[Severity: Medium]
Will a device tree node using only "qcom,qcs8300-pcie-ep" silently bypass
the clock and clock-names constraints?

Since this compatible string is now allowed as standalone in the
properties:compatible:oneOf:enum block, it appears to be missing from the
allOf:if:properties:compatible:contains:enum conditional block enforcing
SA8775P constraints later in the file:

  - if:
      properties:
        compatible:
          contains:
            enum:
              - qcom,sa8775p-pcie-ep
    then:
      properties:
        clocks:
...

Should qcom,qcs8300-pcie-ep be added to this enum as well?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921-monaco_ep-v1-0-63c5282fb0db@oss.qualcomm.com?part=2