* [PATCH] drm/v3d: Restrict v3d_perfmon_stop_locked() to v3d_perfmon.c
@ 2026-09-21 19:00 Erick Karanja
2026-09-21 20:00 ` Maíra Canal
0 siblings, 1 reply; 2+ messages in thread
From: Erick Karanja @ 2026-09-21 19:00 UTC (permalink / raw)
To: mwen, mcanal
Cc: maarten.lankhorst, mripard, tzimmermann, airlied, simona,
dri-devel, linux-kernel, Erick Karanja
v3d_perfmon_stop_locked() is only used within v3d_perfmon.c.
Make the function file-local and remove its declaration from v3d_drv.h.
Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
---
drivers/gpu/drm/v3d/v3d_drv.h | 2 --
drivers/gpu/drm/v3d/v3d_perfmon.c | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/v3d/v3d_drv.h b/drivers/gpu/drm/v3d/v3d_drv.h
index 29fa14be130b..611618030519 100644
--- a/drivers/gpu/drm/v3d/v3d_drv.h
+++ b/drivers/gpu/drm/v3d/v3d_drv.h
@@ -703,8 +703,6 @@ void v3d_perfmon_put(struct v3d_perfmon *perfmon);
void v3d_perfmon_start(struct v3d_dev *v3d, struct v3d_perfmon *perfmon);
void v3d_perfmon_stop(struct v3d_dev *v3d, struct v3d_perfmon *perfmon,
bool capture);
-void v3d_perfmon_stop_locked(struct v3d_dev *v3d, struct v3d_perfmon *perfmon,
- bool capture);
void v3d_perfmon_suspend(struct v3d_dev *v3d);
void v3d_perfmon_resume(struct v3d_dev *v3d);
struct v3d_perfmon *v3d_perfmon_find(struct v3d_file_priv *v3d_priv, int id);
diff --git a/drivers/gpu/drm/v3d/v3d_perfmon.c b/drivers/gpu/drm/v3d/v3d_perfmon.c
index 07dab7fb3060..34f17e7b8f6b 100644
--- a/drivers/gpu/drm/v3d/v3d_perfmon.c
+++ b/drivers/gpu/drm/v3d/v3d_perfmon.c
@@ -305,7 +305,7 @@ static void v3d_perfmon_capture_locked(struct v3d_dev *v3d,
v3d_pm_runtime_put(v3d);
}
-void v3d_perfmon_stop_locked(struct v3d_dev *v3d, struct v3d_perfmon *perfmon,
+static void v3d_perfmon_stop_locked(struct v3d_dev *v3d, struct v3d_perfmon *perfmon,
bool capture)
{
lockdep_assert_held(&v3d->perfmon_state.lock);
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drm/v3d: Restrict v3d_perfmon_stop_locked() to v3d_perfmon.c
2026-09-21 19:00 [PATCH] drm/v3d: Restrict v3d_perfmon_stop_locked() to v3d_perfmon.c Erick Karanja
@ 2026-09-21 20:00 ` Maíra Canal
0 siblings, 0 replies; 2+ messages in thread
From: Maíra Canal @ 2026-09-21 20:00 UTC (permalink / raw)
To: mwen, Erick Karanja
Cc: Maíra Canal, maarten.lankhorst, mripard, tzimmermann,
airlied, simona, dri-devel, linux-kernel
On Mon, 21 Sep 2026 22:00:14 +0300, Erick Karanja wrote:
> v3d_perfmon_stop_locked() is only used within v3d_perfmon.c.
> Make the function file-local and remove its declaration from v3d_drv.h.
>
>
Applied with checkpatch fixes, thanks! Please, always verify for checkpatch
issues before submitting patches.
[1/1] drm/v3d: Restrict v3d_perfmon_stop_locked() to v3d_perfmon.c
commit: 8ef59ee794076e2b58cff357b12de2ba5d441271
Best regards,
- Maíra
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-21 20:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-21 19:00 [PATCH] drm/v3d: Restrict v3d_perfmon_stop_locked() to v3d_perfmon.c Erick Karanja
2026-09-21 20:00 ` Maíra Canal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.