[PATCH] dt-bindings: mfd: Allow MT6360 interrupt flags

[PATCH] dt-bindings: mfd: Allow MT6360 interrupt flags

[Rob Herring (Arm)]

MT6360 interrupt controllers use either one interrupt cell or two
cells, with the optional second cell carrying trigger flags. Allow both
forms.

Assisted-by: LLM
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 Documentation/devicetree/bindings/mfd/mediatek,mt6360.yaml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6360.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6360.yaml
index fb65abf30d57..828ed7f558f6 100644
--- a/Documentation/devicetree/bindings/mfd/mediatek,mt6360.yaml
+++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6360.yaml
@@ -33,9 +33,10 @@ properties:
   interrupt-controller: true
 
   "#interrupt-cells":
-    const: 1
+    enum: [1, 2]
     description:
-      The first cell is the IRQ number.
+      The first cell is the IRQ number. The optional second cell is the IRQ
+      trigger type.
 
   regulators:
     $ref: /schemas/regulator/mt6360-regulator.yaml#
-- 
2.53.0

Re: [PATCH] dt-bindings: mfd: Allow MT6360 interrupt flags

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: #interrupt-cells uses enum instead of required const constraint
--

commit 3c231e0793c5c72fac7dc860b2b89ed70228f7a3
Author: Rob Herring (Arm) <robh@kernel.org>

dt-bindings: mfd: Allow MT6360 interrupt flags

This commit updates the MT6360 device tree binding to allow the interrupt
controller to use either one or two cells. It replaces the constant cell
count constraint with an enum to support an optional second cell for
trigger flags.

> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6360.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6360.yaml
> index fb65abf30d57b..828ed7f558f66 100644
> --- a/Documentation/devicetree/bindings/mfd/mediatek,mt6360.yaml
> +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6360.yaml
> @@ -33,9 +33,10 @@ properties:
>    interrupt-controller: true
>  
>    "#interrupt-cells":
> -    const: 1
> +    enum: [1, 2]

[Severity: Medium]
Does this change conflict with the device tree binding subsystem rules? 

The subsystem guidelines mandate that cell-count properties like
#interrupt-cells must use a const constraint rather than an enum to prevent
ambiguous or variable cell sizes during schema validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921232701.3133291-1-robh@kernel.org?part=1

Re: [PATCH] dt-bindings: mfd: Allow MT6360 interrupt flags

[Rob Herring]

On Mon, Sep 21, 2026 at 11:32:49PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] dt-bindings: #interrupt-cells uses enum instead of required const constraint
> --
> 
> commit 3c231e0793c5c72fac7dc860b2b89ed70228f7a3
> Author: Rob Herring (Arm) <robh@kernel.org>
> 
> dt-bindings: mfd: Allow MT6360 interrupt flags
> 
> This commit updates the MT6360 device tree binding to allow the interrupt
> controller to use either one or two cells. It replaces the constant cell
> count constraint with an enum to support an optional second cell for
> trigger flags.
> 
> > diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6360.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6360.yaml
> > index fb65abf30d57b..828ed7f558f66 100644
> > --- a/Documentation/devicetree/bindings/mfd/mediatek,mt6360.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6360.yaml
> > @@ -33,9 +33,10 @@ properties:
> >    interrupt-controller: true
> >  
> >    "#interrupt-cells":
> > -    const: 1
> > +    enum: [1, 2]
> 
> [Severity: Medium]
> Does this change conflict with the device tree binding subsystem rules? 

No.

> The subsystem guidelines mandate that cell-count properties like
> #interrupt-cells must use a const constraint rather than an enum to prevent
> ambiguous or variable cell sizes during schema validation.

There's always exceptions to guidelines...

Rob

Re: (subset) [PATCH] dt-bindings: mfd: Allow MT6360 interrupt flags

[Lee Jones]

On Mon, 21 Sep 2026 18:27:00 -0500, Rob Herring (Arm) wrote:
> MT6360 interrupt controllers use either one interrupt cell or two
> cells, with the optional second cell carrying trigger flags. Allow both
> forms.

Applied, thanks!

[1/1] dt-bindings: mfd: Allow MT6360 interrupt flags
      commit: ee76e520857352ec34aaa5786db41610a4a25de7

--
Lee Jones [李琼斯]