All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: robh@kernel.org, vkoul@kernel.org, devicetree@vger.kernel.org,
	olteanv@gmail.com, conor+dt@kernel.org,
	neil.armstrong@linaro.org, linux-phy@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: phy: qcom: Relax required supplies
Date: Mon, 21 Sep 2026 23:34:22 +0000	[thread overview]
Message-ID: <20260921233422.E6B0D1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260921232603.3129898-1-robh@kernel.org>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: unintended schema relaxation for qcom,ipq5210-qusb2-phy
--

commit 69ee638f4004f6e325a963f3b804b3c1cac5c6fb
Author: Rob Herring (Arm) <robh@kernel.org>

dt-bindings: phy: qcom: Relax required supplies

This commit relaxes the requirement for three regulator supplies in the QUSB2
PHY binding for legacy IPQ6018 nodes that do not describe board rails.

> diff --git a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
> index 001fd0ccc9852..2516eab7f6d32 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
[ ... ]
>  allOf:
> +  - if:
> +      not:
> +        properties:
> +          compatible:
> +            contains:
> +              enum: 
> +                - qcom,ipq6018-qusb2-phy
> +                - qcom,ipq8074-qusb2-phy

[Severity: Medium]
Does this unintentionally relax the schema requirements for IPQ5210?

Since qcom,ipq5210-qusb2-phy falls back to qcom,ipq6018-qusb2-phy, an IPQ5210
device tree node's compatible array will contain qcom,ipq6018-qusb2-phy.

The 'contains: enum' logic matches this fallback, which seems like it might
incorrectly apply this legacy IPQ6018 exemption to IPQ5210 nodes, allowing
them to silently pass schema validation without the required regulator
supplies.

> +    then:
> +      required:
> +        - vdd-supply
> +        - vdda-pll-supply
> +        - vdda-phy-dpdm-supply

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921232603.3129898-1-robh@kernel.org?part=1

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: robh@kernel.org, vkoul@kernel.org, devicetree@vger.kernel.org,
	olteanv@gmail.com, conor+dt@kernel.org,
	neil.armstrong@linaro.org, linux-phy@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: phy: qcom: Relax required supplies
Date: Mon, 21 Sep 2026 23:34:22 +0000	[thread overview]
Message-ID: <20260921233422.E6B0D1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260921232603.3129898-1-robh@kernel.org>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: unintended schema relaxation for qcom,ipq5210-qusb2-phy
--

commit 69ee638f4004f6e325a963f3b804b3c1cac5c6fb
Author: Rob Herring (Arm) <robh@kernel.org>

dt-bindings: phy: qcom: Relax required supplies

This commit relaxes the requirement for three regulator supplies in the QUSB2
PHY binding for legacy IPQ6018 nodes that do not describe board rails.

> diff --git a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
> index 001fd0ccc9852..2516eab7f6d32 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
[ ... ]
>  allOf:
> +  - if:
> +      not:
> +        properties:
> +          compatible:
> +            contains:
> +              enum: 
> +                - qcom,ipq6018-qusb2-phy
> +                - qcom,ipq8074-qusb2-phy

[Severity: Medium]
Does this unintentionally relax the schema requirements for IPQ5210?

Since qcom,ipq5210-qusb2-phy falls back to qcom,ipq6018-qusb2-phy, an IPQ5210
device tree node's compatible array will contain qcom,ipq6018-qusb2-phy.

The 'contains: enum' logic matches this fallback, which seems like it might
incorrectly apply this legacy IPQ6018 exemption to IPQ5210 nodes, allowing
them to silently pass schema validation without the required regulator
supplies.

> +    then:
> +      required:
> +        - vdd-supply
> +        - vdda-pll-supply
> +        - vdda-phy-dpdm-supply

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921232603.3129898-1-robh@kernel.org?part=1

  reply	other threads:[~2026-09-21 23:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21 23:26 [PATCH] dt-bindings: phy: qcom: Relax required supplies Rob Herring (Arm)
2026-09-21 23:26 ` Rob Herring (Arm)
2026-09-21 23:34 ` sashiko-bot [this message]
2026-09-21 23:34   ` sashiko-bot
2026-10-12 16:18 ` Manivannan Sadhasivam
2026-10-12 16:18   ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260921233422.E6B0D1F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=neil.armstrong@linaro.org \
    --cc=olteanv@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.