Re: [PATCH v2] KVM: selftests: arm64: Add test for cross-vCPU LPI disable race

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] selftests: kvm: missing mandatory kvm_arch_has_default_irqchip() check
--

commit 41b2f5071c9e0e643d02d3f1806d75461776914a
Author: Yuchao Zhang <ndaugoing@gmail.com>

KVM: selftests: arm64: Add test for cross-vCPU LPI disable race

This patch adds a selftest to validate the behavior of remote LPI disabling
while the target vCPU has in-flight or overflowing LPIs. It configures an
ITS with multiple LPIs targeting vCPU 0, forcing its List Registers to
overflow, while vCPU 1 repeatedly toggles GICR_CTLR.EnableLPIs on vCPU 0's
redistributor.

> diff --git a/tools/testing/selftests/kvm/arm64/vgic_lpi_disable.c b/tools/testing/selftests/kvm/arm64/vgic_lpi_disable.c
> new file mode 100644
> index 0000000000000..d3480369d7607
> --- /dev/null
> +++ b/tools/testing/selftests/kvm/arm64/vgic_lpi_disable.c
[ ... ]
> +int main(int argc, char **argv)
> +{
> +	int opt;
> +
> +	TEST_REQUIRE(kvm_supports_vgic_v3());

[Severity: Medium]
Should this code also include a check for kvm_arch_has_default_irqchip()?

The KVM subsystem guidelines mandate that any selftest requiring an in-kernel
IRQ chip must call TEST_REQUIRE(kvm_arch_has_default_irqchip()). This ensures
the test is correctly skipped on platforms without default IRQ chip support.

> +
> +	while ((opt = getopt(argc, argv, "i:e:h")) != -1) {
> +		switch (opt) {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260922105331.40498-1-ndaugoing@gmail.com?part=1