All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Mimi Zohar <zohar@linux.ibm.com>,
	linux-integrity@vger.kernel.org, ltp@lists.linux.it
Cc: Cyril Hrubis <chrubis@suse.cz>
Subject: Re: [LTP] [PATCH 1/1] ima_setup.sh: Use tst_umount()
Date: Tue, 22 Sep 2026 19:22:13 +0200	[thread overview]
Message-ID: <20260922172213.GB2287170@pevik> (raw)
In-Reply-To: <20260814060102.GC261864@pevik>

Hi Mimi,

FYI I dared to merge following old proposal as
https://github.com/linux-test-project/ltp/commit/fc4c633f627121564e61c7cb3412976946c71562

to follow the approach used in other LTP tests (FYI we use the same approach
also for C based tests, see lib/tst_device.c). We can further improve the
function if needed (reduce number of loops or suggest another daemon).
Or finally remove it if it's really not needed.

Kind regards,
Petr

> > > ---
> > >  testcases/kernel/security/integrity/ima/tests/ima_setup.sh | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)

> > > diff --git a/testcases/kernel/security/integrity/ima/tests/ima_setup.sh b/testcases/kernel/security/integrity/ima/tests/ima_setup.sh
> > > index 19f00532b1..054ab28611 100644
> > > --- a/testcases/kernel/security/integrity/ima/tests/ima_setup.sh
> > > +++ b/testcases/kernel/security/integrity/ima/tests/ima_setup.sh
> > > @@ -313,7 +313,7 @@ ima_cleanup()
> > >  	[ -n "$TST_CLEANUP_CALLER" ] && $TST_CLEANUP_CALLER

> > >  	for dir in $UMOUNT; do
> > > -		umount $dir
> > > +		tst_umount $dir
> > >  	done

> > >  	if [ "$IMA_POLICY_LOADED" = 1 ]; then

WARNING: multiple messages have this Message-ID (diff)
From: Petr Vorel <pvorel@suse.cz>
To: Mimi Zohar <zohar@linux.ibm.com>,
	linux-integrity@vger.kernel.org, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] ima_setup.sh: Use tst_umount()
Date: Tue, 22 Sep 2026 19:22:13 +0200	[thread overview]
Message-ID: <20260922172213.GB2287170@pevik> (raw)
In-Reply-To: <20260814060102.GC261864@pevik>

Hi Mimi,

FYI I dared to merge following old proposal as
https://github.com/linux-test-project/ltp/commit/fc4c633f627121564e61c7cb3412976946c71562

to follow the approach used in other LTP tests (FYI we use the same approach
also for C based tests, see lib/tst_device.c). We can further improve the
function if needed (reduce number of loops or suggest another daemon).
Or finally remove it if it's really not needed.

Kind regards,
Petr

> > > ---
> > >  testcases/kernel/security/integrity/ima/tests/ima_setup.sh | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)

> > > diff --git a/testcases/kernel/security/integrity/ima/tests/ima_setup.sh b/testcases/kernel/security/integrity/ima/tests/ima_setup.sh
> > > index 19f00532b1..054ab28611 100644
> > > --- a/testcases/kernel/security/integrity/ima/tests/ima_setup.sh
> > > +++ b/testcases/kernel/security/integrity/ima/tests/ima_setup.sh
> > > @@ -313,7 +313,7 @@ ima_cleanup()
> > >  	[ -n "$TST_CLEANUP_CALLER" ] && $TST_CLEANUP_CALLER

> > >  	for dir in $UMOUNT; do
> > > -		umount $dir
> > > +		tst_umount $dir
> > >  	done

> > >  	if [ "$IMA_POLICY_LOADED" = 1 ]; then

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-09-22 17:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13 11:25 [PATCH 1/1] ima_setup.sh: Use tst_umount() Petr Vorel
2026-08-13 11:25 ` [LTP] " Petr Vorel
2026-08-13 11:48 ` [LTP] " linuxtestproject.agent
2026-08-13 11:54 ` [LTP] [PATCH 1/1] " Andrea Cervesato
2026-08-13 11:54   ` Andrea Cervesato via ltp
2026-08-14  1:18 ` Mimi Zohar
2026-08-14  1:18   ` [LTP] " Mimi Zohar
2026-08-14  6:01   ` Petr Vorel
2026-08-14  6:01     ` [LTP] " Petr Vorel
2026-09-22 17:22     ` Petr Vorel [this message]
2026-09-22 17:22       ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260922172213.GB2287170@pevik \
    --to=pvorel@suse.cz \
    --cc=chrubis@suse.cz \
    --cc=linux-integrity@vger.kernel.org \
    --cc=ltp@lists.linux.it \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.