From: Jakub Kicinski <kuba@kernel.org>
To: Coia Prant <coiaprant@gmail.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
netdev@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: ethernet: stmmac: dwmac-rk: fix bulk clock leak when the PHY clock fails
Date: Tue, 22 Sep 2026 19:17:58 -0700 [thread overview]
Message-ID: <20260922191758.2730da7a@kernel.org> (raw)
In-Reply-To: <20260919174223.2356964-1-coiaprant@gmail.com>
On Sun, 20 Sep 2026 01:42:23 +0800 Coia Prant wrote:
> if (ret)
> + clk_bulk_disable_unprepare(bsp_priv->num_clks,
> + bsp_priv->clks);
> return ret;
> + }
Missing a bracket, EBUILD. I almost appreciate seeing a human error like
this these days :)
--
pw-bot: cr
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Coia Prant <coiaprant@gmail.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
netdev@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: ethernet: stmmac: dwmac-rk: fix bulk clock leak when the PHY clock fails
Date: Tue, 22 Sep 2026 19:17:58 -0700 [thread overview]
Message-ID: <20260922191758.2730da7a@kernel.org> (raw)
In-Reply-To: <20260919174223.2356964-1-coiaprant@gmail.com>
On Sun, 20 Sep 2026 01:42:23 +0800 Coia Prant wrote:
> if (ret)
> + clk_bulk_disable_unprepare(bsp_priv->num_clks,
> + bsp_priv->clks);
> return ret;
> + }
Missing a bracket, EBUILD. I almost appreciate seeing a human error like
this these days :)
--
pw-bot: cr
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-09-23 2:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 17:42 [PATCH net] net: ethernet: stmmac: dwmac-rk: fix bulk clock leak when the PHY clock fails Coia Prant
2026-09-19 17:42 ` Coia Prant
2026-09-19 20:44 ` Maxime Chevallier
2026-09-19 20:44 ` Maxime Chevallier
2026-09-20 8:39 ` Lorenzo Bianconi
2026-09-20 8:39 ` Lorenzo Bianconi
2026-09-20 21:58 ` Heiko Stübner
2026-09-20 21:58 ` Heiko Stübner
2026-09-23 2:17 ` Jakub Kicinski [this message]
2026-09-23 2:17 ` Jakub Kicinski
2026-09-23 12:31 ` Coia Prant
2026-09-23 12:31 ` Coia Prant
2026-09-23 18:38 ` Andrew Lunn
2026-09-23 18:38 ` Andrew Lunn
2026-09-23 15:53 ` kernel test robot
2026-09-23 15:53 ` kernel test robot
2026-09-23 19:22 ` kernel test robot
2026-09-23 19:22 ` kernel test robot
2026-09-24 22:42 ` kernel test robot
2026-09-24 22:42 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922191758.2730da7a@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=coiaprant@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.