* [PATCH] perf jevents: Rename OMR offcore_rsp attribute to offmodule_rsp
@ 2026-09-23 1:55 Dapeng Mi
2026-09-23 2:07 ` sashiko-bot
2026-09-23 5:21 ` Ian Rogers
0 siblings, 2 replies; 4+ messages in thread
From: Dapeng Mi @ 2026-09-23 1:55 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Ian Rogers, Adrian Hunter, Alexander Shishkin
Cc: linux-perf-users, linux-kernel, Zide Chen, Falcon Thomas,
Dapeng Mi, Xudong Hao, Dapeng Mi
The kernel renamed the OMR data attribute from offcore_rsp to
offmodule_rsp to avoid confusion and keep the naming consistent.
So update the perf jevents msrmap accordingly.
Link: https://lore.kernel.org/all/20260917015234.981153-12-dapeng1.mi@linux.intel.com/
Link: https://lore.kernel.org/all/20260917015234.981153-13-dapeng1.mi@linux.intel.com/
Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
---
Note: The dependent kernel patches have been queued into tip/perf/urgent
tree.
tools/perf/pmu-events/jevents.py | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/perf/pmu-events/jevents.py b/tools/perf/pmu-events/jevents.py
index 860027bb71b2..93cf04fa8ca4 100755
--- a/tools/perf/pmu-events/jevents.py
+++ b/tools/perf/pmu-events/jevents.py
@@ -249,10 +249,10 @@ class JsonEvent:
0x3F6: 'ldlat=',
0x1A6: 'offcore_rsp=',
0x1A7: 'offcore_rsp=',
- 0x3E0: 'offcore_rsp=',
- 0x3E1: 'offcore_rsp=',
- 0x3E2: 'offcore_rsp=',
- 0x3E3: 'offcore_rsp=',
+ 0x3E0: 'offmodule_rsp=',
+ 0x3E1: 'offmodule_rsp=',
+ 0x3E2: 'offmodule_rsp=',
+ 0x3E3: 'offmodule_rsp=',
0x3F7: 'frontend=',
}
return msrmap[int(num.split(',', 1)[0], 0)]
base-commit: edd8a9fe2eca009599e013a29c421c7a6b5ad1b9
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] perf jevents: Rename OMR offcore_rsp attribute to offmodule_rsp
2026-09-23 1:55 [PATCH] perf jevents: Rename OMR offcore_rsp attribute to offmodule_rsp Dapeng Mi
@ 2026-09-23 2:07 ` sashiko-bot
2026-09-23 5:21 ` Ian Rogers
1 sibling, 0 replies; 4+ messages in thread
From: sashiko-bot @ 2026-09-23 2:07 UTC (permalink / raw)
To: Dapeng Mi; +Cc: linux-perf-users
> The kernel renamed the OMR data attribute from offcore_rsp to
> offmodule_rsp to avoid confusion and keep the naming consistent.
>
> So update the perf jevents msrmap accordingly.
>
> Link: https://lore.kernel.org/all/20260917015234.981153-12-dapeng1.mi@linux.intel.com/
> Link: https://lore.kernel.org/all/20260917015234.981153-13-dapeng1.mi@linux.intel.com/
> Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260923015517.2665398-1-dapeng1.mi@linux.intel.com?part=1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] perf jevents: Rename OMR offcore_rsp attribute to offmodule_rsp
2026-09-23 1:55 [PATCH] perf jevents: Rename OMR offcore_rsp attribute to offmodule_rsp Dapeng Mi
2026-09-23 2:07 ` sashiko-bot
@ 2026-09-23 5:21 ` Ian Rogers
2026-09-24 17:48 ` Arnaldo Carvalho de Melo
1 sibling, 1 reply; 4+ messages in thread
From: Ian Rogers @ 2026-09-23 5:21 UTC (permalink / raw)
To: Dapeng Mi
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Adrian Hunter, Alexander Shishkin, linux-perf-users,
linux-kernel, Zide Chen, Falcon Thomas, Dapeng Mi, Xudong Hao
On Tue, Sep 22, 2026 at 7:02 PM Dapeng Mi <dapeng1.mi@linux.intel.com> wrote:
>
> The kernel renamed the OMR data attribute from offcore_rsp to
> offmodule_rsp to avoid confusion and keep the naming consistent.
>
> So update the perf jevents msrmap accordingly.
>
> Link: https://lore.kernel.org/all/20260917015234.981153-12-dapeng1.mi@linux.intel.com/
> Link: https://lore.kernel.org/all/20260917015234.981153-13-dapeng1.mi@linux.intel.com/
> Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Reviewed-by: Ian Rogers <irogers@google.com>
Thanks,
Ian
> ---
>
> Note: The dependent kernel patches have been queued into tip/perf/urgent
> tree.
>
> tools/perf/pmu-events/jevents.py | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/perf/pmu-events/jevents.py b/tools/perf/pmu-events/jevents.py
> index 860027bb71b2..93cf04fa8ca4 100755
> --- a/tools/perf/pmu-events/jevents.py
> +++ b/tools/perf/pmu-events/jevents.py
> @@ -249,10 +249,10 @@ class JsonEvent:
> 0x3F6: 'ldlat=',
> 0x1A6: 'offcore_rsp=',
> 0x1A7: 'offcore_rsp=',
> - 0x3E0: 'offcore_rsp=',
> - 0x3E1: 'offcore_rsp=',
> - 0x3E2: 'offcore_rsp=',
> - 0x3E3: 'offcore_rsp=',
> + 0x3E0: 'offmodule_rsp=',
> + 0x3E1: 'offmodule_rsp=',
> + 0x3E2: 'offmodule_rsp=',
> + 0x3E3: 'offmodule_rsp=',
> 0x3F7: 'frontend=',
> }
> return msrmap[int(num.split(',', 1)[0], 0)]
>
> base-commit: edd8a9fe2eca009599e013a29c421c7a6b5ad1b9
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] perf jevents: Rename OMR offcore_rsp attribute to offmodule_rsp
2026-09-23 5:21 ` Ian Rogers
@ 2026-09-24 17:48 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2026-09-24 17:48 UTC (permalink / raw)
To: Ian Rogers
Cc: Dapeng Mi, Peter Zijlstra, Ingo Molnar, Namhyung Kim,
Adrian Hunter, Alexander Shishkin, linux-perf-users, linux-kernel,
Zide Chen, Falcon Thomas, Dapeng Mi, Xudong Hao
On Tue, Sep 22, 2026 at 10:21:58PM -0700, Ian Rogers wrote:
> On Tue, Sep 22, 2026 at 7:02 PM Dapeng Mi <dapeng1.mi@linux.intel.com> wrote:
> >
> > The kernel renamed the OMR data attribute from offcore_rsp to
> > offmodule_rsp to avoid confusion and keep the naming consistent.
> >
> > So update the perf jevents msrmap accordingly.
> >
> > Link: https://lore.kernel.org/all/20260917015234.981153-12-dapeng1.mi@linux.intel.com/
> > Link: https://lore.kernel.org/all/20260917015234.981153-13-dapeng1.mi@linux.intel.com/
> > Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
>
> Reviewed-by: Ian Rogers <irogers@google.com>
Thanks, applied to perf-tools-next, for v7.4.
- Arnaldo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-24 17:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-23 1:55 [PATCH] perf jevents: Rename OMR offcore_rsp attribute to offmodule_rsp Dapeng Mi
2026-09-23 2:07 ` sashiko-bot
2026-09-23 5:21 ` Ian Rogers
2026-09-24 17:48 ` Arnaldo Carvalho de Melo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.