Re: [PATCH v7 01/10] ASoC: dt-bindings: qcom,shikra-qaif-cpu: Add binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing dt-bindings header with DAI ID constants
--

commit 9d6bea13996a8ff10d5aa371fa14762934b560fe
Author: Harendra Gautam <harendra.gautam@oss.qualcomm.com>

ASoC: dt-bindings: qcom,shikra-qaif-cpu: Add binding

This commit adds the Devicetree binding for the Qualcomm Audio Interface
(QAIF) CPU DAI controller on the Shikra platform. It describes the
controller resources, DAI cells, and per-interface configuration nodes.

>     QAIF routes audio between system memory, external PCM/TDM/MI2S serial
>     interfaces and the internal Bolero/WCD codec. Platform Devicetree files
>     need a binding to describe the controller resources, DAI cells and per-
>     interface AIF configuration, and named constants to avoid raw numeric IDs
>     in sound-dai references and child-node reg values.

[Severity: Medium]
The commit message states that this patch provides named constants to avoid
raw numeric IDs. Was the dt-bindings header file containing these constants
forgotten in this patch series?

> diff --git a/Documentation/devicetree/bindings/sound/qcom,shikra-qaif-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,shikra-qaif-cpu.yaml
> new file mode 100644
> index 0000000000000..5cabbe54d6fd8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/qcom,shikra-qaif-cpu.yaml

[ ... ]

> +patternProperties:
> +  '^aif@[0-9a-f]+$':
> +    type: object
> +    description:
> +      QAIF AIF interface child node for PCM, TDM or MI2S configuration.
> +
> +    properties:
> +      reg:
> +        maxItems: 1
> +        description:
> +          DAI ID of the AIF interface (QAIF_MI2S_AIF* or QAIF_TDM_AIF*).

[Severity: Medium]
The schema documentation explicitly refers to the missing constants
(QAIF_MI2S_AIF* or QAIF_TDM_AIF*). Will subsequent driver patches that rely
on these undeclared constants result in compilation failures?

[ ... ]

> +            #sound-dai-cells = <1>;
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +
> +            aif@b5 {
> +                reg = <181>;

[Severity: Medium]
Does the binding example fall back to using a raw numeric ID (181) because
the constants were missing? This appears to contradict the stated goal of
avoiding raw numeric IDs.

> +                dai-format = "dsp_a";
> +                dai-tdm-slot-width = <32>;
> +                dai-tdm-slot-num = <2>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923-b4-qaif-shikra-audio-v7-0-d5b6f056568e@oss.qualcomm.com?part=1