Re: [PATCH v7 05/10] ASoC: soc-core: Add snd_soc_of_xlate_dai_name() generic helper

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] soc: build error due to implicit snd_soc_dai_name() declaration
--

commit b16b9f309d3d8ca044a5a756ee464aa98d0ba452
Author: Harendra Gautam <harendra.gautam@oss.qualcomm.com>
ASoC: soc-core: Add snd_soc_of_xlate_dai_name() generic helper

This commit adds a generic helper snd_soc_of_xlate_dai_name() to soc-core.c
for ASoC CPU DAI drivers. It resolves a sound-dai phandle argument to a DAI
name by iterating the component's DAI list and matching the DAI ID.

> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index b9c70268d49fe..fc3f1606f0837 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
[ ... ]
> +int snd_soc_of_xlate_dai_name(struct snd_soc_component *component,
> +			      const struct of_phandle_args *args,
> +			      const char **dai_name)
> +{
> +	struct snd_soc_dai *dai;
> +	int id;
> +
> +	if (args->args_count != 1)
> +		return -EINVAL;
> +
> +	id = args->args[0];
> +
> +	for_each_component_dais(component, dai) {
> +		if (dai->driver->id == id) {
> +			*dai_name = snd_soc_dai_name(dai);

[Severity: Low]
Does this code cause a build failure due to an implicit declaration of
snd_soc_dai_name()? It appears snd_soc_dai_name() does not exist in the
codebase. Should this use snd_soc_dai_name_get(dai) instead to successfully
retrieve the DAI name and avoid an invalid assignment?

> +			return 0;
> +		}
> +	}
> +
> +	return -EINVAL;
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923-b4-qaif-shikra-audio-v7-0-d5b6f056568e@oss.qualcomm.com?part=5