Re: [PATCH 1/6] arm64: dts: socfpga: agilex5: add DDR50 read-path tuning to sdmmc

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt: mmc: cdns,ddr50-* properties undocumented and unused
--

commit 980c0e02eef0135ea601c44b02d3683b9aeff804
Author: Tze Yee Ng <tze.yee.ng@altera.com>

arm64: dts: socfpga: agilex5: add DDR50 read-path tuning to sdmmc

Add the Cadence SD6HC DDR50 read-path tuning properties to the shared
Agilex5 sdmmc node.

> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> index 5f22e6d7ab858..dc25b7382a29f 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> @@ -322,6 +322,8 @@ sdmmc: mmc@10808000 {
>  			resets = <&rst SDMMC_RESET>, <&rst COMBOPHY_RESET>,
>  				 <&rst SDMMC_OCP_RESET>;
>  			reset-names = "sdhc-reset", "combophy", "sdmmc-ocp";
> +			cdns,ddr50-use-lpbk-dqs = <0>;
> +			cdns,ddr50-read-dqs-delay = <96>;

[Severity: Medium]
Are these cdns,ddr50-* properties documented in the device tree bindings or
supported by the driver?

Adding undocumented properties to the device tree without accompanying binding
documentation and driver support creates dead code and causes dtbs_check schema
validation errors, since the corresponding binding (cdns,sd6hc.yaml) enforces
unevaluatedProperties: false.

>  
>  			status = "disabled";
>  		};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1790151203.git.tze.yee.ng@altera.com?part=1