Re: [PATCH v8 11/25] iommu/arm-smmu-v3-kvm: Add the kernel driver

[Jason Gunthorpe <jgg@ziepe.ca>]

On Wed, Sep 23, 2026 at 05:07:54PM +0000, Mostafa Saleh wrote:
> On Wed, Sep 23, 2026 at 12:55:07PM -0300, Jason Gunthorpe wrote:
> > On Wed, Sep 23, 2026 at 11:52:36AM +0000, Mostafa Saleh wrote:
> > > I can add more info in the cover letter about the code split. Mainly:
> > > - arm-smmu-v3-kvm.c: Is the kernel driver for KVM SMMUv3 (this runs in
> > >   EL1 and can use all the kernel functions).
> > >   The main job of this driver is for discovery, it doesn't do anything
> > >   else in the runtime.
> > 
> > Maybe call this el1 stub or something like that?
> > 
> > guest_pkvm_stub.c
> > pkvm/hyp.c
> > 
> 
> It is not really a stub and I was following the convention of
> arm-smmu-v3-(iommufd/test/sva) I think for the pkvm/ one it can be:
> - pkvm/arm-smmu-v3-pkvm.c
> - pkvm/arm-smmu-v3-nested.c
> - pkvm/arm-smmu-v3-el2.c
> - pkvm/arm-smmu-v3-hyp.c

pkvm/arm-smmu-v3-hyp.c reads well to me

> All of those are fine and for the other one:
> - arm-smmu-v3-{pkvm, nested, el2, hyp}-init.c
> - arm-smmu-v3-pkvm-el1.c
> 
> Anything along this lines, otherwise it's too vague IMHO.

arm-smmu-v3-pkvm-init.c seems clear?

Linus has complained about the stuttering before, so think about it..

Jason