* drivers/crypto/ti/dthev2-common.c:44 dthe_get_dev() warn: can 'dev_data' even be NULL?
@ 2026-09-23 16:03 kernel test robot
0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2026-09-23 16:03 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Herbert Xu <herbert@gondor.apana.org.au>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: fe2ec83746e501645709761605c2464a44fd2929
commit: 35c5097f737a164b3afe23d07698db95061f0db8 crypto: ti - Enable compile testing for dthev2
date: 1 year, 1 month ago
:::::: branch date: 23 hours ago
:::::: commit date: 1 year, 1 month ago
config: m68k-randconfig-r2201-20260923 (https://download.01.org/0day-ci/archive/20260923/202609231840.kAb2aFiZ-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.5.0
smatch: v0.5.0-9187-g5189e3fb
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: 35c5097f737a ("crypto: ti - Enable compile testing for dthev2")
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202609231840.kAb2aFiZ-lkp@intel.com/
smatch warnings:
drivers/crypto/ti/dthev2-common.c:44 dthe_get_dev() warn: can 'dev_data' even be NULL?
vim +/dev_data +44 drivers/crypto/ti/dthev2-common.c
52f641bc63a466 T Pratham 2025-08-20 34
52f641bc63a466 T Pratham 2025-08-20 35 struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx)
52f641bc63a466 T Pratham 2025-08-20 36 {
52f641bc63a466 T Pratham 2025-08-20 37 struct dthe_data *dev_data;
52f641bc63a466 T Pratham 2025-08-20 38
52f641bc63a466 T Pratham 2025-08-20 39 if (ctx->dev_data)
52f641bc63a466 T Pratham 2025-08-20 40 return ctx->dev_data;
52f641bc63a466 T Pratham 2025-08-20 41
52f641bc63a466 T Pratham 2025-08-20 42 spin_lock_bh(&dthe_dev_list.lock);
52f641bc63a466 T Pratham 2025-08-20 43 dev_data = list_first_entry(&dthe_dev_list.dev_list, struct dthe_data, list);
52f641bc63a466 T Pratham 2025-08-20 @44 if (dev_data)
52f641bc63a466 T Pratham 2025-08-20 45 list_move_tail(&dev_data->list, &dthe_dev_list.dev_list);
52f641bc63a466 T Pratham 2025-08-20 46 spin_unlock_bh(&dthe_dev_list.lock);
52f641bc63a466 T Pratham 2025-08-20 47
52f641bc63a466 T Pratham 2025-08-20 48 return dev_data;
52f641bc63a466 T Pratham 2025-08-20 49 }
52f641bc63a466 T Pratham 2025-08-20 50
:::::: The code at line 44 was first introduced by commit
:::::: 52f641bc63a46657b1d72d902fcee30ab1233c7b crypto: ti - Add driver for DTHE V2 AES Engine (ECB, CBC)
:::::: TO: T Pratham <t-pratham@ti.com>
:::::: CC: Herbert Xu <herbert@gondor.apana.org.au>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread* drivers/crypto/ti/dthev2-common.c:44 dthe_get_dev() warn: can 'dev_data' even be NULL?
@ 2026-06-11 11:19 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2026-06-11 11:10 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Herbert Xu <herbert@gondor.apana.org.au>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 9716c086c8e8b141d35aa61f2e96a2e83de212a7
commit: 35c5097f737a164b3afe23d07698db95061f0db8 crypto: ti - Enable compile testing for dthev2
date: 9 months ago
:::::: branch date: 16 hours ago
:::::: commit date: 9 months ago
config: s390-randconfig-r072-20260611 (https://download.01.org/0day-ci/archive/20260611/202606111933.69GGTKxr-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
smatch: v0.5.0-9185-gbcc58b9c
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: 35c5097f737a ("crypto: ti - Enable compile testing for dthev2")
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202606111933.69GGTKxr-lkp@intel.com/
smatch warnings:
drivers/crypto/ti/dthev2-common.c:44 dthe_get_dev() warn: can 'dev_data' even be NULL?
vim +/dev_data +44 drivers/crypto/ti/dthev2-common.c
52f641bc63a4665 T Pratham 2025-08-20 34
52f641bc63a4665 T Pratham 2025-08-20 35 struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx)
52f641bc63a4665 T Pratham 2025-08-20 36 {
52f641bc63a4665 T Pratham 2025-08-20 37 struct dthe_data *dev_data;
52f641bc63a4665 T Pratham 2025-08-20 38
52f641bc63a4665 T Pratham 2025-08-20 39 if (ctx->dev_data)
52f641bc63a4665 T Pratham 2025-08-20 40 return ctx->dev_data;
52f641bc63a4665 T Pratham 2025-08-20 41
52f641bc63a4665 T Pratham 2025-08-20 42 spin_lock_bh(&dthe_dev_list.lock);
52f641bc63a4665 T Pratham 2025-08-20 43 dev_data = list_first_entry(&dthe_dev_list.dev_list, struct dthe_data, list);
52f641bc63a4665 T Pratham 2025-08-20 @44 if (dev_data)
52f641bc63a4665 T Pratham 2025-08-20 45 list_move_tail(&dev_data->list, &dthe_dev_list.dev_list);
52f641bc63a4665 T Pratham 2025-08-20 46 spin_unlock_bh(&dthe_dev_list.lock);
52f641bc63a4665 T Pratham 2025-08-20 47
52f641bc63a4665 T Pratham 2025-08-20 48 return dev_data;
52f641bc63a4665 T Pratham 2025-08-20 49 }
52f641bc63a4665 T Pratham 2025-08-20 50
:::::: The code at line 44 was first introduced by commit
:::::: 52f641bc63a46657b1d72d902fcee30ab1233c7b crypto: ti - Add driver for DTHE V2 AES Engine (ECB, CBC)
:::::: TO: T Pratham <t-pratham@ti.com>
:::::: CC: Herbert Xu <herbert@gondor.apana.org.au>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread* drivers/crypto/ti/dthev2-common.c:44 dthe_get_dev() warn: can 'dev_data' even be NULL?
@ 2026-06-11 11:19 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2026-06-11 11:19 UTC (permalink / raw)
To: oe-kbuild, T Pratham; +Cc: lkp, oe-kbuild-all, linux-kernel, Herbert Xu
[ I don't know why the zero data bot doesn't include T Pratham in the
CC list... -dan ]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 9716c086c8e8b141d35aa61f2e96a2e83de212a7
commit: 35c5097f737a164b3afe23d07698db95061f0db8 crypto: ti - Enable compile testing for dthev2
config: s390-randconfig-r072-20260611 (https://download.01.org/0day-ci/archive/20260611/202606111933.69GGTKxr-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
smatch: v0.5.0-9185-gbcc58b9c
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: 35c5097f737a ("crypto: ti - Enable compile testing for dthev2")
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202606111933.69GGTKxr-lkp@intel.com/
smatch warnings:
drivers/crypto/ti/dthev2-common.c:44 dthe_get_dev() warn: can 'dev_data' even be NULL?
vim +/dev_data +44 drivers/crypto/ti/dthev2-common.c
52f641bc63a4665 T Pratham 2025-08-20 35 struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx)
52f641bc63a4665 T Pratham 2025-08-20 36 {
52f641bc63a4665 T Pratham 2025-08-20 37 struct dthe_data *dev_data;
52f641bc63a4665 T Pratham 2025-08-20 38
52f641bc63a4665 T Pratham 2025-08-20 39 if (ctx->dev_data)
52f641bc63a4665 T Pratham 2025-08-20 40 return ctx->dev_data;
52f641bc63a4665 T Pratham 2025-08-20 41
52f641bc63a4665 T Pratham 2025-08-20 42 spin_lock_bh(&dthe_dev_list.lock);
52f641bc63a4665 T Pratham 2025-08-20 43 dev_data = list_first_entry(&dthe_dev_list.dev_list, struct dthe_data, list);
52f641bc63a4665 T Pratham 2025-08-20 @44 if (dev_data)
This check doesn't make sense since list_first_entry() never returns
NULL. Maybe list_first_entry_or_null() was intended?
52f641bc63a4665 T Pratham 2025-08-20 45 list_move_tail(&dev_data->list, &dthe_dev_list.dev_list);
52f641bc63a4665 T Pratham 2025-08-20 46 spin_unlock_bh(&dthe_dev_list.lock);
52f641bc63a4665 T Pratham 2025-08-20 47
52f641bc63a4665 T Pratham 2025-08-20 48 return dev_data;
52f641bc63a4665 T Pratham 2025-08-20 49 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread
* drivers/crypto/ti/dthev2-common.c:44 dthe_get_dev() warn: can 'dev_data' even be NULL?
@ 2025-12-18 7:19 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2025-12-18 5:24 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Herbert Xu <herbert@gondor.apana.org.au>
Hi Herbert,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: ea1013c1539270e372fc99854bc6e4d94eaeff66
commit: 35c5097f737a164b3afe23d07698db95061f0db8 crypto: ti - Enable compile testing for dthev2
date: 3 months ago
:::::: branch date: 25 hours ago
:::::: commit date: 3 months ago
config: s390-randconfig-r071-20251217 (https://download.01.org/0day-ci/archive/20251218/202512181322.nBkDZbGb-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 14.3.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202512181322.nBkDZbGb-lkp@intel.com/
smatch warnings:
drivers/crypto/ti/dthev2-common.c:44 dthe_get_dev() warn: can 'dev_data' even be NULL?
vim +/dev_data +44 drivers/crypto/ti/dthev2-common.c
52f641bc63a4665 T Pratham 2025-08-20 34
52f641bc63a4665 T Pratham 2025-08-20 35 struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx)
52f641bc63a4665 T Pratham 2025-08-20 36 {
52f641bc63a4665 T Pratham 2025-08-20 37 struct dthe_data *dev_data;
52f641bc63a4665 T Pratham 2025-08-20 38
52f641bc63a4665 T Pratham 2025-08-20 39 if (ctx->dev_data)
52f641bc63a4665 T Pratham 2025-08-20 40 return ctx->dev_data;
52f641bc63a4665 T Pratham 2025-08-20 41
52f641bc63a4665 T Pratham 2025-08-20 42 spin_lock_bh(&dthe_dev_list.lock);
52f641bc63a4665 T Pratham 2025-08-20 43 dev_data = list_first_entry(&dthe_dev_list.dev_list, struct dthe_data, list);
52f641bc63a4665 T Pratham 2025-08-20 @44 if (dev_data)
52f641bc63a4665 T Pratham 2025-08-20 45 list_move_tail(&dev_data->list, &dthe_dev_list.dev_list);
52f641bc63a4665 T Pratham 2025-08-20 46 spin_unlock_bh(&dthe_dev_list.lock);
52f641bc63a4665 T Pratham 2025-08-20 47
52f641bc63a4665 T Pratham 2025-08-20 48 return dev_data;
52f641bc63a4665 T Pratham 2025-08-20 49 }
52f641bc63a4665 T Pratham 2025-08-20 50
:::::: The code at line 44 was first introduced by commit
:::::: 52f641bc63a46657b1d72d902fcee30ab1233c7b crypto: ti - Add driver for DTHE V2 AES Engine (ECB, CBC)
:::::: TO: T Pratham <t-pratham@ti.com>
:::::: CC: Herbert Xu <herbert@gondor.apana.org.au>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread* drivers/crypto/ti/dthev2-common.c:44 dthe_get_dev() warn: can 'dev_data' even be NULL?
@ 2025-12-18 7:19 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2025-12-18 7:19 UTC (permalink / raw)
To: oe-kbuild, Herbert Xu; +Cc: lkp, oe-kbuild-all, linux-kernel
Hi Herbert,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: ea1013c1539270e372fc99854bc6e4d94eaeff66
commit: 35c5097f737a164b3afe23d07698db95061f0db8 crypto: ti - Enable compile testing for dthev2
config: s390-randconfig-r071-20251217 (https://download.01.org/0day-ci/archive/20251218/202512181322.nBkDZbGb-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 14.3.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202512181322.nBkDZbGb-lkp@intel.com/
smatch warnings:
drivers/crypto/ti/dthev2-common.c:44 dthe_get_dev() warn: can 'dev_data' even be NULL?
vim +/dev_data +44 drivers/crypto/ti/dthev2-common.c
52f641bc63a4665 T Pratham 2025-08-20 35 struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx)
52f641bc63a4665 T Pratham 2025-08-20 36 {
52f641bc63a4665 T Pratham 2025-08-20 37 struct dthe_data *dev_data;
52f641bc63a4665 T Pratham 2025-08-20 38
52f641bc63a4665 T Pratham 2025-08-20 39 if (ctx->dev_data)
52f641bc63a4665 T Pratham 2025-08-20 40 return ctx->dev_data;
52f641bc63a4665 T Pratham 2025-08-20 41
52f641bc63a4665 T Pratham 2025-08-20 42 spin_lock_bh(&dthe_dev_list.lock);
52f641bc63a4665 T Pratham 2025-08-20 43 dev_data = list_first_entry(&dthe_dev_list.dev_list, struct dthe_data, list);
52f641bc63a4665 T Pratham 2025-08-20 @44 if (dev_data)
52f641bc63a4665 T Pratham 2025-08-20 45 list_move_tail(&dev_data->list, &dthe_dev_list.dev_list);
dev_data can't be NULL. Probably this should use list_first_entry_or_null()
52f641bc63a4665 T Pratham 2025-08-20 46 spin_unlock_bh(&dthe_dev_list.lock);
52f641bc63a4665 T Pratham 2025-08-20 47
52f641bc63a4665 T Pratham 2025-08-20 48 return dev_data;
52f641bc63a4665 T Pratham 2025-08-20 49 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-09-23 16:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-23 16:03 drivers/crypto/ti/dthev2-common.c:44 dthe_get_dev() warn: can 'dev_data' even be NULL? kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2026-06-11 11:10 kernel test robot
2026-06-11 11:19 ` Dan Carpenter
2025-12-18 5:24 kernel test robot
2025-12-18 7:19 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.