* [to-be-updated] mm-huge_memory-move-unmap-and-remap-into-the-split-helpers.patch removed from -mm tree
@ 2026-09-23 22:23 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2026-09-23 22:23 UTC (permalink / raw)
To: mm-commits, kasong, akpm
The quilt patch titled
Subject: mm/huge_memory: move unmap and remap into the split helpers
has been removed from the -mm tree. Its filename was
mm-huge_memory-move-unmap-and-remap-into-the-split-helpers.patch
This patch was dropped because an updated version will be issued
------------------------------------------------------
From: Kairui Song <kasong@tencent.com>
Subject: mm/huge_memory: move unmap and remap into the split helpers
Date: Tue, 15 Sep 2026 01:14:49 +0800
To prepare for further cleanup, move the unmap/remap handling from
__folio_split() into the split helpers. Only anon folios need to be
remapped, so remap_page() is now only called for anon splits and the anon
check in remap_page() is redundant and can be removed.
Link: https://lore.kernel.org/20260915-swap-thp-cleanup-v5-8-39878b37dfb0@tencent.com
Signed-off-by: Kairui Song <kasong@tencent.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Zi Yan <ziy@nvidia.com>
Reviewed-by: Yeoreum Yun <yeoreum.yun@arm.com>
Reviewed-by: Kiryl Shutsemau (Meta) <kas@kernel.org>
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Baoquan He <baoquan.he@linux.dev>
Cc: Barry Song <baohua@kernel.org>
Cc: Chris Li <chrisl@kernel.org>
Cc: Dev Jain <dev.jain@arm.com>
Cc: Kemeng Shi <shikemeng@huaweicloud.com>
Cc: Lance Yang <lance.yang@linux.dev>
Cc: Liam R. Howlett <liam@infradead.org>
Cc: Lorenzo Stoakes <ljs@kernel.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Nhat Pham <nphamcs@gmail.com>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Vlastimil Babka <vbabka@kernel.org>
---
mm/huge_memory.c | 36 ++++++++++++++++++++++--------------
1 file changed, 22 insertions(+), 14 deletions(-)
--- a/mm/huge_memory.c~mm-huge_memory-move-unmap-and-remap-into-the-split-helpers
+++ a/mm/huge_memory.c
@@ -3640,9 +3640,6 @@ static void remap_page(struct folio *fol
{
int i = 0;
- /* If unmap_folio() uses try_to_migrate() on file, remove this check */
- if (!folio_test_anon(folio))
- return;
for (;;) {
remove_migration_ptes(folio, folio, TTU_RMAP_LOCKED | flags);
i += folio_nr_pages(folio);
@@ -4016,15 +4013,23 @@ static int __folio_freeze_split_anon(str
{
struct folio *end_folio = folio_next(folio);
struct swap_cluster_info *ci = NULL;
+ int old_order = folio_order(folio);
struct folio *new_folio, *next;
+ enum ttu_flags ttu_flags = 0;
struct lruvec *lruvec;
+ bool need_remap = false;
int ret = 0;
+ if (folio_mapped(folio)) {
+ need_remap = true;
+ unmap_folio(folio);
+ }
+
local_irq_disable();
if (!folio_ref_freeze(folio, folio_cache_ref_count(folio) + 1)) {
- local_irq_enable();
- return -EAGAIN;
+ ret = -EAGAIN;
+ goto out_no_split;
}
/* Take off the deferred split queue while frozen and memcg set */
@@ -4073,7 +4078,13 @@ static int __folio_freeze_split_anon(str
lruvec_unlock(lruvec);
if (ci)
swap_cluster_unlock(ci);
+out_no_split:
local_irq_enable();
+ if (need_remap) {
+ if (!ret && !folio_is_device_private(folio))
+ ttu_flags = TTU_USE_SHARED_ZEROPAGE;
+ remap_page(folio, 1 << old_order, ttu_flags);
+ }
return ret;
}
@@ -4105,6 +4116,8 @@ static int __folio_freeze_split_file(str
if (shmem_mapping(mapping))
end = shmem_fallocend(mapping->host, end);
+ unmap_folio(folio);
+
xas_lock_irq(xas);
/*
@@ -4189,8 +4202,11 @@ static int __folio_freeze_split_file(str
if (do_lru)
lruvec_unlock(lruvec);
-
fail:
+ /*
+ * If we want to use try_to_migrate() on file in unmap_folio,
+ * remember to add remap_page() and adapt it.
+ */
xas_unlock_irq(xas);
if (nr_shmem_dropped)
shmem_uncharge(mapping->host, nr_shmem_dropped);
@@ -4230,7 +4246,6 @@ static int __folio_split(struct folio *f
struct anon_vma *anon_vma = NULL;
int old_order = folio_order(folio);
struct folio *new_folio, *next;
- enum ttu_flags ttu_flags = 0;
int ret;
VM_WARN_ON_ONCE_FOLIO(!folio_test_locked(folio), folio);
@@ -4318,8 +4333,6 @@ static int __folio_split(struct folio *f
goto out_unlock;
}
- unmap_folio(folio);
-
if (is_anon)
ret = __folio_freeze_split_anon(folio, new_order, split_at,
true, list, split_type);
@@ -4327,11 +4340,6 @@ static int __folio_split(struct folio *f
ret = __folio_freeze_split_file(folio, new_order, split_at, &xas, mapping,
true, list, split_type);
- if (!ret && is_anon && !folio_is_device_private(folio))
- ttu_flags = TTU_USE_SHARED_ZEROPAGE;
-
- remap_page(folio, 1 << old_order, ttu_flags);
-
/*
* Drop the mapping while the inode is still pinned. @folio stays
* locked and present in the page cache until the loop below, so
_
Patches currently in -mm which might be from kasong@tencent.com are
mm-memcontrol-move-the-lru_zone_size-sanity-check-to-the-reader-side.patch
mm-mglru-introduce-helpers-for-manipulating-gen-and-refs-flags.patch
mm-migrate-copy-all-referenced-state-via-folio_migrate_lru_refs.patch
mm-mglru-move-max_seq-read-into-walk_update_folio.patch
mm-mglru-use-explicit-tier-range-in-read_ctrl_pos.patch
mm-mglru-fix-potential-generation-folio-number-leak.patch
mm-huge_memory-rename-remap_page-to-remap_anon_folio.patch
mm-huge_memory-move-the-racy-refcount-check-into-unmap_folio.patch
mm-huge_memory-move-filemap-management-into-the-file-split-helper.patch
mm-huge_memory-move-anon_vma-handling-into-the-anon-split-helper.patch
mm-huge_memory-move-memcg-switch-into-the-file-split-helper.patch
mm-huge_memory-drop-the-unused-do_lru-argument-of-the-file-split-helper.patch
mm-huge_memory-clean-up-after-split-folio-freeing-in-__folio_split.patch
mm-huge_memory-count-only-swap-cache-refs-in-anon-folio-split.patch
mm-huge_memory-drop-the-redundant-mapping-argument-of-__split_frozen_folio.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-09-23 22:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-23 22:23 [to-be-updated] mm-huge_memory-move-unmap-and-remap-into-the-split-helpers.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.