* [to-be-updated] mm-huge_memory-count-only-swap-cache-refs-in-anon-folio-split.patch removed from -mm tree
@ 2026-09-23 22:23 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2026-09-23 22:23 UTC (permalink / raw)
To: mm-commits, kasong, akpm
The quilt patch titled
Subject: mm/huge_memory: count only swap cache refs in anon folio split
has been removed from the -mm tree. Its filename was
mm-huge_memory-count-only-swap-cache-refs-in-anon-folio-split.patch
This patch was dropped because an updated version will be issued
------------------------------------------------------
From: Kairui Song <kasong@tencent.com>
Subject: mm/huge_memory: count only swap cache refs in anon folio split
Date: Tue, 15 Sep 2026 01:14:57 +0800
Only __folio_freeze_split_anon() sees anon folios and swap cache folios
now. The file split helper only handles page cache folios, which hold
exactly folio_nr_pages() references.
Rename folio_cache_ref_count() to folio_swapcache_ref_count() and drop the
anon check so the helper counts what its name says. The file split helper
now uses folio_nr_pages() directly.
No feature change.
Link: https://lore.kernel.org/20260915-swap-thp-cleanup-v5-16-39878b37dfb0@tencent.com
Signed-off-by: Kairui Song <kasong@tencent.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Zi Yan <ziy@nvidia.com>
Reviewed-by: Yeoreum Yun <yeoreum.yun@arm.com>
Reviewed-by: Kiryl Shutsemau (Meta) <kas@kernel.org>
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Baoquan He <baoquan.he@linux.dev>
Cc: Barry Song <baohua@kernel.org>
Cc: Chris Li <chrisl@kernel.org>
Cc: Dev Jain <dev.jain@arm.com>
Cc: Kemeng Shi <shikemeng@huaweicloud.com>
Cc: Lance Yang <lance.yang@linux.dev>
Cc: Liam R. Howlett <liam@infradead.org>
Cc: Lorenzo Stoakes <ljs@kernel.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Nhat Pham <nphamcs@gmail.com>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Vlastimil Babka <vbabka@kernel.org>
---
mm/huge_memory.c | 35 +++++++++++++++--------------------
1 file changed, 15 insertions(+), 20 deletions(-)
--- a/mm/huge_memory.c~mm-huge_memory-count-only-swap-cache-refs-in-anon-folio-split
+++ a/mm/huge_memory.c
@@ -3993,10 +3993,10 @@ int folio_check_splittable(struct folio
return 0;
}
-/* Number of folio references from the pagecache or the swapcache. */
-static unsigned int folio_cache_ref_count(const struct folio *folio)
+/* Number of folio references from the swapcache. */
+static unsigned int folio_swapcache_ref_count(const struct folio *folio)
{
- if (folio_test_anon(folio) && !folio_test_swapcache(folio))
+ if (!folio_test_swapcache(folio))
return 0;
return folio_nr_pages(folio);
}
@@ -4064,7 +4064,7 @@ static int __folio_freeze_split_anon(str
local_irq_disable();
- if (!folio_ref_freeze(folio, folio_cache_ref_count(folio) + 1)) {
+ if (!folio_ref_freeze(folio, folio_swapcache_ref_count(folio) + 1)) {
ret = -EAGAIN;
goto out_no_split;
}
@@ -4101,7 +4101,7 @@ static int __folio_freeze_split_anon(str
next = folio_next(new_folio);
zone_device_private_split_cb(folio, new_folio);
folio_ref_unfreeze(new_folio,
- folio_cache_ref_count(new_folio) + 1);
+ folio_swapcache_ref_count(new_folio) + 1);
if (do_lru)
lru_add_split_folio(folio, new_folio, lruvec, list);
if (ci)
@@ -4109,7 +4109,7 @@ static int __folio_freeze_split_anon(str
}
zone_device_private_split_cb(folio, NULL);
- folio_ref_unfreeze(folio, folio_cache_ref_count(folio) + 1);
+ folio_ref_unfreeze(folio, folio_swapcache_ref_count(folio) + 1);
if (do_lru)
lruvec_unlock(lruvec);
@@ -4138,6 +4138,7 @@ static int __folio_freeze_split_file(str
struct address_space *mapping = folio->mapping;
XA_STATE(xas, &mapping->i_pages, folio->index);
struct folio *end_folio = folio_next(folio);
+ long old_nr_pages = folio_nr_pages(folio);
struct mem_cgroup *memcg, *old_memcg;
struct folio *new_folio, *next;
int nr_shmem_dropped = 0;
@@ -4208,22 +4209,16 @@ static int __folio_freeze_split_file(str
goto fail;
}
- if (!folio_ref_freeze(folio, folio_cache_ref_count(folio) + 1)) {
+ if (!folio_ref_freeze(folio, old_nr_pages + 1)) {
ret = -EAGAIN;
goto fail;
}
- if (folio_test_pmd_mappable(folio) &&
- new_order < HPAGE_PMD_ORDER) {
- int nr = folio_nr_pages(folio);
-
- if (folio_test_swapbacked(folio)) {
- lruvec_stat_mod_folio(folio,
- NR_SHMEM_THPS, -nr);
- } else {
- lruvec_stat_mod_folio(folio,
- NR_FILE_THPS, -nr);
- }
+ if (folio_test_pmd_mappable(folio) && new_order < HPAGE_PMD_ORDER) {
+ if (folio_test_swapbacked(folio))
+ lruvec_stat_mod_folio(folio, NR_SHMEM_THPS, -old_nr_pages);
+ else
+ lruvec_stat_mod_folio(folio, NR_FILE_THPS, -old_nr_pages);
}
/* lock lru list/PageCompound, ref frozen by page_ref_freeze */
@@ -4247,7 +4242,7 @@ static int __folio_freeze_split_file(str
next = folio_next(new_folio);
folio_ref_unfreeze(new_folio,
- folio_cache_ref_count(new_folio) + 1);
+ folio_nr_pages(new_folio) + 1);
lru_add_split_folio(folio, new_folio, lruvec, list);
@@ -4274,7 +4269,7 @@ static int __folio_freeze_split_file(str
* Otherwise, a parallel folio_try_get() can grab @folio
* and its caller can see stale page cache entries.
*/
- folio_ref_unfreeze(folio, folio_cache_ref_count(folio) + 1);
+ folio_ref_unfreeze(folio, folio_nr_pages(folio) + 1);
lruvec_unlock(lruvec);
fail:
/*
_
Patches currently in -mm which might be from kasong@tencent.com are
mm-memcontrol-move-the-lru_zone_size-sanity-check-to-the-reader-side.patch
mm-mglru-introduce-helpers-for-manipulating-gen-and-refs-flags.patch
mm-migrate-copy-all-referenced-state-via-folio_migrate_lru_refs.patch
mm-mglru-move-max_seq-read-into-walk_update_folio.patch
mm-mglru-use-explicit-tier-range-in-read_ctrl_pos.patch
mm-mglru-fix-potential-generation-folio-number-leak.patch
mm-huge_memory-drop-the-redundant-mapping-argument-of-__split_frozen_folio.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-09-23 22:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-23 22:23 [to-be-updated] mm-huge_memory-count-only-swap-cache-refs-in-anon-folio-split.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.