All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] hwmon: (dell-smm) Add Dell 16 DC16250 to fan control whitelist
@ 2026-09-24  4:48 Emanuel Ávila
  2026-09-24  4:51 ` sashiko-bot
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Emanuel Ávila @ 2026-09-24  4:48 UTC (permalink / raw)
  To: Pali Rohár, Guenter Roeck
  Cc: linux-hwmon, linux-kernel, Emanuel Ávila

On the Dell 16 DC16250, the BIOS keeps the CPU fan at its highest state
(~4700 RPM) even when the system is idle at 45 °C, and fan speed writes
through pwm1 are overridden by the BIOS within a few seconds.

The I8K_FAN_30A3_31A3 SMM code pair works on this machine through the
WMI-SMM backend: after writing 1 to pwm1_enable, the fan accepts all
three fan states (0, 128 and 255 via pwm1) and reports matching RPM,
and writing 2 hands control back to the BIOS.

Tested on BIOS 1.8.1 with kernel 7.1.5 (Pop!_OS 24.04).

Assisted-by: claude-opus-5-5
Signed-off-by: Emanuel Ávila <avilaemanueel@gmail.com>
---
 drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index 99a58ed26..88837f028 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -1679,6 +1679,14 @@ static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
 		},
 		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_30A3_31A3],
 	},
+	{
+		.ident = "Dell 16 DC16250",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell 16 DC16250"),
+		},
+		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_30A3_31A3],
+	},
 	{ }
 };
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] hwmon: (dell-smm) Add Dell 16 DC16250 to fan control whitelist
  2026-09-24  4:48 [PATCH] hwmon: (dell-smm) Add Dell 16 DC16250 to fan control whitelist Emanuel Ávila
@ 2026-09-24  4:51 ` sashiko-bot
  2026-09-24  8:11 ` Pali Rohár
  2026-09-24 16:49 ` Guenter Roeck
  2 siblings, 0 replies; 4+ messages in thread
From: sashiko-bot @ 2026-09-24  4:51 UTC (permalink / raw)
  To: Emanuel Ávila; +Cc: linux-hwmon

> On the Dell 16 DC16250, the BIOS keeps the CPU fan at its highest state
> (~4700 RPM) even when the system is idle at 45 °C, and fan speed writes
> through pwm1 are overridden by the BIOS within a few seconds.
> 
> The I8K_FAN_30A3_31A3 SMM code pair works on this machine through the
> WMI-SMM backend: after writing 1 to pwm1_enable, the fan accepts all
> three fan states (0, 128 and 255 via pwm1) and reports matching RPM,
> and writing 2 hands control back to the BIOS.
> 
> Tested on BIOS 1.8.1 with kernel 7.1.5 (Pop!_OS 24.04).
> 
> Assisted-by: claude-opus-5-5
> Signed-off-by: Emanuel Ávila <avilaemanueel@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924044829.2889204-1-avilaemanueel@gmail.com?part=1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] hwmon: (dell-smm) Add Dell 16 DC16250 to fan control whitelist
  2026-09-24  4:48 [PATCH] hwmon: (dell-smm) Add Dell 16 DC16250 to fan control whitelist Emanuel Ávila
  2026-09-24  4:51 ` sashiko-bot
@ 2026-09-24  8:11 ` Pali Rohár
  2026-09-24 16:49 ` Guenter Roeck
  2 siblings, 0 replies; 4+ messages in thread
From: Pali Rohár @ 2026-09-24  8:11 UTC (permalink / raw)
  To: Emanuel Ávila; +Cc: Guenter Roeck, linux-hwmon, linux-kernel

On Thursday 24 September 2026 01:48:29 Emanuel Ávila wrote:
> On the Dell 16 DC16250, the BIOS keeps the CPU fan at its highest state
> (~4700 RPM) even when the system is idle at 45 °C, and fan speed writes
> through pwm1 are overridden by the BIOS within a few seconds.
> 
> The I8K_FAN_30A3_31A3 SMM code pair works on this machine through the
> WMI-SMM backend: after writing 1 to pwm1_enable, the fan accepts all
> three fan states (0, 128 and 255 via pwm1) and reports matching RPM,
> and writing 2 hands control back to the BIOS.
> 
> Tested on BIOS 1.8.1 with kernel 7.1.5 (Pop!_OS 24.04).
> 
> Assisted-by: claude-opus-5-5
> Signed-off-by: Emanuel Ávila <avilaemanueel@gmail.com>

Acked-by: Pali Rohár <pali@kernel.org>

> ---
>  drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index 99a58ed26..88837f028 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1679,6 +1679,14 @@ static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
>  		},
>  		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_30A3_31A3],
>  	},
> +	{
> +		.ident = "Dell 16 DC16250",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell 16 DC16250"),
> +		},
> +		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_30A3_31A3],
> +	},
>  	{ }
>  };
>  
> -- 
> 2.43.0
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] hwmon: (dell-smm) Add Dell 16 DC16250 to fan control whitelist
  2026-09-24  4:48 [PATCH] hwmon: (dell-smm) Add Dell 16 DC16250 to fan control whitelist Emanuel Ávila
  2026-09-24  4:51 ` sashiko-bot
  2026-09-24  8:11 ` Pali Rohár
@ 2026-09-24 16:49 ` Guenter Roeck
  2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2026-09-24 16:49 UTC (permalink / raw)
  To: Emanuel Ávila; +Cc: Pali Rohár, linux-hwmon, linux-kernel

On Thu, Sep 24, 2026 at 01:48:29AM -0300, Emanuel Ávila wrote:
> On the Dell 16 DC16250, the BIOS keeps the CPU fan at its highest state
> (~4700 RPM) even when the system is idle at 45 °C, and fan speed writes
> through pwm1 are overridden by the BIOS within a few seconds.
> 
> The I8K_FAN_30A3_31A3 SMM code pair works on this machine through the
> WMI-SMM backend: after writing 1 to pwm1_enable, the fan accepts all
> three fan states (0, 128 and 255 via pwm1) and reports matching RPM,
> and writing 2 hands control back to the BIOS.
> 
> Tested on BIOS 1.8.1 with kernel 7.1.5 (Pop!_OS 24.04).
> 
> Assisted-by: claude-opus-5-5
> Signed-off-by: Emanuel Ávila <avilaemanueel@gmail.com>
> Acked-by: Pali Rohár <pali@kernel.org>

Applied.

Thanks,
Guenter

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-09-24 16:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-24  4:48 [PATCH] hwmon: (dell-smm) Add Dell 16 DC16250 to fan control whitelist Emanuel Ávila
2026-09-24  4:51 ` sashiko-bot
2026-09-24  8:11 ` Pali Rohár
2026-09-24 16:49 ` Guenter Roeck

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.