Re: [PATCH v1 6/7] ARM: tegra: lg-x3: Add haptic engine node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: missing dt-binding schema for Imagis ISA1200 haptic engine
--

commit bcc2e5a5981cf130d7fde2c4cf8724ed6f15c474
Author: Svyatoslav Ryhel <clamor95@gmail.com>

ARM: tegra: lg-x3: Add haptic engine node

This commit adds a device tree node for the Imagis ISA1200 haptic motor
driver used in the tegra30-lg-x3 device.

> diff --git a/arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi b/arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi
> index 14d4f992222c6..c7ad3819c21d9 100644
> --- a/arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi
> +++ b/arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi
> @@ -1568,6 +1568,30 @@ power-sensor@40 {
>  			vs-supply = <&vdd_3v0_sen>;
>  		};
>  
> +		haptic-engine@49 {
> +			compatible = "imagis,isa1200";
> +			reg = <0x49>;
> +
> +			control-gpios = <&gpio TEGRA_GPIO(H, 1) GPIO_ACTIVE_HIGH>;
> +
> +			pwms = <&pwm 3 53000>;
> +
> +			vdd-supply = <&vdd_3v3_vbat>;
> +			vddp-supply = <&vdd_1v8_vio>;
> +
> +			imagis,clk-div = <128>;
> +			imagis,pll-div = <1>;
> +
> +			imagis,mode = <0>; /* LRA_MODE */
> +			imagis,duty-cycle-ns = <1250>;
> +
> +			ldo {
> +				regulator-name = "vdd_vib";
> +				regulator-min-microvolt = <2300000>;
> +				regulator-max-microvolt = <2300000>;
> +			};
> +		};

[Severity: Medium]
Are the dt-binding schema and the driver for the "imagis,isa1200" compatible
string missing?

There appears to be no dt-binding schema (YAML or txt) documenting these
custom vendor properties (e.g., "imagis,clk-div", "imagis,mode") or the "ldo"
subnode, nor a driver that matches this compatible.

Adding undocumented properties and using magic values (e.g.,
`<0> /* LRA_MODE */` instead of a dt-binding macro) violates device tree
standards, causes `make dtbs_check` validation failures, and establishes an
unreviewed ABI.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924090608.28734-1-clamor95@gmail.com?part=6