Re: [PATCH i-g-t v4 03/13] drm/xe/hwmon: Fix memory controller thermal data handling

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] doc: typo in struct xe_hwmon_thermal_info kernel-doc causes warning
--

commit 871f56e42943cda8c6cef9e6c91e26476b403061
Author: Karthik Poosa <karthik.poosa@intel.com>

drm/xe/hwmon: Fix memory controller thermal data handling

This commit updates get_mc_temp() to read all required thermal groups and
introduces an aligned u32 buffer for PCODE accesses. This avoids unaligned
memory accesses and ensures accurate MC temperature reporting.

> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
> index d82da9be9e5b1..658b6902af7f8 100644
> --- a/drivers/gpu/drm/xe/xe_hwmon.c
> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
> @@ -143,8 +143,12 @@ struct xe_hwmon_thermal_info {
>  	};
>  	/** @count: no of temperature sensors available for the platform */
>  	u8 count;
> -	/** @value: per-sensor raw mailbox temperature; bit7=sign, bits6:0=magnitude */
> -	u8 value[U8_MAX];
> +	union {
> +		/** @vavlue: per-sensor raw mailbox temperature; bit7=sign, bits6:0=magnitude */

[Severity: Low]
This isn't a bug, but there is a typo in the struct member documentation
(vavlue instead of value) for xe_hwmon_thermal_info. This mismatch will
cause documentation generation tools like scripts/kernel-doc to emit warnings.

> +		u8 value[U8_MAX + 1];
> +		/** @dword: sensor values as dwords, u32-aligned for pcode reads */
> +		u32 dword[DIV_ROUND_UP(U8_MAX + 1, sizeof(u32))];
> +	};
>  	/** @vram_label: vram label names */
>  	char vram_label[MAX_VRAM_CHANNELS][MAX_LABEL_SIZE];
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924105000.2627929-1-karthik.poosa@intel.com?part=3