Re: [PATCH net-next v15 4/9] dt-bindings: net: qcom: document the ethqos device for SCMI-based systems - sashiko-bot

From: sashiko-bot@kernel.org
To: "Bartosz Golaszewski" <bartosz.golaszewski@oss.qualcomm.com>
Cc: robh@kernel.org, linux-amlogic@lists.infradead.org,
	neil.armstrong@linaro.org, wsa+renesas@sang-engineering.com,
	conor+dt@kernel.org, linux-sunxi@lists.linux.dev,
	Frank.Li@kernel.org, imx@lists.linux.dev,
	devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v15 4/9] dt-bindings: net: qcom: document the ethqos device for SCMI-based systems
Date: Thu, 24 Sep 2026 15:15:39 +0000	[thread overview]
Message-ID: <20260924151539.CE6971F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260923-qcom-sa8255p-emac-v15-4-e82f33720737@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: ultrarisc,dp1000-gmac: missing power-domains maxItems constraint
--

commit e30cc0626178117fbbeeed38ffe455db15d4973b
Author: Bartosz Golaszewski <brgl@kernel.org>

dt-bindings: net: qcom: document the ethqos device for SCMI-based systems

Describe the firmware-managed variant of the QCom DesignWare MAC. As the
properties here differ a lot from the HLOS-managed variant, lets put it
in a separate file. Since we need to update the maximum number of power
domains, let's update existing bindings referencing the top-level
snps,dwmac.yaml and limit their maxItems for power-domains to 1.

> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 0ff9e3284a061..1f2ee684dc391 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml

[ ... ]

> @@ -186,7 +187,8 @@ properties:
>            - enum: [ahb, stmmaceth-ocp]
>  
>    power-domains:
> -    maxItems: 1
> +    minItems: 1
> +    maxItems: 2
>  
>    mac-mode:
>      $ref: ethernet-controller.yaml#/properties/phy-connection-type

[Severity: Low]
Does this unintentionally relax validation for the ultrarisc,dp1000-gmac
compatible string?

The commit message mentions updating existing bindings that reference
snps,dwmac.yaml to limit power-domains maxItems to 1. However, it appears
Documentation/devicetree/bindings/net/ultrarisc,dp1000-gmac.yaml is missing
a local override and will now inherit this new maxItems: 2 constraint.

Should ultrarisc,dp1000-gmac.yaml also be updated to limit maxItems to 1?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923-qcom-sa8255p-emac-v15-0-e82f33720737@oss.qualcomm.com?part=4