All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <kees@kernel.org>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: mark.rutland@arm.com, peterz@infradead.org,
	catalin.marinas@arm.com, linux-kernel@vger.kernel.org,
	will@kernel.org, thuth@redhat.com, vladimir.murzin@arm.com,
	ryan.roberts@arm.com, anshuman.khandual@arm.com,
	kevin.brodsky@arm.com, kmehltretter@gmail.com,
	pengcan@kylinos.cn, broonie@kernel.org,
	linux-arm-kernel@lists.infradead.org, wad@chromium.org,
	linusw@kernel.org, oleg@redhat.com, luto@amacapital.net,
	james.morse@arm.com, tglx@kernel.org, liqiang01@kylinos.cn,
	yeoreum.yun@arm.com
Subject: Re: [PATCH v19 00/14] arm64: entry: Convert to Generic Entry
Date: Thu, 24 Sep 2026 17:05:49 -0700	[thread overview]
Message-ID: <202609241703.4AF69048@keescook> (raw)
In-Reply-To: <927d57a4-64ab-4420-9485-5336f2ec3fd5@huawei.com>

On Thu, Sep 24, 2026 at 05:32:14PM +0800, Jinjie Ruan wrote:
> 在 2026/9/23 2:29, Kees Cook 写道:
> I tested the rr test cases on a Kunpeng HIP09 (with minor adaptations,
> since Kunpeng CPUs aren't supported by default), and the results showed
> no regressions.

Great! Thank you for getting that set up.

> 
> |               |    7.3-rc4 baseline     |   Patched                 |
> 
> |  ------------ |------------------------ | ------------------------- |
> |   result      |  87% passed, 190 failed |   88% passed, 186 failed  |
> 
> 
> | Failure Mode   | 7.3-rc4 baseline |   Patched  |
> | ------------   | ---------------- | ---------- |
> | TICK_MISMATCH  |         76       |   74       |
> | TIMEOUT        |         68       |   65       |
> | GDB_SCRIPT     |         34       |   37       |
> | PERF_EVENT_OPEN|         3        |   2        |
> |   OVERSHOOT    |         1        |   0        |
> |    OTHER       |         8        |   8        |
> | -------------- |  --------------- | ---------- |
> |  Total         |      190         |   186      |

GDB_SCRIPT failures went up? Are the tests just flaky?

> > - MTE: I didn't see MTE in the cover letter's test list, and it seems
> >   relevant since patch 13 puts _TIF_MTE_ASYNC_FAULT into
> >   ARCH_EXIT_TO_USER_MODE_WORK, so an async tag check fault lands
> >   on the reworked exit path. The MTE selftests showed no differences,
> >   but a third of them don't actually run for me under QEMU, so they'd
> >   be worth running on your hardware. (Testing MTE under QEMU saw
> 
> Turns out our arm64 machines don't support MTE; I was testing it on QEMU.

Ah, dang. I wonder if we can find anyone with MTE hardware to test this.
Any volunteers? :)

-Kees

-- 
Kees Cook


  reply	other threads:[~2026-09-25  0:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22  3:54 [PATCH v19 00/14] arm64: entry: Convert to Generic Entry Jinjie Ruan
2026-09-22  3:54 ` [PATCH v19 01/14] arm64: ptrace: Fix redundant syscall exit stop for PTRACE_SYSEMU_SINGLESTEP Jinjie Ruan
2026-09-23  8:28   ` Jinjie Ruan
2026-09-22  3:54 ` [PATCH v19 02/14] arm64: ptrace: Rework audit_syscall_entry() Jinjie Ruan
2026-09-22  3:54 ` [PATCH v19 03/14] arm64: ptrace: Open-code seccomp check in syscall_trace_enter() Jinjie Ruan
2026-09-22  3:55 ` [PATCH v19 04/14] arm64: ptrace: Rename and clean up syscall_trace_enter() Jinjie Ruan
2026-09-22  3:55 ` [PATCH v19 05/14] arm64: ptrace: Protect rseq_syscall() from tracer PC modifications Jinjie Ruan
2026-09-22  3:55 ` [PATCH v19 06/14] arm64: syscall: Rework the syscall exit path in el0_svc_common() Jinjie Ruan
2026-09-22  3:55 ` [PATCH v19 07/14] arm64: ptrace: Pass thread flags to trace enter/exit Jinjie Ruan
2026-09-22  3:55 ` [PATCH v19 08/14] arm64: ptrace: Extract arm64_syscall_exit_to_user_mode_work() helper Jinjie Ruan
2026-09-22  3:55 ` [PATCH v19 09/14] arm64: ptrace: Align syscall exit work semantics with generic entry Jinjie Ruan
2026-09-22  3:55 ` [PATCH v19 10/14] arm64: syscall: Use exit-specific flags check in el0_svc_common() Jinjie Ruan
2026-09-22  3:55 ` [PATCH v19 11/14] arm64: syscall: Simplify el0_svc_common() syscall exit path Jinjie Ruan
2026-09-22  3:55 ` [PATCH v19 12/14] arm64: ptrace: Make return type of arm64_syscall_trace_enter() bool Jinjie Ruan
2026-09-22  3:55 ` [PATCH v19 13/14] arm64: entry: Convert to generic entry Jinjie Ruan
2026-09-22  3:55 ` [PATCH v19 14/14] arm64: Inline el0_svc_common() Jinjie Ruan
2026-09-22 18:29 ` [PATCH v19 00/14] arm64: entry: Convert to Generic Entry Kees Cook
2026-09-24  9:32   ` Jinjie Ruan
2026-09-25  0:05     ` Kees Cook [this message]
2026-09-28  1:50       ` Jinjie Ruan
2026-09-30  6:51   ` Jinjie Ruan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202609241703.4AF69048@keescook \
    --to=kees@kernel.org \
    --cc=anshuman.khandual@arm.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=james.morse@arm.com \
    --cc=kevin.brodsky@arm.com \
    --cc=kmehltretter@gmail.com \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liqiang01@kylinos.cn \
    --cc=luto@amacapital.net \
    --cc=mark.rutland@arm.com \
    --cc=oleg@redhat.com \
    --cc=pengcan@kylinos.cn \
    --cc=peterz@infradead.org \
    --cc=ruanjinjie@huawei.com \
    --cc=ryan.roberts@arm.com \
    --cc=tglx@kernel.org \
    --cc=thuth@redhat.com \
    --cc=vladimir.murzin@arm.com \
    --cc=wad@chromium.org \
    --cc=will@kernel.org \
    --cc=yeoreum.yun@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.