Re: [PATCH 3/8] mtd: rawnand: qcom: make config_nand_page_write() more generic - sashiko-bot

From: sashiko-bot@kernel.org
To: "Richard Weinberger" <richard@nod.at>,
	"Gabor Juhos" <j4g8y7@gmail.com>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>
Cc: linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Md Sadre Alam" <md.alam@oss.qualcomm.com>
Subject: Re: [PATCH 3/8] mtd: rawnand: qcom: make config_nand_page_write() more generic
Date: Thu, 24 Sep 2026 20:09:52 +0000	[thread overview]
Message-ID: <20260924200952.747331F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260924-qcom_nandc-share-more-code-v1-3-f3012199b161@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] mtd: commit message claims qpic_nandc prefix but applies qcom_nandc
--

commit 2cd47b90aa23e587aa720b2d04c9ca024d8178d5
Author: Gabor Juhos <j4g8y7@gmail.com>

mtd: rawnand: qcom: make config_nand_page_write() more generic

This commit updates config_nand_page_write() to take a pointer to the
qcom_nand_controller directly instead of extracting it from nand_chip.
It also renames the function to prepare for future code reuse.

>     In order to make the function more generic, change the declaration
>     to get a 'qcom_nandc_controller' pointer directly, and update the
>     callers accordingly. While at it, also change the function name to
>     use a 'qpic_nandc' prefix.

[Severity: Medium]
This isn't a bug introduced by this patch, but there is a discrepancy between
the commit message and the actual code changes. The commit message states the
function is being renamed to use a 'qpic_nandc' prefix, but as seen below, it
is actually renamed to qcom_nandc_config_page_write() using a 'qcom_nandc'
prefix. 

Could the commit message be updated to match the code, or should the code be
updated to use the intended prefix?

> diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c
> index c65a8416c3f5d..1f3c00823309f 100644
> --- a/drivers/mtd/nand/raw/qcom_nandc.c
> +++ b/drivers/mtd/nand/raw/qcom_nandc.c
> @@ -365,10 +365,8 @@ config_nand_single_cw_page_read(struct nand_chip *chip,
>   * Helper to prepare DMA descriptors used to configure registers needed for
>   * before writing a NAND page.
>   */
> -static void config_nand_page_write(struct nand_chip *chip)
> +static void qcom_nandc_config_page_write(struct qcom_nand_controller *nandc)
>  {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924-qcom_nandc-share-more-code-v1-0-f3012199b161@gmail.com?part=3

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/