Re: [PATCH 2/8] mtd: rawnand: qcom: make config_nand_page_read() more generic - sashiko-bot

From: sashiko-bot@kernel.org
To: "Richard Weinberger" <richard@nod.at>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Gabor Juhos" <j4g8y7@gmail.com>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Vignesh Raghavendra" <vigneshr@ti.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	"Md Sadre Alam" <md.alam@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/8] mtd: rawnand: qcom: make config_nand_page_read() more generic
Date: Thu, 24 Sep 2026 20:10:54 +0000	[thread overview]
Message-ID: <20260924201055.1E5051F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260924-qcom_nandc-share-more-code-v1-2-f3012199b161@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] mtd: code and commit message mismatch in config_nand_page_read() changes
--

commit 83713aed92ebeefb24101c6bd3b2c47c7e4e9dfd
Author: Gabor Juhos <j4g8y7@gmail.com>

mtd: rawnand: qcom: make config_nand_page_read() more generic

This commit modifies config_nand_page_read() to take a controller pointer
directly instead of a nand_chip pointer. It updates the callers accordingly
and renames the function to prepare for future reuse.

> In order to make the function more generic, change the declaration
> to get a 'qcom_nandc_controller' pointer directly, and update the
> callers accordingly. While at it, also change the function name to
> use a 'qpic_nandc' prefix.

[Severity: Medium]
Does the commit message accurately reflect the changes made in the patch?

The commit message mentions changing the parameter to a 'qcom_nandc_controller'
pointer and using a 'qpic_nandc' prefix for the function name. However, the
code uses a 'struct qcom_nand_controller *' pointer and names the function
qcom_nandc_config_page_read():

> diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c
> index 12bfb14cd9a37..c65a8416c3f5d 100644
> --- a/drivers/mtd/nand/raw/qcom_nandc.c
> +++ b/drivers/mtd/nand/raw/qcom_nandc.c
[ ... ]
> @@ -305,10 +305,8 @@ static void update_rw_regs(struct qcom_nand_host *host, int num_cw, bool read, i
>   * Helper to prepare DMA descriptors for configuring registers
>   * before reading a NAND page.
>   */
> -static void config_nand_page_read(struct nand_chip *chip)
> +static void qcom_nandc_config_page_read(struct qcom_nand_controller *nandc)
>  {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924-qcom_nandc-share-more-code-v1-0-f3012199b161@gmail.com?part=2

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/