Re: [PATCH 07/16] efi/zboot: Lift efi_cache_sync_image() from efi_zboot_decompress()

From: Jason Gunthorpe <jgg@nvidia.com>
To: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
Cc: Alexandre Ghiti <alex@ghiti.fr>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Ard Biesheuvel <ardb@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Jonathan Corbet <corbet@lwn.net>, David Sterba <dsterba@suse.com>,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-doc@vger.kernel.org, linux-efi@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	Mark Rutland <mark.rutland@arm.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Walmsley <pjw@kernel.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Simon Glass <sjg@chromium.org>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Nick Terrell <terrelln@fb.com>, Will Deacon <will@kernel.org>,
	Alexandre Ghiti <alexghiti@rivosinc.com>,
	Conor Dooley <conor.dooley@microchip.com>,
	linux-integrity@vger.kernel.org,
	Palmer Dabbelt <palmer@rivosinc.com>,
	patches@lists.linux.dev,
	Ross Philipson <ross.philipson@gmail.com>,
	Sami Tolvanen <samitolvanen@google.com>,
	Song Shuai <songshuaishuai@tinylab.org>
Subject: Re: [PATCH 07/16] efi/zboot: Lift efi_cache_sync_image() from efi_zboot_decompress()
Date: Thu, 24 Sep 2026 20:53:02 -0300	[thread overview]
Message-ID: <20260924235302.GF9354@nvidia.com> (raw)
In-Reply-To: <20260924155721.000016a9@oss.qualcomm.com>

On Thu, Sep 24, 2026 at 03:57:21PM -0700, Jonathan Cameron wrote:
> On Thu, 24 Sep 2026 10:53:10 -0300
> Jason Gunthorpe <jgg@nvidia.com> wrote:
> 
> > The two decompressors duplicate this call and the next patch needs to
> > change the argument. Hoist it up to remove the duplication.
> > 
> > Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> 
> > diff --git a/drivers/firmware/efi/libstub/zboot.c b/drivers/firmware/efi/libstub/zboot.c
> > index 4b76f74c56dae0..960a542881d875 100644
> > --- a/drivers/firmware/efi/libstub/zboot.c
> > +++ b/drivers/firmware/efi/libstub/zboot.c
> > @@ -92,9 +92,12 @@ efi_zboot_entry(efi_handle_t handle, efi_system_table_t *systab)
> >  	}
> >  
> >  	// Decompress the payload into the newly allocated buffer
> > -	status = efi_zboot_decompress((void *)image_base, alloc_size) ?:
> > -	         efi_stub_common(handle, image, image_base, cmdline_ptr);
> > -
> > +	status = efi_zboot_decompress((void *)image_base, alloc_size);
> > +	if (status == EFI_SUCCESS) {
> > +		efi_cache_sync_image(image_base, alloc_size);
> > +		status =
> > +			efi_stub_common(handle, image, image_base, cmdline_ptr);
> 
> Just go one character longer!

OK! You have good eyes to notice that! I use clang-format and stopped
caring! The flexible 80 unless you need it unless you are in the wrong
subsystem scares me!

Thanks,
Jason