All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Reeves via B4 Relay <devnull+michael.reeves077.gmail.com@kernel.org>
To: Arend van Spriel <arend.vanspriel@broadcom.com>,
	 Pieter-Paul Giesberts <pieterpg@broadcom.com>,
	 "Franky Lin (Zhenhui)" <frankyl@broadcom.com>,
	 Mathy Vanhoef <vanhoefm@gmail.com>,
	Kalle Valo <kvalo@kernel.org>,  Kees Cook <kees@kernel.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
	 brcm80211-dev-list.pdl@broadcom.com, asahi@lists.linux.dev,
	 Hector Martin <marcan@marcan.st>,
	Daniel Berlin <dberlin@dberlin.org>,  Janne Grunau <j@jannau.net>,
	linux-kernel@vger.kernel.org,
	 Hante Meuleman <meuleman@broadcom.com>,
	linux-hardening@vger.kernel.org,
	 Michael Reeves <michael.reeves077@gmail.com>
Subject: [PATCH 00/13] wifi: brcmfmac: Add BCM4388 support
Date: Fri, 25 Sep 2026 23:43:35 +1000	[thread overview]
Message-ID: <20260925-brcm4388-submit-v1-0-b5cbc2cde2fb@gmail.com> (raw)

The Broadcom BCM4388 chipset requires new PCIe initialization and
firmware interfaces. Add support for these interfaces to brcmfmac to
enable basic station operation.

This series adds:
- Signed firmware loading and mailbox transport
- Fixes for chip identification and firmware capability matching
- Versioned scan and join requests, and extended PMK payloads
- Updated event mask handling

These changes include work by Hector Martin and Daniel Berlin from Asahi
Linux, refactored where needed for upstream inclusion.

The series provides basic station support only. 6 GHz support is planned
for a follow-up patchset after this lands. The driver retains legacy
interfaces for older firmware.

Tested on an Apple M3 MacBook Air (J613):
- Device boot and network scanning
- 5 GHz WPA2-PSK association and DHCP
- Bidirectional TCP traffic

Testing required separate Apple PCIe and devicetree patches, as well as
Janne Grunau's port-authorization fix [1].

[1] https://lore.kernel.org/linux-wireless/20260915-brcmfmac-4way-handshake-offload-authenticated-event-v2-1-fbb9cc7ac177@jannau.net/

---
Daniel Berlin (1):
      wifi: brcmfmac: Support versioned scan parameter layouts

Hector Martin (6):
      wifi: brcmfmac: Support newer PCIe core startup and interrupts
      wifi: brcmfmac: Negotiate PCIe mailbox transport with firmware
      wifi: brcmfmac: Load signed PCIe firmware images
      wifi: brcmfmac: Accept newer BSS information versions
      wifi: brcmfmac: Support versioned join requests
      wifi: brcmfmac: Add BCM4388 support

Michael Reeves (6):
      wifi: brcmfmac: pcie: Report the detected chip ID to the bus
      wifi: brcmfmac: Match complete firmware capability names
      wifi: brcmfmac: Fall back to RSSI-only default join preferences
      wifi: brcmfmac: Use event_msgs_ext for event masks
      wifi: brcmfmac: Handle larger firmware band lists
      wifi: brcmfmac: Handle extended PMK command payloads

 .../wireless/broadcom/brcm80211/brcmfmac/Makefile  |   1 +
 .../net/wireless/broadcom/brcm80211/brcmfmac/bus.h |   9 +
 .../broadcom/brcm80211/brcmfmac/cfg80211.c         | 368 +++++++-------
 .../wireless/broadcom/brcm80211/brcmfmac/chip.c    |  36 +-
 .../wireless/broadcom/brcm80211/brcmfmac/common.c  |  27 +-
 .../wireless/broadcom/brcm80211/brcmfmac/core.c    |   5 +-
 .../wireless/broadcom/brcm80211/brcmfmac/core.h    |  18 +
 .../wireless/broadcom/brcm80211/brcmfmac/feature.c | 124 ++++-
 .../wireless/broadcom/brcm80211/brcmfmac/feature.h |   2 +
 .../wireless/broadcom/brcm80211/brcmfmac/fweh.c    | 130 ++++-
 .../wireless/broadcom/brcm80211/brcmfmac/fweh.h    |   1 +
 .../broadcom/brcm80211/brcmfmac/fwil_types.h       | 141 +++++-
 .../wireless/broadcom/brcm80211/brcmfmac/msgbuf.c  |  65 ++-
 .../wireless/broadcom/brcm80211/brcmfmac/msgbuf.h  |   9 +-
 .../wireless/broadcom/brcm80211/brcmfmac/pcie.c    | 560 +++++++++++++++++----
 .../broadcom/brcm80211/brcmfmac/scan_param.c       | 416 +++++++++++++++
 .../broadcom/brcm80211/brcmfmac/scan_param.h       |  13 +
 .../broadcom/brcm80211/include/brcm_hw_ids.h       |   2 +
 .../broadcom/brcm80211/include/chipcommon.h        |   5 +
 19 files changed, 1593 insertions(+), 339 deletions(-)
---
base-commit: 42a9fb3382fc2573e92f41d203b095d9a372cfc9
change-id: 20260925-brcm4388-submit-5cb8d3e6d6a5

Best regards,
-- 
Michael Reeves <michael.reeves077@gmail.com>



WARNING: multiple messages have this Message-ID (diff)
From: Michael Reeves <michael.reeves077@gmail.com>
To: Arend van Spriel <arend.vanspriel@broadcom.com>,
	 Pieter-Paul Giesberts <pieterpg@broadcom.com>,
	 "Franky Lin (Zhenhui)" <frankyl@broadcom.com>,
	 Mathy Vanhoef <vanhoefm@gmail.com>,
	Kalle Valo <kvalo@kernel.org>,  Kees Cook <kees@kernel.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
	 brcm80211-dev-list.pdl@broadcom.com, asahi@lists.linux.dev,
	 Hector Martin <marcan@marcan.st>,
	Daniel Berlin <dberlin@dberlin.org>,  Janne Grunau <j@jannau.net>,
	linux-kernel@vger.kernel.org,
	 Hante Meuleman <meuleman@broadcom.com>,
	linux-hardening@vger.kernel.org,
	 Michael Reeves <michael.reeves077@gmail.com>
Subject: [PATCH 00/13] wifi: brcmfmac: Add BCM4388 support
Date: Fri, 25 Sep 2026 23:43:35 +1000	[thread overview]
Message-ID: <20260925-brcm4388-submit-v1-0-b5cbc2cde2fb@gmail.com> (raw)

The Broadcom BCM4388 chipset requires new PCIe initialization and
firmware interfaces. Add support for these interfaces to brcmfmac to
enable basic station operation.

This series adds:
- Signed firmware loading and mailbox transport
- Fixes for chip identification and firmware capability matching
- Versioned scan and join requests, and extended PMK payloads
- Updated event mask handling

These changes include work by Hector Martin and Daniel Berlin from Asahi
Linux, refactored where needed for upstream inclusion.

The series provides basic station support only. 6 GHz support is planned
for a follow-up patchset after this lands. The driver retains legacy
interfaces for older firmware.

Tested on an Apple M3 MacBook Air (J613):
- Device boot and network scanning
- 5 GHz WPA2-PSK association and DHCP
- Bidirectional TCP traffic

Testing required separate Apple PCIe and devicetree patches, as well as
Janne Grunau's port-authorization fix [1].

[1] https://lore.kernel.org/linux-wireless/20260915-brcmfmac-4way-handshake-offload-authenticated-event-v2-1-fbb9cc7ac177@jannau.net/

---
Daniel Berlin (1):
      wifi: brcmfmac: Support versioned scan parameter layouts

Hector Martin (6):
      wifi: brcmfmac: Support newer PCIe core startup and interrupts
      wifi: brcmfmac: Negotiate PCIe mailbox transport with firmware
      wifi: brcmfmac: Load signed PCIe firmware images
      wifi: brcmfmac: Accept newer BSS information versions
      wifi: brcmfmac: Support versioned join requests
      wifi: brcmfmac: Add BCM4388 support

Michael Reeves (6):
      wifi: brcmfmac: pcie: Report the detected chip ID to the bus
      wifi: brcmfmac: Match complete firmware capability names
      wifi: brcmfmac: Fall back to RSSI-only default join preferences
      wifi: brcmfmac: Use event_msgs_ext for event masks
      wifi: brcmfmac: Handle larger firmware band lists
      wifi: brcmfmac: Handle extended PMK command payloads

 .../wireless/broadcom/brcm80211/brcmfmac/Makefile  |   1 +
 .../net/wireless/broadcom/brcm80211/brcmfmac/bus.h |   9 +
 .../broadcom/brcm80211/brcmfmac/cfg80211.c         | 368 +++++++-------
 .../wireless/broadcom/brcm80211/brcmfmac/chip.c    |  36 +-
 .../wireless/broadcom/brcm80211/brcmfmac/common.c  |  27 +-
 .../wireless/broadcom/brcm80211/brcmfmac/core.c    |   5 +-
 .../wireless/broadcom/brcm80211/brcmfmac/core.h    |  18 +
 .../wireless/broadcom/brcm80211/brcmfmac/feature.c | 124 ++++-
 .../wireless/broadcom/brcm80211/brcmfmac/feature.h |   2 +
 .../wireless/broadcom/brcm80211/brcmfmac/fweh.c    | 130 ++++-
 .../wireless/broadcom/brcm80211/brcmfmac/fweh.h    |   1 +
 .../broadcom/brcm80211/brcmfmac/fwil_types.h       | 141 +++++-
 .../wireless/broadcom/brcm80211/brcmfmac/msgbuf.c  |  65 ++-
 .../wireless/broadcom/brcm80211/brcmfmac/msgbuf.h  |   9 +-
 .../wireless/broadcom/brcm80211/brcmfmac/pcie.c    | 560 +++++++++++++++++----
 .../broadcom/brcm80211/brcmfmac/scan_param.c       | 416 +++++++++++++++
 .../broadcom/brcm80211/brcmfmac/scan_param.h       |  13 +
 .../broadcom/brcm80211/include/brcm_hw_ids.h       |   2 +
 .../broadcom/brcm80211/include/chipcommon.h        |   5 +
 19 files changed, 1593 insertions(+), 339 deletions(-)
---
base-commit: 42a9fb3382fc2573e92f41d203b095d9a372cfc9
change-id: 20260925-brcm4388-submit-5cb8d3e6d6a5

Best regards,
-- 
Michael Reeves <michael.reeves077@gmail.com>


             reply	other threads:[~2026-09-25 13:43 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-25 13:43 Michael Reeves via B4 Relay [this message]
2026-09-25 13:43 ` [PATCH 00/13] wifi: brcmfmac: Add BCM4388 support Michael Reeves
2026-09-25 13:43 ` [PATCH 01/13] wifi: brcmfmac: pcie: Report the detected chip ID to the bus Michael Reeves via B4 Relay
2026-09-25 13:43   ` Michael Reeves
2026-09-25 13:43 ` [PATCH 02/13] wifi: brcmfmac: Match complete firmware capability names Michael Reeves via B4 Relay
2026-09-25 13:43   ` Michael Reeves
2026-09-25 13:43 ` [PATCH 03/13] wifi: brcmfmac: Fall back to RSSI-only default join preferences Michael Reeves via B4 Relay
2026-09-25 13:43   ` Michael Reeves
2026-09-25 13:43 ` [PATCH 04/13] wifi: brcmfmac: Support newer PCIe core startup and interrupts Michael Reeves via B4 Relay
2026-09-25 13:43   ` Michael Reeves
2026-09-25 13:43 ` [PATCH 05/13] wifi: brcmfmac: Negotiate PCIe mailbox transport with firmware Michael Reeves via B4 Relay
2026-09-25 13:43   ` Michael Reeves
2026-09-25 13:43 ` [PATCH 06/13] wifi: brcmfmac: Load signed PCIe firmware images Michael Reeves via B4 Relay
2026-09-25 13:43   ` Michael Reeves
2026-09-25 13:43 ` [PATCH 07/13] wifi: brcmfmac: Use event_msgs_ext for event masks Michael Reeves via B4 Relay
2026-09-25 13:43   ` Michael Reeves
2026-09-25 13:43 ` [PATCH 08/13] wifi: brcmfmac: Handle larger firmware band lists Michael Reeves via B4 Relay
2026-09-25 13:43   ` Michael Reeves
2026-09-25 13:43 ` [PATCH 09/13] wifi: brcmfmac: Accept newer BSS information versions Michael Reeves via B4 Relay
2026-09-25 13:43   ` Michael Reeves
2026-09-25 13:43 ` [PATCH 10/13] wifi: brcmfmac: Support versioned scan parameter layouts Michael Reeves via B4 Relay
2026-09-25 13:43   ` Michael Reeves
2026-09-25 13:43 ` [PATCH 11/13] wifi: brcmfmac: Support versioned join requests Michael Reeves via B4 Relay
2026-09-25 13:43   ` Michael Reeves
2026-09-25 13:43 ` [PATCH 12/13] wifi: brcmfmac: Handle extended PMK command payloads Michael Reeves via B4 Relay
2026-09-25 13:43   ` Michael Reeves
2026-09-25 13:43 ` [PATCH 13/13] wifi: brcmfmac: Add BCM4388 support Michael Reeves via B4 Relay
2026-09-25 13:43   ` Michael Reeves
2026-10-07 12:54 ` [PATCH 00/13] " Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260925-brcm4388-submit-v1-0-b5cbc2cde2fb@gmail.com \
    --to=devnull+michael.reeves077.gmail.com@kernel.org \
    --cc=arend.vanspriel@broadcom.com \
    --cc=asahi@lists.linux.dev \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brcm80211@lists.linux.dev \
    --cc=dberlin@dberlin.org \
    --cc=frankyl@broadcom.com \
    --cc=gustavoars@kernel.org \
    --cc=j@jannau.net \
    --cc=kees@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=meuleman@broadcom.com \
    --cc=michael.reeves077@gmail.com \
    --cc=pieterpg@broadcom.com \
    --cc=vanhoefm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.