Re: [PATCH RFC 09/11] iommu/arm-smmu: Add arm-smmu IRQ mapping -EPROBE_DEFER handling

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] arm-smmu: double error logging via dev_err_probe() on platform_get_irq()
--

commit 6a3f1d6f12231474463a3b68ee6dc2b63bbcba7f
Author: Lorenzo Pieralisi <lpieralisi@kernel.org>
Subject: iommu/arm-smmu: Add arm-smmu IRQ mapping -EPROBE_DEFER handling

This commit adds EPROBE_DEFER handling to the arm-smmu IRQ mapping code
to address cases where the interrupt controller is not yet probed when
the SMMU driver initializes.

> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.c b/drivers/iommu/arm/arm-smmu/arm-smmu.c
> index 889a0966d36cd..a111b80553dae 100644
> --- a/drivers/iommu/arm/arm-smmu/arm-smmu.c
> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu.c
[ ... ]
> @@ -2171,7 +2173,7 @@ static int arm_smmu_device_probe(struct platform_device *pdev)
>  		int irq = platform_get_irq(pdev, global_irqs + pmu_irqs + i);
>  
>  		if (irq < 0)
> -			return irq;
> +			return dev_err_probe(dev, irq, "failed to get context IRQ\n");

[Severity: Low]
Does wrapping platform_get_irq() with dev_err_probe() result in duplicate
error log messages?

Looking at platform_get_irq(), it already logs failures via dev_err_probe()
internally:

drivers/base/platform.c:platform_get_irq()
    ...
    ret = platform_get_irq_optional(dev, num);
    if (ret < 0)
        return dev_err_probe(&dev->dev, ret,
                             "IRQ index %u not found\n", num);

Returning the error directly might avoid redundant error strings.

>  		smmu->irqs[i] = irq;
>  	}
>  
> @@ -2211,7 +2213,7 @@ static int arm_smmu_device_probe(struct platform_device *pdev)
>  		int irq = platform_get_irq(pdev, i);
>  
>  		if (irq < 0)
> -			return irq;
> +			return dev_err_probe(dev, irq, "failed to get global IRQ\n");

[Severity: Low]
Similarly here, does this result in a duplicate error message when
platform_get_irq() fails?

>  
>  		err = devm_request_irq(dev, irq, global_fault, IRQF_SHARED,
>  				       "arm-smmu global fault", smmu);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925-acpi-static-table-irq-probe-defer-v1-0-2c62125d0085@kernel.org?part=9