Re: [PATCH RFC 03/11] driver core: platform: Add static ACPI nodes IRQ retrieval/mapping code

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] build: missing stub for is_acpi_static_node() without CONFIG_ACPI
--

commit b41affe79039335ffe21336e9e4a7ec0763dd61a
Author: Lorenzo Pieralisi <lpieralisi@kernel.org>

driver core: platform: Add static ACPI nodes IRQ retrieval/mapping code

This commit adds support for retrieving and mapping IRQs for static ACPI
fwnodes by modifying platform_get_irq_affinity() to call fwnode_irq_get().

> diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> index 66f9ec73d47e9..413c73332308e 100644
> --- a/drivers/base/platform.c
> +++ b/drivers/base/platform.c
> @@ -228,6 +228,12 @@ int platform_get_irq_affinity(struct platform_device *dev, unsigned int num,
>  		goto out;
>  	}
>  
> +	if (is_acpi_static_node(fwnode)) {

[Severity: Low]
Does this cause a build failure when CONFIG_ACPI is disabled?

It looks like is_acpi_static_node() is called unconditionally in
platform_get_irq_affinity(), but the definition in acpi/acpi_bus.h is
strictly guarded and only included when CONFIG_ACPI is enabled.

Should a stub for is_acpi_static_node() be added to linux/acpi.h in the
!CONFIG_ACPI block (similar to is_acpi_device_node()) to prevent an implicit
declaration error on non-ACPI configurations?

> +		ret = fwnode_irq_get(fwnode, num);
> +		if (ret > 0 || ret == -EPROBE_DEFER)
> +			goto out;
> +	}
> +
>  	/*
>  	 * For the index 0 interrupt, allow falling back to GpioInt

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925-acpi-static-table-irq-probe-defer-v1-0-2c62125d0085@kernel.org?part=3