All of lore.kernel.org
 help / color / mirror / Atom feed
* [iwl-next, v1] igc: Group frame size macros in igc_tsn.h
@ 2026-09-25 10:12 Sasha Neftin
  2026-09-25 10:27 ` Loktionov, Aleksandr
  0 siblings, 1 reply; 2+ messages in thread
From: Sasha Neftin @ 2026-09-25 10:12 UTC (permalink / raw)
  To: intel-wired-lan

Move the IGC_EMPTY_FRAME_SIZE definition from igc_main.c to igc_tsn.h.
This consolidates frame-size definitions for TSN and frame context
descriptors into a single header alongside IGC_RX_MIN_FRAG_SIZE and
SMD_FRAME_SIZE, making the constants available across TSN modules.

Signed-off-by: Sasha Neftin <sashaneftin@gmail.com>
---
 drivers/net/ethernet/intel/igc/igc_main.c | 2 --
 drivers/net/ethernet/intel/igc/igc_tsn.h  | 1 +
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index 1fb5f3cbe93c..b0a4c2893ccb 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -1137,8 +1137,6 @@ static void igc_init_tx_empty_descriptor(struct igc_ring *ring,
 		ring->next_to_use = 0;
 }
 
-#define IGC_EMPTY_FRAME_SIZE 60
-
 static void igc_tx_ctxtdesc(struct igc_ring *tx_ring,
 			    __le32 launch_time, bool first_flag,
 			    u32 vlan_macip_lens, u32 type_tucmd,
diff --git a/drivers/net/ethernet/intel/igc/igc_tsn.h b/drivers/net/ethernet/intel/igc/igc_tsn.h
index a95b893459d7..e08f48543d99 100644
--- a/drivers/net/ethernet/intel/igc/igc_tsn.h
+++ b/drivers/net/ethernet/intel/igc/igc_tsn.h
@@ -8,6 +8,7 @@
 
 #define IGC_RX_MIN_FRAG_SIZE		60
 #define SMD_FRAME_SIZE			60
+#define IGC_EMPTY_FRAME_SIZE		60
 
 enum igc_txd_popts_type {
 	SMD_V = 0x01,
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [iwl-next, v1] igc: Group frame size macros in igc_tsn.h
  2026-09-25 10:12 [iwl-next, v1] igc: Group frame size macros in igc_tsn.h Sasha Neftin
@ 2026-09-25 10:27 ` Loktionov, Aleksandr
  0 siblings, 0 replies; 2+ messages in thread
From: Loktionov, Aleksandr @ 2026-09-25 10:27 UTC (permalink / raw)
  To: Sasha Neftin, intel-wired-lan@osuosl.org



> -----Original Message-----
> From: Sasha Neftin <sashaneftin@gmail.com>
> Sent: Friday, September 25, 2026 12:12 PM
> To: intel-wired-lan@osuosl.org
> Subject: [iwl-next, v1] igc: Group frame size macros in igc_tsn.h
> 
> Move the IGC_EMPTY_FRAME_SIZE definition from igc_main.c to igc_tsn.h.
> This consolidates frame-size definitions for TSN and frame context
> descriptors into a single header alongside IGC_RX_MIN_FRAG_SIZE and
> SMD_FRAME_SIZE, making the constants available across TSN modules.
> 
> Signed-off-by: Sasha Neftin <sashaneftin@gmail.com>
> ---
>  drivers/net/ethernet/intel/igc/igc_main.c | 2 --
> drivers/net/ethernet/intel/igc/igc_tsn.h  | 1 +
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c
> b/drivers/net/ethernet/intel/igc/igc_main.c
> index 1fb5f3cbe93c..b0a4c2893ccb 100644
> --- a/drivers/net/ethernet/intel/igc/igc_main.c
> +++ b/drivers/net/ethernet/intel/igc/igc_main.c
> @@ -1137,8 +1137,6 @@ static void igc_init_tx_empty_descriptor(struct
> igc_ring *ring,
>  		ring->next_to_use = 0;
>  }
> 
> -#define IGC_EMPTY_FRAME_SIZE 60
> -
>  static void igc_tx_ctxtdesc(struct igc_ring *tx_ring,
>  			    __le32 launch_time, bool first_flag,
>  			    u32 vlan_macip_lens, u32 type_tucmd, diff --
> git a/drivers/net/ethernet/intel/igc/igc_tsn.h
> b/drivers/net/ethernet/intel/igc/igc_tsn.h
> index a95b893459d7..e08f48543d99 100644
> --- a/drivers/net/ethernet/intel/igc/igc_tsn.h
> +++ b/drivers/net/ethernet/intel/igc/igc_tsn.h
> @@ -8,6 +8,7 @@
> 
>  #define IGC_RX_MIN_FRAG_SIZE		60
>  #define SMD_FRAME_SIZE			60
> +#define IGC_EMPTY_FRAME_SIZE		60
> 
>  enum igc_txd_popts_type {
>  	SMD_V = 0x01,
> --
> 2.43.0

Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-25 10:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-25 10:12 [iwl-next, v1] igc: Group frame size macros in igc_tsn.h Sasha Neftin
2026-09-25 10:27 ` Loktionov, Aleksandr

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.