All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "David Heidelberg" <david@ixit.cz>
Cc: robh@kernel.org, mfd@lists.linux.dev, conor+dt@kernel.org,
	lee@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH RFC 03/12] dt-bindings: usb: Add Qualcomm 1st-gen PMIC Type-C
Date: Sat, 26 Sep 2026 12:44:11 +0000	[thread overview]
Message-ID: <20260926124411.B41071F00899@smtp.kernel.org> (raw)
In-Reply-To: <20260926-typec-v1-3-31adc19f32c6@ixit.cz>

> From: David Heidelberg <david@ixit.cz>
> 
> Add a binding for the first generation of the Qualcomm PMIC USB Type-C
> port controller, found on the PM660 and PMI8998 PMICs.
> 
> Unlike the later standalone Type-C peripheral at 0x1500 (e.g. PM8150B),
> the gen1 Type-C CC logic is part of the charger's USBIN peripheral
> (base 0x1300) and signals all Type-C events (CC state change,
> tCCDebounce done, VBUS change and error) through a single aggregate
> "type-c-change" interrupt. The USB PD PHY at 0x1700 is register
> compatible with PM8150B.
> 
> The different interrupt set and register layout make it a separate
> binding rather than another variant of qcom,pmic-typec. As with PM8150B,
> the Type-C block and PD PHY are described as a separate SPMI node from
> the charger.
> 
> Allow typec nodes of the Qualcomm SPMI PMIC to use the new binding as
> well.
> 
> Assisted-by: LLM
> Signed-off-by: David Heidelberg <david@ixit.cz>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260926-typec-v1-0-31adc19f32c6@ixit.cz?part=3


  reply	other threads:[~2026-09-26 12:44 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-26 12:40 [PATCH RFC 00/12] Qualcomm Type-C support for 1st generation David Heidelberg
2026-09-26 12:40 ` David Heidelberg via B4 Relay
2026-09-26 12:40 ` [PATCH RFC 01/12] usb: typec: tcpm: qcom: Release the connector fwnode reference David Heidelberg
2026-09-26 12:40   ` David Heidelberg via B4 Relay
2026-09-26 12:45   ` sashiko-bot
2026-09-28 13:48   ` Heikki Krogerus
2026-09-26 12:40 ` [PATCH RFC 02/12] dt-bindings: usb: qcom,pmic-typec: Update example with vbus-supply David Heidelberg
2026-09-26 12:40   ` David Heidelberg via B4 Relay
2026-09-26 12:45   ` sashiko-bot
2026-09-26 13:34   ` Bryan O'Donoghue
2026-09-26 12:40 ` [PATCH RFC 03/12] dt-bindings: usb: Add Qualcomm 1st-gen PMIC Type-C David Heidelberg
2026-09-26 12:40   ` David Heidelberg via B4 Relay
2026-09-26 12:44   ` sashiko-bot [this message]
2026-09-26 12:40 ` [PATCH RFC 04/12] usb: typec: qcom: Make PMIC port probe selectable David Heidelberg
2026-09-26 12:40   ` David Heidelberg via B4 Relay
2026-09-26 12:45   ` sashiko-bot
2026-09-26 13:39   ` Bryan O'Donoghue
2026-09-26 12:40 ` [PATCH RFC 05/12] usb: typec: qcom: Make typec_port accept also different structure David Heidelberg
2026-09-26 12:40   ` David Heidelberg via B4 Relay
2026-09-26 12:48   ` sashiko-bot
2026-09-26 13:40   ` Bryan O'Donoghue
2026-09-26 12:40 ` [PATCH RFC 06/12] usb: typec: qcom: Add gen1 Type-C port support David Heidelberg
2026-09-26 12:40   ` David Heidelberg via B4 Relay
2026-09-26 12:53   ` sashiko-bot
2026-09-26 14:22   ` Bryan O'Donoghue
2026-09-26 14:32     ` David Heidelberg
2026-09-26 14:41       ` Bryan O'Donoghue
2026-09-26 14:45         ` David Heidelberg
2026-09-26 12:40 ` [PATCH RFC 07/12] arm64: dts: qcom: pm660: Add USB Type-C port controller node David Heidelberg
2026-09-26 12:40   ` David Heidelberg via B4 Relay
2026-09-26 12:45   ` sashiko-bot
2026-09-26 14:25   ` Bryan O'Donoghue
2026-09-26 12:40 ` [PATCH RFC 08/12] arm64: dts: qcom: pmi8998: " David Heidelberg
2026-09-26 12:40   ` David Heidelberg via B4 Relay
2026-09-26 12:45   ` sashiko-bot
2026-09-26 14:28   ` Bryan O'Donoghue
2026-09-26 12:40 ` [PATCH RFC 09/12] arm64: dts: qcom: sdm670-google-common: Enable USB Type-C port controller David Heidelberg
2026-09-26 12:40   ` David Heidelberg via B4 Relay
2026-09-26 12:45   ` sashiko-bot
2026-09-26 12:40 ` [PATCH RFC 10/12] arm64: dts: qcom: sdm845-google-common: " David Heidelberg
2026-09-26 12:40   ` David Heidelberg via B4 Relay
2026-09-26 12:46   ` sashiko-bot
2026-09-26 12:40 ` [PATCH RFC 11/12] arm64: dts: qcom: sdm845-oneplus-common: " David Heidelberg
2026-09-26 12:40   ` David Heidelberg via B4 Relay
2026-09-26 12:49   ` sashiko-bot
2026-09-26 12:40 ` [PATCH RFC 12/12] arm64: dts: qcom: sdm845-shift-axolotl: " David Heidelberg
2026-09-26 12:40   ` David Heidelberg via B4 Relay
2026-09-26 12:49   ` sashiko-bot
2026-09-27 13:05 ` [PATCH RFC 00/12] Qualcomm Type-C support for 1st generation Dmitry Baryshkov
2026-09-27 15:16   ` David Heidelberg
2026-09-27 16:33     ` Dmitry Baryshkov
2026-09-28 15:54       ` Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260926124411.B41071F00899@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=david@ixit.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=lee@kernel.org \
    --cc=mfd@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.