All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "David Heidelberg" <david@ixit.cz>
Cc: lee@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org,
	mfd@lists.linux.dev, robh@kernel.org
Subject: Re: [PATCH RFC 12/12] arm64: dts: qcom: sdm845-shift-axolotl: Enable USB Type-C port controller
Date: Sat, 26 Sep 2026 12:49:10 +0000	[thread overview]
Message-ID: <20260926124910.E74041F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260926-typec-v1-12-31adc19f32c6@ixit.cz>

> From: David Heidelberg <david@ixit.cz>
> 
> Enable the PMI8998 Type-C port controller with a USB-C connector
> description for the SHIFT6mq:
> 
>   - Sink-only power role with a 5V/3A sink PDO
>   - Dual-role data with USB role switching
> 
> The VBUS output of the charger is not supported yet, so the port can't
> act as a power source. Describe it as sink-only until VBUS support lands,
> USB host mode is still reachable through a PD data role swap. Higher
> voltage PDOs are left out until the charger driver programs the allowed
> USBIN adapter voltage.
> 
> Wire the USB-C connector port graph:
>   - port@0: DWC3 HS endpoint for USB role switching
>   - port@1: QMP combo PHY for SS lane orientation
> 
> Switch the DWC3 controller from peripheral-only to OTG mode with
> usb-role-switch to allow the TCPM framework to control USB host/device
> role based on CC pin detection.
> 
> DisplayPort Alt Mode is not advertised yet, it will be added together
> with enabling the DP controller (mdss_dp).
> 
> Assisted-by: LLM
> Signed-off-by: David Heidelberg <david@ixit.cz>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260926-typec-v1-0-31adc19f32c6@ixit.cz?part=12


  reply	other threads:[~2026-09-26 12:49 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-26 12:40 [PATCH RFC 00/12] Qualcomm Type-C support for 1st generation David Heidelberg via B4 Relay
2026-09-26 12:40 ` David Heidelberg
2026-09-26 12:40 ` [PATCH RFC 01/12] usb: typec: tcpm: qcom: Release the connector fwnode reference David Heidelberg via B4 Relay
2026-09-26 12:40   ` David Heidelberg
2026-09-26 12:45   ` sashiko-bot
2026-09-28 13:48   ` Heikki Krogerus
2026-09-26 12:40 ` [PATCH RFC 02/12] dt-bindings: usb: qcom,pmic-typec: Update example with vbus-supply David Heidelberg via B4 Relay
2026-09-26 12:40   ` David Heidelberg
2026-09-26 12:45   ` sashiko-bot
2026-09-26 13:34   ` Bryan O'Donoghue
2026-09-26 12:40 ` [PATCH RFC 03/12] dt-bindings: usb: Add Qualcomm 1st-gen PMIC Type-C David Heidelberg via B4 Relay
2026-09-26 12:40   ` David Heidelberg
2026-09-26 12:44   ` sashiko-bot
2026-09-26 12:40 ` [PATCH RFC 04/12] usb: typec: qcom: Make PMIC port probe selectable David Heidelberg via B4 Relay
2026-09-26 12:40   ` David Heidelberg
2026-09-26 12:45   ` sashiko-bot
2026-09-26 13:39   ` Bryan O'Donoghue
2026-09-26 12:40 ` [PATCH RFC 05/12] usb: typec: qcom: Make typec_port accept also different structure David Heidelberg via B4 Relay
2026-09-26 12:40   ` David Heidelberg
2026-09-26 12:48   ` sashiko-bot
2026-09-26 13:40   ` Bryan O'Donoghue
2026-09-26 12:40 ` [PATCH RFC 06/12] usb: typec: qcom: Add gen1 Type-C port support David Heidelberg via B4 Relay
2026-09-26 12:40   ` David Heidelberg
2026-09-26 12:53   ` sashiko-bot
2026-09-26 14:22   ` Bryan O'Donoghue
2026-09-26 14:32     ` David Heidelberg
2026-09-26 14:41       ` Bryan O'Donoghue
2026-09-26 14:45         ` David Heidelberg
2026-09-26 12:40 ` [PATCH RFC 07/12] arm64: dts: qcom: pm660: Add USB Type-C port controller node David Heidelberg via B4 Relay
2026-09-26 12:40   ` David Heidelberg
2026-09-26 12:45   ` sashiko-bot
2026-09-26 14:25   ` Bryan O'Donoghue
2026-09-26 12:40 ` [PATCH RFC 08/12] arm64: dts: qcom: pmi8998: " David Heidelberg via B4 Relay
2026-09-26 12:40   ` David Heidelberg
2026-09-26 12:45   ` sashiko-bot
2026-09-26 14:28   ` Bryan O'Donoghue
2026-09-26 12:40 ` [PATCH RFC 09/12] arm64: dts: qcom: sdm670-google-common: Enable USB Type-C port controller David Heidelberg via B4 Relay
2026-09-26 12:40   ` David Heidelberg
2026-09-26 12:45   ` sashiko-bot
2026-09-26 12:40 ` [PATCH RFC 10/12] arm64: dts: qcom: sdm845-google-common: " David Heidelberg via B4 Relay
2026-09-26 12:40   ` David Heidelberg
2026-09-26 12:46   ` sashiko-bot
2026-09-26 12:40 ` [PATCH RFC 11/12] arm64: dts: qcom: sdm845-oneplus-common: " David Heidelberg via B4 Relay
2026-09-26 12:40   ` David Heidelberg
2026-09-26 12:49   ` sashiko-bot
2026-09-26 12:40 ` [PATCH RFC 12/12] arm64: dts: qcom: sdm845-shift-axolotl: " David Heidelberg via B4 Relay
2026-09-26 12:40   ` David Heidelberg
2026-09-26 12:49   ` sashiko-bot [this message]
2026-09-27 13:05 ` [PATCH RFC 00/12] Qualcomm Type-C support for 1st generation Dmitry Baryshkov
2026-09-27 15:16   ` David Heidelberg
2026-09-27 16:33     ` Dmitry Baryshkov
2026-09-28 15:54       ` Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260926124910.E74041F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=david@ixit.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=lee@kernel.org \
    --cc=mfd@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.