[jic23-iio:testing 66/82] drivers/iio/magnetometer/ak8975.c:627 ak8975_setup() warn: passing zero to 'dev_err_probe'

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Dan Carpenter <error27@gmail.com>
To: oe-kbuild@lists.linux.dev,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
	"Jonathan Cameron" <jonathan.cameron@oss.qualcomm.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Joshua Crofts" <joshua.crofts1@gmail.com>
Subject: [jic23-iio:testing 66/82] drivers/iio/magnetometer/ak8975.c:627 ak8975_setup() warn: passing zero to 'dev_err_probe'
Date: Sun, 27 Sep 2026 17:49:30 +0300	[thread overview]
Message-ID: <202609270219.cCECv2b8-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git testing
head:   e5b9e42a20392b669097c8c4aa09c3aed82ba10c
commit: 4f8ee49c28b1a537a23e64cfee6ff2e5ec616f7f [66/82] iio: magnetometer: ak8975: use temporary variable for struct device
config: x86_64-randconfig-2200-20260926 (https://download.01.org/0day-ci/archive/20260927/202609270219.cCECv2b8-lkp@intel.com/config)
compiler: clang version 22.1.8 (https://github.com/llvm/llvm-project ca7933e47d3a3451d81e72ac174dcb5aa28b59d1)
smatch: v0.5.0-9187-g5189e3fb

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202609270219.cCECv2b8-lkp@intel.com/

smatch warnings:
drivers/iio/magnetometer/ak8975.c:627 ak8975_setup() warn: passing zero to 'dev_err_probe'

vim +/dev_err_probe +627 drivers/iio/magnetometer/ak8975.c

79ab48ae4f9e06 drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-05-11  608  static int ak8975_setup(struct ak8975_data *data)
3285aae1edd04f drivers/staging/iio/magnetometer/ak8975.c Andrew Chew      2010-09-08  609  {
79ab48ae4f9e06 drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-05-11  610  	struct i2c_client *client = data->client;
4f8ee49c28b1a5 drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-09-20  611  	struct device *dev = &client->dev;
3285aae1edd04f drivers/staging/iio/magnetometer/ak8975.c Andrew Chew      2010-09-08  612  	int ret;
3285aae1edd04f drivers/staging/iio/magnetometer/ak8975.c Andrew Chew      2010-09-08  613  
3285aae1edd04f drivers/staging/iio/magnetometer/ak8975.c Andrew Chew      2010-09-08  614  	/* Write the fused rom access mode. */
286f74c2533ac4 drivers/iio/magnetometer/ak8975.c         Gwendal Grignou  2014-11-21  615  	ret = ak8975_set_mode(data, FUSE_ROM);
4f8ee49c28b1a5 drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-09-20  616  	if (ret < 0)
4f8ee49c28b1a5 drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-09-20  617  		return dev_err_probe(dev, ret, "Error in setting fuse access mode\n");
3285aae1edd04f drivers/staging/iio/magnetometer/ak8975.c Andrew Chew      2010-09-08  618  
3285aae1edd04f drivers/staging/iio/magnetometer/ak8975.c Andrew Chew      2010-09-08  619  	/* Get asa data and store in the device data. */
dbb1f2fa2bba8d drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-05-05  620  	ret = i2c_smbus_read_i2c_block_data_or_emulated(client,
dbb1f2fa2bba8d drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-05-05  621  							data->def->ctrl_regs[ASA_BASE],
dbb1f2fa2bba8d drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-05-05  622  							sizeof(data->asa),
dbb1f2fa2bba8d drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-05-05  623  							data->asa);
4f8ee49c28b1a5 drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-09-20  624  	if (ret < 0)
4f8ee49c28b1a5 drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-09-20  625  		return dev_err_probe(dev, ret, "Not able to read asa data\n");
4f8ee49c28b1a5 drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-09-20  626  	if (ret != sizeof(data->asa))
4f8ee49c28b1a5 drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-09-20 @627  		return dev_err_probe(dev, ret, "Error reading asa data\n");
                                                                                                                                  ^^^
s/ret/-EINVAL/

3285aae1edd04f drivers/staging/iio/magnetometer/ak8975.c Andrew Chew      2010-09-08  628  
040f3e5833b942 drivers/staging/iio/magnetometer/ak8975.c Leed Aguilar     2012-06-06  629  	/* After reading fuse ROM data set power-down mode */
286f74c2533ac4 drivers/iio/magnetometer/ak8975.c         Gwendal Grignou  2014-11-21  630  	ret = ak8975_set_mode(data, POWER_DOWN);
4f8ee49c28b1a5 drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-09-20  631  	if (ret < 0)
4f8ee49c28b1a5 drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-09-20  632  		return dev_err_probe(dev, ret, "Error in setting power-down mode\n");
94a6d5cf7caa50 drivers/iio/magnetometer/ak8975.c         Jacek Anaszewski 2013-05-07  633  
2c289e63944467 drivers/iio/magnetometer/ak8975.c         Linus Walleij    2019-12-02  634  	if (data->eoc_gpiod || client->irq > 0) {
94a6d5cf7caa50 drivers/iio/magnetometer/ak8975.c         Jacek Anaszewski 2013-05-07  635  		ret = ak8975_setup_irq(data);
4f8ee49c28b1a5 drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-09-20  636  		if (ret < 0)
4f8ee49c28b1a5 drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-09-20  637  			return dev_err_probe(dev, ret, "Error setting data ready interrupt\n");
94a6d5cf7caa50 drivers/iio/magnetometer/ak8975.c         Jacek Anaszewski 2013-05-07  638  	}
94a6d5cf7caa50 drivers/iio/magnetometer/ak8975.c         Jacek Anaszewski 2013-05-07  639  
286f74c2533ac4 drivers/iio/magnetometer/ak8975.c         Gwendal Grignou  2014-11-21  640  	data->raw_to_gauss[0] = data->def->raw_to_gauss(data->asa[0]);
286f74c2533ac4 drivers/iio/magnetometer/ak8975.c         Gwendal Grignou  2014-11-21  641  	data->raw_to_gauss[1] = data->def->raw_to_gauss(data->asa[1]);
286f74c2533ac4 drivers/iio/magnetometer/ak8975.c         Gwendal Grignou  2014-11-21  642  	data->raw_to_gauss[2] = data->def->raw_to_gauss(data->asa[2]);
3285aae1edd04f drivers/staging/iio/magnetometer/ak8975.c Andrew Chew      2010-09-08  643  
3285aae1edd04f drivers/staging/iio/magnetometer/ak8975.c Andrew Chew      2010-09-08  644  	return 0;
3285aae1edd04f drivers/staging/iio/magnetometer/ak8975.c Andrew Chew      2010-09-08  645  }

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

WARNING: multiple messages have this Message-ID (diff)

From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: [jic23-iio:testing 66/82] drivers/iio/magnetometer/ak8975.c:627 ak8975_setup() warn: passing zero to 'dev_err_probe'
Date: Sun, 27 Sep 2026 02:45:48 +0200	[thread overview]
Message-ID: <202609270219.cCECv2b8-lkp@intel.com> (raw)

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
CC: "Nuno Sá" <nuno.sa@analog.com>
CC: Joshua Crofts <joshua.crofts1@gmail.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git testing
head:   e5b9e42a20392b669097c8c4aa09c3aed82ba10c
commit: 4f8ee49c28b1a537a23e64cfee6ff2e5ec616f7f [66/82] iio: magnetometer: ak8975: use temporary variable for struct device
:::::: branch date: 23 hours ago
:::::: commit date: 2 days ago
config: x86_64-randconfig-2200-20260926 (https://download.01.org/0day-ci/archive/20260927/202609270219.cCECv2b8-lkp@intel.com/config)
compiler: clang version 22.1.8 (https://github.com/llvm/llvm-project ca7933e47d3a3451d81e72ac174dcb5aa28b59d1)
smatch: v0.5.0-9187-g5189e3fb

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202609270219.cCECv2b8-lkp@intel.com/

smatch warnings:
drivers/iio/magnetometer/ak8975.c:627 ak8975_setup() warn: passing zero to 'dev_err_probe'

vim +/dev_err_probe +627 drivers/iio/magnetometer/ak8975.c

94a6d5cf7caa50 drivers/iio/magnetometer/ak8975.c         Jacek Anaszewski 2013-05-07  603  
3285aae1edd04f drivers/staging/iio/magnetometer/ak8975.c Andrew Chew      2010-09-08  604  /*
3285aae1edd04f drivers/staging/iio/magnetometer/ak8975.c Andrew Chew      2010-09-08  605   * Perform some start-of-day setup, including reading the asa calibration
3285aae1edd04f drivers/staging/iio/magnetometer/ak8975.c Andrew Chew      2010-09-08  606   * values and caching them.
3285aae1edd04f drivers/staging/iio/magnetometer/ak8975.c Andrew Chew      2010-09-08  607   */
79ab48ae4f9e06 drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-05-11  608  static int ak8975_setup(struct ak8975_data *data)
3285aae1edd04f drivers/staging/iio/magnetometer/ak8975.c Andrew Chew      2010-09-08  609  {
79ab48ae4f9e06 drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-05-11  610  	struct i2c_client *client = data->client;
4f8ee49c28b1a5 drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-09-20  611  	struct device *dev = &client->dev;
3285aae1edd04f drivers/staging/iio/magnetometer/ak8975.c Andrew Chew      2010-09-08  612  	int ret;
3285aae1edd04f drivers/staging/iio/magnetometer/ak8975.c Andrew Chew      2010-09-08  613  
3285aae1edd04f drivers/staging/iio/magnetometer/ak8975.c Andrew Chew      2010-09-08  614  	/* Write the fused rom access mode. */
286f74c2533ac4 drivers/iio/magnetometer/ak8975.c         Gwendal Grignou  2014-11-21  615  	ret = ak8975_set_mode(data, FUSE_ROM);
4f8ee49c28b1a5 drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-09-20  616  	if (ret < 0)
4f8ee49c28b1a5 drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-09-20  617  		return dev_err_probe(dev, ret, "Error in setting fuse access mode\n");
3285aae1edd04f drivers/staging/iio/magnetometer/ak8975.c Andrew Chew      2010-09-08  618  
3285aae1edd04f drivers/staging/iio/magnetometer/ak8975.c Andrew Chew      2010-09-08  619  	/* Get asa data and store in the device data. */
dbb1f2fa2bba8d drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-05-05  620  	ret = i2c_smbus_read_i2c_block_data_or_emulated(client,
dbb1f2fa2bba8d drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-05-05  621  							data->def->ctrl_regs[ASA_BASE],
dbb1f2fa2bba8d drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-05-05  622  							sizeof(data->asa),
dbb1f2fa2bba8d drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-05-05  623  							data->asa);
4f8ee49c28b1a5 drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-09-20  624  	if (ret < 0)
4f8ee49c28b1a5 drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-09-20  625  		return dev_err_probe(dev, ret, "Not able to read asa data\n");
4f8ee49c28b1a5 drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-09-20  626  	if (ret != sizeof(data->asa))
4f8ee49c28b1a5 drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-09-20 @627  		return dev_err_probe(dev, ret, "Error reading asa data\n");
3285aae1edd04f drivers/staging/iio/magnetometer/ak8975.c Andrew Chew      2010-09-08  628  
040f3e5833b942 drivers/staging/iio/magnetometer/ak8975.c Leed Aguilar     2012-06-06  629  	/* After reading fuse ROM data set power-down mode */
286f74c2533ac4 drivers/iio/magnetometer/ak8975.c         Gwendal Grignou  2014-11-21  630  	ret = ak8975_set_mode(data, POWER_DOWN);
4f8ee49c28b1a5 drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-09-20  631  	if (ret < 0)
4f8ee49c28b1a5 drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-09-20  632  		return dev_err_probe(dev, ret, "Error in setting power-down mode\n");
94a6d5cf7caa50 drivers/iio/magnetometer/ak8975.c         Jacek Anaszewski 2013-05-07  633  
2c289e63944467 drivers/iio/magnetometer/ak8975.c         Linus Walleij    2019-12-02  634  	if (data->eoc_gpiod || client->irq > 0) {
94a6d5cf7caa50 drivers/iio/magnetometer/ak8975.c         Jacek Anaszewski 2013-05-07  635  		ret = ak8975_setup_irq(data);
4f8ee49c28b1a5 drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-09-20  636  		if (ret < 0)
4f8ee49c28b1a5 drivers/iio/magnetometer/ak8975.c         Andy Shevchenko  2026-09-20  637  			return dev_err_probe(dev, ret, "Error setting data ready interrupt\n");
94a6d5cf7caa50 drivers/iio/magnetometer/ak8975.c         Jacek Anaszewski 2013-05-07  638  	}
94a6d5cf7caa50 drivers/iio/magnetometer/ak8975.c         Jacek Anaszewski 2013-05-07  639  
286f74c2533ac4 drivers/iio/magnetometer/ak8975.c         Gwendal Grignou  2014-11-21  640  	data->raw_to_gauss[0] = data->def->raw_to_gauss(data->asa[0]);
286f74c2533ac4 drivers/iio/magnetometer/ak8975.c         Gwendal Grignou  2014-11-21  641  	data->raw_to_gauss[1] = data->def->raw_to_gauss(data->asa[1]);
286f74c2533ac4 drivers/iio/magnetometer/ak8975.c         Gwendal Grignou  2014-11-21  642  	data->raw_to_gauss[2] = data->def->raw_to_gauss(data->asa[2]);
3285aae1edd04f drivers/staging/iio/magnetometer/ak8975.c Andrew Chew      2010-09-08  643  
3285aae1edd04f drivers/staging/iio/magnetometer/ak8975.c Andrew Chew      2010-09-08  644  	return 0;
3285aae1edd04f drivers/staging/iio/magnetometer/ak8975.c Andrew Chew      2010-09-08  645  }
3285aae1edd04f drivers/staging/iio/magnetometer/ak8975.c Andrew Chew      2010-09-08  646  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

next             reply	other threads:[~2026-09-27 14:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-27  0:45 kernel test robot [this message]
2026-09-27 14:49 ` [jic23-iio:testing 66/82] drivers/iio/magnetometer/ak8975.c:627 ak8975_setup() warn: passing zero to 'dev_err_probe' Dan Carpenter
2026-09-28 16:38 ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202609270219.cCECv2b8-lkp@intel.com \
    --to=error27@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=jonathan.cameron@oss.qualcomm.com \
    --cc=joshua.crofts1@gmail.com \
    --cc=lkp@intel.com \
    --cc=nuno.sa@analog.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.